https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- (In reply to Jonathan Druart from comment #1)

They are debug messages, if syslog is not configured to log "debug" I would not expect them to be in the logs.

Are they useful in any way? To me it just says "there were x number of hashes here", not sure if that makes me much wiser? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98740&action=edit Bug 24629: SIP log - Display barcode instead of hash -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #5)

(In reply to Magnus Enger from comment #0)

...

Feb 11 09:00:23 koha koha_sip_koha[13575]: ILS::Checkout: patron 123 has checked out HASH(0x55a5b187f858), HASH(0x55a5b1896ad0), HASH(0x55a5b18a6cf0)

This one is weird, it seems that sometimes we have hash and itemnumber:

Few lines before the syslog statement: 167 push( @{ $patron->{items} }, $item_id );

But, in renew: 458 foreach my $i (@{$patron->{items}}) {

then we are using $i->{barcode}, so it is supposed to be a hashref. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99370&action=edit Bug 24629: SIP patron items contains an array of hashes $patron->{items} contains the borrowers checkouts as an array of hashes { barcode => $item->barcode } When printing to log we assumed these were only barcodes This patch pushes the current checkout as a hash and maps the values retrieved to a string To test: 1 - Enable SIP debug mode 2 - Perform multiple checkouts for a patron 3 - Note the messages like: koha koha_sip_koha[13575]: ILS::Checkout: patron 123 has checked out HASH(0x55a5b187f858), HASH(0x55a5b1896ad0), HASH(0x55a5b18a6cf0), 7826832 4 - Apply patch 5 - Restart all the things 6 - Do some checkouts via SIP 6 - Messages should now have barcodes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99370|0 |1 is obsolete| | --- Comment #11 from Magnus Enger <magnus@libriotech.no> --- Created attachment 99480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99480&action=edit Bug 24629: SIP patron items contains an array of hashes $patron->{items} contains the borrowers checkouts as an array of hashes { barcode => $item->barcode } When printing to log we assumed these were only barcodes This patch pushes the current checkout as a hash and maps the values retrieved to a string To test: 1 - Enable SIP debug mode 2 - Perform multiple checkouts for a patron 3 - Note the messages like: koha koha_sip_koha[13575]: ILS::Checkout: patron 123 has checked out HASH(0x55a5b187f858), HASH(0x55a5b1896ad0), HASH(0x55a5b18a6cf0), 7826832 4 - Apply patch 5 - Restart all the things 6 - Do some checkouts via SIP 6 - Messages should now have barcodes Signed-off-by: Magnus Enger <magnus@libriotech.no> This patch and the one from Jonathan taken together seems to solve the problem, I no longer see messages with HASH(...). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99480|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99488&action=edit Bug 24629: SIP patron items contains an array of hashes $patron->{items} contains the borrowers checkouts as an array of hashes { barcode => $item->barcode } When printing to log we assumed these were only barcodes This patch pushes the current checkout as a hash and maps the values retrieved to a string To test: 1 - Enable SIP debug mode 2 - Perform multiple checkouts for a patron 3 - Note the messages like: koha koha_sip_koha[13575]: ILS::Checkout: patron 123 has checked out HASH(0x55a5b187f858), HASH(0x55a5b1896ad0), HASH(0x55a5b18a6cf0), 7826832 4 - Apply patch 5 - Restart all the things 6 - Do some checkouts via SIP 6 - Messages should now have barcodes Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #14)

Trivial fix, thanks guys..

PQA

That is not that trivial in my opinion. We should track down a bit where does come from (and the possible problems) the 2 different types in the item list (scalar vs hashref). I think I asked Nick last Friday but cannot remember the conclusion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24629 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #17)

(In reply to Jonathan Druart from comment #15)

...

(In reply to Martin Renvoize from comment #14)

...

Trivial fix, thanks guys..

PQA

That is not that trivial in my opinion. We should track down a bit where does come from (and the possible problems) the 2 different types in the item list (scalar vs hashref).

I think I asked Nick last Friday but cannot remember the conclusion.

Did you manage to clear this one up?

I added a second patch, it was another place where we had a more complex object than assumed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.