[Bug 9265] New: Switch to HTML5 doctype in OPAC and staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265 Bug ID: 9265 Summary: Switch to HTML5 doctype in OPAC and staff client Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org With some patches using HTML5 already in the pipeline (Bug 8377) and some useful features already showing broad support (http://caniuse.com/#feat=form-validation, http://caniuse.com/#feat=input-placeholder), I think it's time to show our intention to start using these new features by updating Koha's doctype to an HTML5 one: <!DOCTYPE html> I propose that we do not change our HTML markup guidelines which require that tags be closed, attributes be quoted, etc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #1 from Mirko Tietgen <mirko@abunchofthings.net> --- +1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14052&action=edit Bug 9265 - Switch to HTML5 doctype in OPAC and staff client This patch replaces the XHTML DOCTYPE with an HTML5 one. The HTML5 validator seems to be significantly different than the XHTML one, so I'm seeing lots of new errors. This patch includes corrections for one: Deprecation of the "language" attribute of <script> tags. To test, view pages in the OPAC and staff client. They should appear as normal. Numerous validation follow-ups will be required, but I suggest these be handled incrementally. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14052|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14078&action=edit Bug 9265 - Switch to HTML5 doctype in OPAC and staff client This patch replaces the XHTML DOCTYPE with an HTML5 one. The HTML5 validator seems to be significantly different than the XHTML one, so I'm seeing lots of new errors. This patch includes corrections for one: Deprecation of the "language" attribute of <script> tags. To test, view pages in the OPAC and staff client. They should appear as normal. Numerous validation follow-ups will be required, but I suggest these be handled incrementally. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> test on some intranet pages and I found no regression. (chromium and firefox). The w3c page about the doctype: http://www.w3.org/TR/html5-diff/#doctype -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265 --- Comment #4 from Mason James <mtj@kohaaloha.com> --- Created attachment 14925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14925&action=edit Bug 9265 - Switch to HTML5 doctype in OPAC and staff client This patch replaces the XHTML DOCTYPE with an HTML5 one. The HTML5 validator seems to be significantly different than the XHTML one, so I'm seeing lots of new errors. This patch includes corrections for one: Deprecation of the "language" attribute of <script> tags. To test, view pages in the OPAC and staff client. They should appear as normal. Numerous validation follow-ups will be required, but I suggest these be handled incrementally. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> test on some intranet pages and I found no regression. (chromium and firefox). The w3c page about the doctype: http://www.w3.org/TR/html5-diff/#doctype -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265 --- Comment #5 from Mason James <mtj@kohaaloha.com> --- Created attachment 14926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14926&action=edit Bug 9265 - Switch to HTML5 doctype in OPAC and staff client This patch replaces the XHTML DOCTYPE with an HTML5 one. The HTML5 validator seems to be significantly different than the XHTML one, so I'm seeing lots of new errors. This patch includes corrections for one: Deprecation of the "language" attribute of <script> tags. To test, view pages in the OPAC and staff client. They should appear as normal. Numerous validation follow-ups will be required, but I suggest these be handled incrementally. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> test on some intranet pages and I found no regression. (chromium and firefox). The w3c page about the doctype: http://www.w3.org/TR/html5-diff/#doctype Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14925|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #5)
Created attachment 14926 [details] Bug 9265 - Switch to HTML5 doctype in OPAC and staff client
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> test on some intranet pages and I found no regression. (chromium and firefox). The w3c page about the doctype: http://www.w3.org/TR/html5-diff/#doctype
Signed-off-by: Mason James <mtj@kohaaloha.com>
passing QA on this patch tested on firefox, chrome, opera, and safari browers - with no regressions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14078|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. One validation error I noticed on a lot of pages in the OPAC was "Line 454, Column 47: Element script must not have attribute charset unless attribute src is also specified." (the line and column number changed, of course) However, I think this is still a good patch to get in right away. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org