[Bug 22880] New: Convert opacheader system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Bug ID: 22880 Summary: Convert opacheader system preference to news block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 22318 Target Milestone: --- Building on 22318, the opacheader system preference should be converted to a Koha news block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 [Bug 22318] Extend Koha news feature to include other content areas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89517&action=edit Bug 22880: Convert opacheader system preference to news block This patch builds on Bug 22318 to move the opacheader system preference into the Koha news system, making it possible to have language- and library-specific content. It extends the original patch by adding an option to the template plugin specifying whether the content title should be shown (probably should be a flag in opac_news). It also adds a wrapper div with the content location as the ID (e.g. 'opacheader'). This will make it slightly more backwards-compatible with CSS customizations. To test you should have some content in the opacheader system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opacheader system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opacheader is now stored in a news item with the location 'opacheader_en.' - Go to Administration -> System preferences and confirm that the opacheader preference has been removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- The QA tool is giving me a couple of errors which I could use some help understanding: Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc line 23. ...and... FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid FAIL valid_template koha_news_block: not found -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc line 23. Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc line 23. This means that there are warnings with this script, but they are the same with and without your patch - so no blocker. FAIL valid_template koha_news_block: not found I think this is a false positive. I think may the script doesn't manage the PROCESS and the BLOCK being in different files as it's here with the .inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #3)
Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/ html_helpers.inc line 23. Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/ html_helpers.inc line 23.
This means that there are warnings with this script, but they are the same with and without your patch - so no blocker.
FAIL valid_template koha_news_block: not found
I think this is a false positive. I think may the script doesn't manage the PROCESS and the BLOCK being in different files as it's here with the .inc
Yes it is a false positive. html_helpers.inc is processed in doc-head-close, so we are good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- However we should have the USE raw on top, in case the block is called from a file that does not have it yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Bug 22880 depends on bug 22318, which changed state. Bug 22318 Summary: Extend Koha news feature to include other content areas https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Bug 22880 depends on bug 22318, which changed state. Bug 22318 Summary: Extend Koha news feature to include other content areas https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90495&action=edit Bug 22880: Use placeholders Always. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Some libraries have very customized CSS in the OPACHeader syspref and specific CSS to go along with. This has the potential to impact how that displays and could problems, I think. Which could be problematic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #7)
Some libraries have very customized CSS in the OPACHeader syspref and specific CSS to go along with. This has the potential to impact how that displays and could problems, I think. Which could be problematic.
It should convert nicely, but the CSS might not be visible straight away unless you use the HTML editor. Do you have an example that could be problematic? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- It does display well, once I manually add the HTML from the opacheader syspref. For me it does not copy the value from the old syspref to the 'opacheader_en.' area. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89517|0 |1 is obsolete| | --- Comment #10 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 92207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92207&action=edit Bug 22880: Convert opacheader system preference to news block This patch builds on Bug 22318 to move the opacheader system preference into the Koha news system, making it possible to have language- and library-specific content. It extends the original patch by adding an option to the template plugin specifying whether the content title should be shown (probably should be a flag in opac_news). It also adds a wrapper div with the content location as the ID (e.g. 'opacheader'). This will make it slightly more backwards-compatible with CSS customizations. To test you should have some content in the opacheader system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opacheader system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opacheader is now stored in a news item with the location 'opacheader_en.' - Go to Administration -> System preferences and confirm that the opacheader preference has been removed. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90495|0 |1 is obsolete| | --- Comment #11 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 92208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92208&action=edit Bug 22880: Use placeholders Always. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #12 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Signed off as all works as expected. One minor thing, unsure if you'd want to do a follow-up for this or not: After applying the patch, the header had slightly less left margin/left padding. Everything else looks good! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92207|0 |1 is obsolete| | Attachment #92208|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92592&action=edit Bug 22880: Convert opacheader system preference to news block This patch builds on Bug 22318 to move the opacheader system preference into the Koha news system, making it possible to have language- and library-specific content. It extends the original patch by adding an option to the template plugin specifying whether the content title should be shown (probably should be a flag in opac_news). It also adds a wrapper div with the content location as the ID (e.g. 'opacheader'). This will make it slightly more backwards-compatible with CSS customizations. To test you should have some content in the opacheader system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opacheader system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opacheader is now stored in a news item with the location 'opacheader_en.' - Go to Administration -> System preferences and confirm that the opacheader preference has been removed. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92593&action=edit Bug 22880: Use placeholders Always. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92594&action=edit Bug 22880: (follow-up) Define OpacHeader variable for conditional This follow-up uses the updates introduced by Bug 23253 as a model for improving the display of opacheader. Adding the OpacHeader variable allows the template to check for its existence and display some container markup around opacheader if it exists. This will help ease the transition for libraries who depend on the #opacheader id for styling. To test, apply the patch and test the OPAC with an 'opacheader' item defined. The content should be displayed on the page inside '<div id="opacheader"></div>.' Delete the 'opacheader' news item and reload the OPAC page. There should no longer be an #opacheader div. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Rebased! (In reply to Hayley Mapley from comment #12)
After applying the patch, the header had slightly less left margin/left padding.
My follow-up addresses this. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92592|0 |1 is obsolete| | --- Comment #17 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 92600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92600&action=edit Bug 22880: Convert opacheader system preference to news block This patch builds on Bug 22318 to move the opacheader system preference into the Koha news system, making it possible to have language- and library-specific content. It extends the original patch by adding an option to the template plugin specifying whether the content title should be shown (probably should be a flag in opac_news). It also adds a wrapper div with the content location as the ID (e.g. 'opacheader'). This will make it slightly more backwards-compatible with CSS customizations. To test you should have some content in the opacheader system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opacheader system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opacheader is now stored in a news item with the location 'opacheader_en.' - Go to Administration -> System preferences and confirm that the opacheader preference has been removed. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92593|0 |1 is obsolete| | --- Comment #18 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 92601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92601&action=edit Bug 22880: Use placeholders Always. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92594|0 |1 is obsolete| | --- Comment #19 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 92602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92602&action=edit Bug 22880: (follow-up) Define OpacHeader variable for conditional This follow-up uses the updates introduced by Bug 23253 as a model for improving the display of opacheader. Adding the OpacHeader variable allows the template to check for its existence and display some container markup around opacheader if it exists. This will help ease the transition for libraries who depend on the #opacheader id for styling. To test, apply the patch and test the OPAC with an 'opacheader' item defined. The content should be displayed on the page inside '<div id="opacheader"></div>.' Delete the 'opacheader' news item and reload the OPAC page. There should no longer be an #opacheader div. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794 [Bug 23794] Convert OpacMainUserBlock system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23798 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23798 [Bug 23798] Convert OpacMaintenanceNotice system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797 [Bug 23797] Convert OpacLoginInstructions system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23796 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 [Bug 23796] Convert OpacCustomSearch system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23795 [Bug 23795] Convert OpacCredits system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Problem with required Title field in Tools/News. Leaving the title blank somehow is not a good idea. You can't edit the record now. Opacheader shows more text than anticipated: I had this in the pref <h4>TEST</h4> But the contents of another news item (location All) is shown too. Probably not wanted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96209&action=edit Bug 22880: (follow-up) Use global language variable for news language This patch removes news-specific code for defining the language of news items queried for the OPAC home page. An identical language variable is already defined globally. Previous to this patch an 'opacheader' news item would only appear on the OPAC home page. Now it should appear on all OPAC pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96209|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96210&action=edit Bug 22880: (follow-up) Loose ends: Better DB update, global inclusion, etc. This patch makes a number of improvements and ties up some loose ends where the old system preference usage wasn't getting replaced. - Removes news-specific code for defining the language of news items queried for the OPAC home page. An identical language variable is already defined globally. Previous to this patch an 'opacheader' news item would only appear on the OPAC home page. Now it should appear on all OPAC pages. - Changes the database update so that 'opacheader' news items will be inserted with a default title, matching the interface's requirement that the title field be populated. - The database update will also now insert the old opacheader system preference contents into the news item for all active languages as defined in the 'opaclanguages' system preference. This helps match the previous behavior in which the opacheader contents were the same for all languages. - Adds support for the new opacheader news item to the self checkout, self check-in, and OPAC maintenance pages. - Updates sysprefs.t which was using the opacheader preference to test on. I've changed it to use URLLinkText instead. - Removes the addition of the opacheader system preference from the installation SQL file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #21)
Leaving the title blank somehow is not a good idea.
The revised db update fixes this by inserting some default text in the title (which isn't displayed anyway).
Opacheader shows more text than anticipated: I had this in the pref <h4>TEST</h4> But the contents of another news item (location All) is shown too. Probably not wanted.
I can't reproduce this problem. Can you please test again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #25 from Owen Leonard <oleonard@myacpl.org> ---
Opacheader shows more text than anticipated: I had this in the pref <h4>TEST</h4> But the contents of another news item (location All) is shown too.
I think I've discovered at least one way this can happen: My opaclanguages preference contained a language which wasn't actually installed and enabled. The DB update trusted the value for opaclanguages and inserted a news item using that location. Upon edit, the Koha news interface tries to pre-select the location declared in the news item. Because the translation doesn't actually exist on the system it is unable to pre-select the right value. With no pre-selected option it defaults to blank. If you don't notice this, upon saving your news item the location is set to blank and thus appears in all news-related locations. The disconnect between what is in opaclanguages and what is really installed is probably a product of running a test environment. Is it an issue which need to be addressed in this bug? Is there a reason to offer an "All" option for news items? I think the option probably hasn't been relevant since we added the "Slip" option for news items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24220 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 [Bug 24220] Convert OpacMoreSearches system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24221 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 [Bug 24221] Convert OPACMySummaryNote system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 [Bug 24223] Convert OpacNav system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 [Bug 24224] Convert OpacNavBottom system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #25)
The disconnect between what is in opaclanguages and what is really installed is probably a product of running a test environment. Is it an issue which need to be addressed in this bug?
Could we have similar problems when a language is disabled on the system at a certain point (while having news items connected to it)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #26)
Could we have similar problems when a language is disabled on the system at a certain point (while having news items connected to it)?
The news interface offers the ability to add items in any translation which is present, not just enabled. So in order for the problem to repeat I think you'd have to: 1. Delete a translation without disabling it in the OPAC first. 2. Run this database update. 3. Try to edit a news item in the previously-enabled language. There is also the disconnect between languages enabled in the staff client and those enabled in the OPAC. It sounds like the db update should try to take into account installed languages rather than enabled languages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96219&action=edit Bug 22880: (follow-up) Process all installed languages, not just enabled This patch changes the database update so that the system preference is copied to news items in all installed languages, not just those enabled in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #29 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 98773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98773&action=edit Bug 24366: Improve hashref construction Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92600|0 |1 is obsolete| | Attachment #92601|0 |1 is obsolete| | Attachment #92602|0 |1 is obsolete| | Attachment #96210|0 |1 is obsolete| | Attachment #96219|0 |1 is obsolete| | --- Comment #30 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 98775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98775&action=edit Bug 22880: Convert opacheader system preference to news block Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> bsoletes: 98773 - Bug 24366: Improve hashref construction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com Attachment #98773|0 |1 is obsolete| | --- Comment #31 from Lisette Scheer <lisetteslatah@gmail.com> --- Comment on attachment 98773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98773 Bug 24366: Improve hashref construction My devbox attached an incorrect patch to this bug. Fixing it so I can try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98775|0 |1 is obsolete| | --- Comment #32 from Lisette Scheer <lisetteslatah@gmail.com> --- Comment on attachment 98775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98775 Bug 22880: Convert opacheader system preference to news block My devbox attached an incorrect patch to this bug. Fixing it so I can try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96219|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92600|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92601|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92602|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96210|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92600|0 |1 is obsolete| | --- Comment #33 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 98985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98985&action=edit Bug 22880: Convert opacheader system preference to news block This patch builds on Bug 22318 to move the opacheader system preference into the Koha news system, making it possible to have language- and library-specific content. It extends the original patch by adding an option to the template plugin specifying whether the content title should be shown (probably should be a flag in opac_news). It also adds a wrapper div with the content location as the ID (e.g. 'opacheader'). This will make it slightly more backwards-compatible with CSS customizations. To test you should have some content in the opacheader system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opacheader system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opacheader is now stored in a news item with the location 'opacheader_en.' - Go to Administration -> System preferences and confirm that the opacheader preference has been removed. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96210|0 |1 is obsolete| | --- Comment #34 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 98986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98986&action=edit Bug 22880: (follow-up) Loose ends: Better DB update, global inclusion, etc. This patch makes a number of improvements and ties up some loose ends where the old system preference usage wasn't getting replaced. - Removes news-specific code for defining the language of news items queried for the OPAC home page. An identical language variable is already defined globally. Previous to this patch an 'opacheader' news item would only appear on the OPAC home page. Now it should appear on all OPAC pages. - Changes the database update so that 'opacheader' news items will be inserted with a default title, matching the interface's requirement that the title field be populated. - The database update will also now insert the old opacheader system preference contents into the news item for all active languages as defined in the 'opaclanguages' system preference. This helps match the previous behavior in which the opacheader contents were the same for all languages. - Adds support for the new opacheader news item to the self checkout, self check-in, and OPAC maintenance pages. - Updates sysprefs.t which was using the opacheader preference to test on. I've changed it to use URLLinkText instead. - Removes the addition of the opacheader system preference from the installation SQL file. Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92602|0 |1 is obsolete| | --- Comment #35 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 98987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98987&action=edit Bug 22880: (follow-up) Define OpacHeader variable for conditional This follow-up uses the updates introduced by Bug 23253 as a model for improving the display of opacheader. Adding the OpacHeader variable allows the template to check for its existence and display some container markup around opacheader if it exists. This will help ease the transition for libraries who depend on the #opacheader id for styling. To test, apply the patch and test the OPAC with an 'opacheader' item defined. The content should be displayed on the page inside '<div id="opacheader"></div>.' Delete the 'opacheader' news item and reload the OPAC page. There should no longer be an #opacheader div. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92601|0 |1 is obsolete| | --- Comment #36 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 98988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98988&action=edit Bug 22880: Use placeholders Always. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96219|0 |1 is obsolete| | --- Comment #37 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 98989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98989&action=edit Bug 22880: (follow-up) Process all installed languages, not just enabled This patch changes the database update so that the system preference is copied to news items in all installed languages, not just those enabled in the OPAC. Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Still on this one Marcelr..? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- There we go -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hmm bit of a struggle to get this rebased.. Hang on -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc OK forbidden patterns OK git manipulation SKIP spelling OK tt_valid FAIL valid_template koha_news_block: not found -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Removing Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #43 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #40)
Hmm bit of a struggle to get this rebased.. Hang on
Something with masthead.inc and the atomic update .. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98985|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99362&action=edit Bug 22880: Convert opacheader system preference to news block This patch builds on Bug 22318 to move the opacheader system preference into the Koha news system, making it possible to have language- and library-specific content. It extends the original patch by adding an option to the template plugin specifying whether the content title should be shown (probably should be a flag in opac_news). It also adds a wrapper div with the content location as the ID (e.g. 'opacheader'). This will make it slightly more backwards-compatible with CSS customizations. To test you should have some content in the opacheader system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opacheader system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opacheader is now stored in a news item with the location 'opacheader_en.' - Go to Administration -> System preferences and confirm that the opacheader preference has been removed. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98986|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99363&action=edit Bug 22880: (follow-up) Loose ends: Better DB update, global inclusion, etc. This patch makes a number of improvements and ties up some loose ends where the old system preference usage wasn't getting replaced. - Removes news-specific code for defining the language of news items queried for the OPAC home page. An identical language variable is already defined globally. Previous to this patch an 'opacheader' news item would only appear on the OPAC home page. Now it should appear on all OPAC pages. - Changes the database update so that 'opacheader' news items will be inserted with a default title, matching the interface's requirement that the title field be populated. - The database update will also now insert the old opacheader system preference contents into the news item for all active languages as defined in the 'opaclanguages' system preference. This helps match the previous behavior in which the opacheader contents were the same for all languages. - Adds support for the new opacheader news item to the self checkout, self check-in, and OPAC maintenance pages. - Updates sysprefs.t which was using the opacheader preference to test on. I've changed it to use URLLinkText instead. - Removes the addition of the opacheader system preference from the installation SQL file. Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98987|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99364&action=edit Bug 22880: (follow-up) Define OpacHeader variable for conditional This follow-up uses the updates introduced by Bug 23253 as a model for improving the display of opacheader. Adding the OpacHeader variable allows the template to check for its existence and display some container markup around opacheader if it exists. This will help ease the transition for libraries who depend on the #opacheader id for styling. To test, apply the patch and test the OPAC with an 'opacheader' item defined. The content should be displayed on the page inside '<div id="opacheader"></div>.' Delete the 'opacheader' news item and reload the OPAC page. There should no longer be an #opacheader div. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98988|0 |1 is obsolete| | --- Comment #47 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99365&action=edit Bug 22880: Use placeholders Always. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98989|0 |1 is obsolete| | --- Comment #48 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99366&action=edit Bug 22880: (follow-up) Process all installed languages, not just enabled This patch changes the database update so that the system preference is copied to news items in all installed languages, not just those enabled in the OPAC. Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #47)
Created attachment 99365 [details] [review] Bug 22880: Use placeholders
Always.
Not really the most descriptive commit title and message I've seen.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #50 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_master`.`opac_news`.`number` at row 1 [for Statement "INSERT INTO opac_news ( timestamp,content,title,expirationdate,branchcode,lang,borrowernumber,number ) VALUES ( ?,?,?,?,?,?,?,? )" with ParamValues: 0='2020-02-21', 1="<p>TESTing</p>", 2="Welcome", 3=undef, 4=undef, 5="opacheader_en", 6="51", 7=""] at /usr/share/koha/C4/NewsChannels.pm line 68. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #51 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #50)
DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_master`.`opac_news`.`number` at row 1 [for Statement "INSERT INTO opac_news ( timestamp,content,title,expirationdate,branchcode,lang,borrowernumber,number ) VALUES ( ?,?,?,?,?,?,?,? )" with ParamValues: 0='2020-02-21', 1="<p>TESTing</p>", 2="Welcome", 3=undef, 4=undef, 5="opacheader_en", 6="51", 7=""] at /usr/share/koha/C4/NewsChannels.pm line 68.
Can be prevented by less strict sql mode, needs attention. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Owen, Please verify that my rebase did not introduce another problem in masthead or the atomic update. I'm having issues now getting the opacheader to work. Somehow it looks for opacheader while I add opacheader_en items into the database via the interface. select title,lang from opac_news; +-----------------+---------------+ | title | lang | +-----------------+---------------+ | Welcome to Koha | koha | | What's Next? | koha | | Test | opacheader_en | +-----------------+---------------+ When I deleted my database, the installer crashes now on the language step. So very soon. (Apparently, for some other reason..) DBD::mysql::st execute failed: Table 'koha_master.language_descriptions' doesn't exist [for Statement "SELECT description FROM language_descriptions WHERE subtag=? AND lang=? AND type=?" with ParamValues: 0='en', 1='en', 2='language'] at /usr/share/koha/C4/Languages.pm line 389. DBD::mysql::st fetchrow_hashref failed: fetch() without execute() [for Statement "SELECT description FROM language_descriptions WHERE subtag=? AND lang=? AND type=?" with ParamValues: 0='en', 1='en', 2='language'] at /usr/share/koha/C4/Languages.pm line 390. Keeping this in BLOCKED. Will come back here next week. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #53 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99367&action=edit Bug 22880: (QA follow-up) Fix "koha_news_block: not found" To make qa tools happy again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99362|0 |1 is obsolete| | --- Comment #54 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99490&action=edit Bug 22880: Convert opacheader system preference to news block This patch builds on Bug 22318 to move the opacheader system preference into the Koha news system, making it possible to have language- and library-specific content. It extends the original patch by adding an option to the template plugin specifying whether the content title should be shown (probably should be a flag in opac_news). It also adds a wrapper div with the content location as the ID (e.g. 'opacheader'). This will make it slightly more backwards-compatible with CSS customizations. To test you should have some content in the opacheader system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opacheader system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opacheader is now stored in a news item with the location 'opacheader_en.' - Go to Administration -> System preferences and confirm that the opacheader preference has been removed. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99363|0 |1 is obsolete| | --- Comment #55 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99491&action=edit Bug 22880: (follow-up) Loose ends: Better DB update, global inclusion, etc. This patch makes a number of improvements and ties up some loose ends where the old system preference usage wasn't getting replaced. - Removes news-specific code for defining the language of news items queried for the OPAC home page. An identical language variable is already defined globally. Previous to this patch an 'opacheader' news item would only appear on the OPAC home page. Now it should appear on all OPAC pages. - Changes the database update so that 'opacheader' news items will be inserted with a default title, matching the interface's requirement that the title field be populated. - The database update will also now insert the old opacheader system preference contents into the news item for all active languages as defined in the 'opaclanguages' system preference. This helps match the previous behavior in which the opacheader contents were the same for all languages. - Adds support for the new opacheader news item to the self checkout, self check-in, and OPAC maintenance pages. - Updates sysprefs.t which was using the opacheader preference to test on. I've changed it to use URLLinkText instead. - Removes the addition of the opacheader system preference from the installation SQL file. Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99364|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99492&action=edit Bug 22880: (follow-up) Define OpacHeader variable for conditional This follow-up uses the updates introduced by Bug 23253 as a model for improving the display of opacheader. Adding the OpacHeader variable allows the template to check for its existence and display some container markup around opacheader if it exists. This will help ease the transition for libraries who depend on the #opacheader id for styling. To test, apply the patch and test the OPAC with an 'opacheader' item defined. The content should be displayed on the page inside '<div id="opacheader"></div>.' Delete the 'opacheader' news item and reload the OPAC page. There should no longer be an #opacheader div. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99365|0 |1 is obsolete| | --- Comment #57 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99493&action=edit Bug 22880: Use placeholders Always. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99366|0 |1 is obsolete| | --- Comment #58 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99494&action=edit Bug 22880: (follow-up) Process all installed languages, not just enabled This patch changes the database update so that the system preference is copied to news items in all installed languages, not just those enabled in the OPAC. Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99367|0 |1 is obsolete| | --- Comment #59 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99495&action=edit Bug 22880: (QA follow-up) Fix "koha_news_block: not found" To make qa tools happy again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #60 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99496&action=edit Bug 22880: (QA follow-up) Remove opacheader from C4::Auth Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #61 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99497&action=edit Bug 22880: (QA follow-up) Pass lang instead of news_lang in masthead Might be a rebase problem. Not sure if I look at the third patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #62 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99498&action=edit Bug 22880: (QA follow-up) Replace use by require Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 [Bug 24746] Duplicate id in opacheader markup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #64 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26050 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 [Bug 26050] [OMNIBUS] Convert system preferences to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28650 [Bug 28650] Assumed branchcode variable appears to be empty -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org