[Bug 17055] New: Add classes to different note types to allow for styling on checkins page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055 Bug ID: 17055 Summary: Add classes to different note types to allow for styling on checkins page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Returned items may have 3 kinds of notes, patron, item public, and item non-public. However, the html markup for them does not allow us to distinguish which type we are seeing. It would be good to add classes for each of these note types. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 54046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54046&action=edit Bug 17055 - Add classes to different note types to allow for styling on checkins page Returned items may have 3 kinds of notes, patron, item public, and item non-public. However, the html markup for them does not allow us to distinguish which type we are seeing. It would be good to add classes for each of these note types. Test Plan: 1) Check out an item to a patron 2) Add a patron note, a public item note, and a non-public item note to the patron and item you used 3) Check in the item and instead the html, note the each note span now has a class to distinguish which type of note is being displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54046|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 54047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54047&action=edit [SIGNED-OFF] Bug 17055 - Add classes to different note types to allow for styling on checkins page Returned items may have 3 kinds of notes, patron, item public, and item non-public. However, the html markup for them does not allow us to distinguish which type we are seeing. It would be good to add classes for each of these note types. Test Plan: 1) Check out an item to a patron 2) Add a patron note, a public item note, and a non-public item note to the patron and item you used 3) Check in the item and instead the html, note the each note span now has a class to distinguish which type of note is being displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Current patch-complexity: Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54047|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 54108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54108&action=edit [PASSED QA] Bug 17055 - Add classes to different note types to allow for styling on checkins page Returned items may have 3 kinds of notes, patron, item public, and item non-public. However, the html markup for them does not allow us to distinguish which type we are seeing. It would be good to add classes for each of these note types. Test Plan: 1) Check out an item to a patron 2) Add a patron note, a public item note, and a non-public item note to the patron and item you used 3) Check in the item and instead the html, note the each note span now has a class to distinguish which type of note is being displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org