https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6892 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192923|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 193146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193146&action=edit Bug 6892: Fix links on MARCdetail.tt when protocol is missing This patch will check for URLs in MARC21 data and in case of a missing protocol prefix - either append a missing http prefix if tag=856 and indicator 1=4 is set, - or omit the html anchor element On other $u subfields (e.g. 505$u) the html anchor element is omitted when protocol is missing, regardless Test plan: a) edit a record set the following 856 fields: 1. 856 ind1=4 $u = bugs.koha-community.org 2. 856 $u = bugs.koha-community.org 3. 856 $u = https://bugs.koha-community.org 4. 505 $u = bugs.koha-community.org 5. 505 $u = https://bugs.koha-community.org b) save and go to records MARC view (MARCdetail.pl) and take a look at the links in tab 5 and 8 1. links to http://main-intra.localhost/cgi-bin/koha/catalogue/bugs.koha-community.org/ 2. links to http://main-intra.localhost/cgi-bin/koha/catalogue/bugs.koha-community.org/ 3. links to https://bugs.koha-community.org/ 4. links to http://main-intra.localhost/cgi-bin/koha/catalogue/bugs.koha-community.org 5. links to https://bugs.koha-community.org/ c) apply patch and reload MARCdetail.pl (maybe a restart_all is required) d) verify that 1. links to http://bugs.koha-community.org/ (because of indicator1=4) 2. bugs.koha-community.org/ is displayed but not inside an html anchor element 3. links https://bugs.koha-community.org/ 4. bugs.koha-community.org/ is displayed but not inside an html anchor element 5. links to https://bugs.koha-community.org/ Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.