[Bug 29693] New: CodeMirror broken on additional_contents.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Bug ID: 29693 Summary: CodeMirror broken on additional_contents.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: -Go to Tools and open either additional contents ( either News or HTML customization ) -Make sure you open it using CodeMirror and not TinyMCE -Code mirror is broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29113 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 [Bug 29113] New "code" field for additional contents is not useful for the end users -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 128513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128513&action=edit Bug 29693: Make CodeMirror work again To test: 1. Go to Tools > HTML customizations 2. Open or create a new entry with CodeMirror. ( Edit with text editor ) 3. CodeMirror doesn't work, you don't see line numbers or syntax highlighting 4. Apply patch 5. Try steps 1 & 2 again. The CodeMirror editor should now load. 6. Make sure it works in both the Default and English(en) tabs. 7. BONUS: install some other language packs and look at the tabs for that language, it should still work. 8. Try 5 and 6 again but with Additional contents (News) instead of HTML customizations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Initial step is: turn on UseWYSIWYGinSystemPreferences :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #2)
Initial step is: turn on UseWYSIWYGinSystemPreferences :)
Nope, it's AdditionalContentsEditor=text! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #3)
(In reply to Jonathan Druart from comment #2)
Initial step is: turn on UseWYSIWYGinSystemPreferences :)
Nope, it's AdditionalContentsEditor=text!
Well, it's second step. I totally forgot about that group button. The syspref does not make sense then. Sorry for the noise! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128513|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128540&action=edit Bug 29693: Make CodeMirror work again To test: 1. Go to Tools > HTML customizations 2. Open or create a new entry with CodeMirror. ( Edit with text editor ) 3. CodeMirror doesn't work, you don't see line numbers or syntax highlighting 4. Apply patch 5. Try steps 1 & 2 again. The CodeMirror editor should now load. 6. Make sure it works in both the Default and English(en) tabs. 7. BONUS: install some other language packs and look at the tabs for that language, it should still work. 8. Try 5 and 6 again but with Additional contents (News) instead of HTML customizations Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Trivial fix, skipping QA. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |andrew@bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org