https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #2 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 184563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184563&action=edit Bug 27248: Fix display of new due date column in preview table This patch removes a duplicate call to new_due_dates.shift so that the new due date column shows the date for all selected checkouts. To test: 1. Have some random checkouts 2. Use the batch_extend_due_dates tool with preview results checked 3. Notice only have the selected checkouts have data in the new due date column 4. Apply patch and retry seteps 2-3 5. All selected checkouts now show a date in the new due date column -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39665 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184563|0 |1 is obsolete| | --- Comment #5 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 185302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185302&action=edit Bug 27248: Fix display of new due date column in preview table This patch removes a duplicate call to new_due_dates.shift so that the new due date column shows the date for all selected checkouts. To test: 1. Have some random checkouts 2. Use the batch_extend_due_dates tool with preview results checked 3. Notice only have the selected checkouts have data in the new due date column 4. Apply patch and retry seteps 2-3 5. All selected checkouts now show a date in the new due date column Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #6 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- The barcode option worked as in test plan. I'd be happy to test and sign off the SQL report option too, because it would be a more versatile functionality. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #8 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for testing this Owen! (In reply to Owen Leonard from comment #7)

+ [% new_due_dates.size %]

Is this change a mistake? It's just a number floating in space.

This is indeed a stray tag from testing.

I think this needs some further refinement. I would expect that if I was pasting a batch of barcodes that none of the other filters would be relevant. I shouldn't be required to select a range of due dates unless the process was going to select only the barcodes in my batch which matched that due date range (which it does not).

The other filters still do work together with the barcode list. The logic is AND for all of them, so for example if you put in a barcode list and a due date from, it will only extend due dates for the barcodes where the current due date is after the due date from. The range of due dates filter is not required, but I can see how that's not entirely clear too. Only one of the New due date fields is actually required, you can leave the rest of the form blank and it will do all items. It also wasn't clear to me until I started testing that the Libraries filter is for the checkout branch. I could see a use case for adding the item owning library to this tool at some point too. For a consortium I think it makes sense to be able to use other filters in tandem with a barcode list as a way to further control and confirm that you are only extending due dates with specific criteria.

My first instinct is to say we should have a tabbed interface like we have with other batch operations: One tab with the original form with search criteria and another tab with the barcode input.

Since the barcodes work together with the other filters, I think a single form is more clear, but I will take a closer look at examples on other batch operation forms too.

I assume the bug should be retitled to drop the 'itemnumbers'?

I think barcodes is what librarians tend to work with more than the itemnumbers, so that's where I started with this. For the next step of integrating this into Report batch operations I don't think it matters much which one is used, but I'd be interested in any opinions on that matter too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185301|0 |1 is obsolete| | Attachment #185302|0 |1 is obsolete| | --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186205&action=edit Bug 27248: Add barcode list input to batch extend due dates This patch adds a barcode list input to batch extend due dates Test plan: 1. Have some checkouts and copy the barcodes 2. Go to Tools > Batch extend due dates 3. Paste the barcodes in the new input one line at a time 4. Confirm you can extend the due dates for those items 5. Confirm the other limits still work For example if you enter a branchcode and a list of barcodes only items that were checked out from that branchcode and are on the list of items get an updated due date Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #11 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186207&action=edit Bug 27248: Add batch extend due dates to report batch ops This patch adds a new batch operation for reports that return item numbers To test: 1. Apply patches and restart_all 2. Have some checkouts 3. Create a report that returns itemnumbers example: select * from issues 4. Run the report 6. In the Batch operations drop down menu under Item records see a new link for Batch extend due dates 7. Click Batch extend due dates 8. Confirm the tool loads with the item barcodes filled in the form -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #13 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for testing and feedback Katrin! I will work on a follow up asap. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186205|0 |1 is obsolete| | --- Comment #14 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 191499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191499&action=edit Bug 27248: Add barcode list input to batch extend due dates This patch adds a barcode list input to batch extend due dates Test plan: 1. Have some checkouts and copy the barcodes 2. Go to Tools > Batch extend due dates 3. Paste the barcodes in the new input one line at a time 4. Confirm you can extend the due dates for those items 5. Confirm the other limits still work For example if you enter a branchcode and a list of barcodes only items that were checked out from that branchcode and are on the list of items get an updated due date Sponsored-by: CLAMS Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186207|0 |1 is obsolete| | --- Comment #16 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 191501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191501&action=edit Bug 27248: Add batch extend due dates to report batch ops This patch adds a new batch operation for reports that return item numbers To test: 1. Apply patches and restart_all 2. Have some checkouts 3. Create a report that returns itemnumbers example: select * from issues 4. Run the report 6. In the Batch operations drop down menu under Item records see a new link for Batch extend due dates 7. Click Batch extend due dates 8. Confirm the tool loads with the item barcodes filled in the form -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #18 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for the code review Katrin! Adding the permission check for CAN_user_tools_batch_extend_due_dates reminds me that I should get back for bug 35905 too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191500|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 191653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191653&action=edit Bug 27248: Fix display of new due date column in preview table This patch removes a duplicate call to new_due_dates.shift so that the new due date column shows the date for all selected checkouts. To test: 1. Have some random checkouts 2. Use the batch_extend_due_dates tool with preview results checked 3. Notice only have the selected checkouts have data in the new due date column 4. Apply patch and retry seteps 2-3 5. All selected checkouts now show a date in the new due date column Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191502|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 191655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191655&action=edit Bug 27248: (follow-up) Add tt filter and permission check Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds adds a new input release notes| |to the Batch extend due | |dates tool for a list of | |item barcodes to further | |specify checkout criteria. | |It also adds a new batch | |operation available in | |reports that return item | |numbers that sends the | |items to the Batch extend | |due dates tool. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@gmail.com --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. Textarea contains some spaces, try using ~ instead of - for chomping - [%- FOREACH item IN items %] + [%~ FOREACH item IN items %] [%- item.barcode | html -%] - [% END -%] + [% END ~%] 2. If you select item type and barcode it won't work as expected, the `itemnumber` key of $search_params will be replaced: 82 $search_params->{'itemnumber'} = { -in => \@itemnumbers }; 104 $search_params->{'itemnumber'} = { -in => \@itemnumbers }; 3. - <td data-order="[% new_due_dates.shift | html %]"> [% new_due_dates.shift | $KohaDates as_due_date => 1 %] </td> + <td data-order="[% new_due_dates.0 | html %]"> [% new_due_dates.shift | $KohaDates as_due_date => 1 %] </td> Good catch. A bit confusing but it's working. It's a bug from bug 39081, we should have a dedicated bug report for backport purpose. Not blocker however. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #26 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 203806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203806&action=edit Bug 27248: (follow-up) Fix clobbering itemnumber param when using item type and barcode list If @itemtypecodes exists, add it to the search criteria along with the barcode list. This patch also fixes chomping in the barcodelist textarea. -- You are receiving this mail because: You are watching all bug changes.