[Bug 27248] New: Allow to use list of barcodes/itemnumbers with Batch extend due dates tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Bug ID: 27248 Summary: Allow to use list of barcodes/itemnumbers with Batch extend due dates tool Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org In some cases libraries want to use some more complicated criteria for selecting the items that they want to extend the due dates for. For these cases it would be great if SQL reports could be used to make a list that then can be uploaded to the tool, similar to how we manage other batch operations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 184562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184562&action=edit Bug 27248: Add barcode list input to batch extend due dates This patch adds a barcode list input to batch extend due dates Test plan: 1. Have some checkouts and copy the barcodes 2. Go to Tools > Batch extend due dates 3. Paste the barcodes in the new input one line at a time 4. Confirm you can extend the due dates for those items 5. Confirm the other limits still work For example if you enter a branchcode and a list of barcodes only items that were checked out from that branchcode and are on the list of items get an updated due date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #2 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 184563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184563&action=edit Bug 27248: Fix display of new due date column in preview table This patch removes a duplicate call to new_due_dates.shift so that the new due date column shows the date for all selected checkouts. To test: 1. Have some random checkouts 2. Use the batch_extend_due_dates tool with preview results checked 3. Notice only have the selected checkouts have data in the new due date column 4. Apply patch and retry seteps 2-3 5. All selected checkouts now show a date in the new due date column -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Batch extend due dates by item barcode was a feature in our previous ILS, so we sometimes still get requests to do this with a list of barcodes. This patch is a work in progress based on the batch item modification barcode list input. The next step would be to add it to the batch operations drop down list in SQL reports. Setting this to needs sign off to get some feedback. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39665 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184562|0 |1 is obsolete| | --- Comment #4 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 185301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185301&action=edit Bug 27248: Add barcode list input to batch extend due dates This patch adds a barcode list input to batch extend due dates Test plan: 1. Have some checkouts and copy the barcodes 2. Go to Tools > Batch extend due dates 3. Paste the barcodes in the new input one line at a time 4. Confirm you can extend the due dates for those items 5. Confirm the other limits still work For example if you enter a branchcode and a list of barcodes only items that were checked out from that branchcode and are on the list of items get an updated due date Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184563|0 |1 is obsolete| | --- Comment #5 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 185302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185302&action=edit Bug 27248: Fix display of new due date column in preview table This patch removes a duplicate call to new_due_dates.shift so that the new due date column shows the date for all selected checkouts. To test: 1. Have some random checkouts 2. Use the batch_extend_due_dates tool with preview results checked 3. Notice only have the selected checkouts have data in the new due date column 4. Apply patch and retry seteps 2-3 5. All selected checkouts now show a date in the new due date column Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |anneli.osterman@koha-suomi. | |fi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #6 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- The barcode option worked as in test plan. I'd be happy to test and sign off the SQL report option too, because it would be a more versatile functionality. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt @@ -170,6 +170,7 @@ + [% new_due_dates.size %] Is this change a mistake? It's just a number floating in space. I think this needs some further refinement. I would expect that if I was pasting a batch of barcodes that none of the other filters would be relevant. I shouldn't be required to select a range of due dates unless the process was going to select only the barcodes in my batch which matched that due date range (which it does not). My first instinct is to say we should have a tabbed interface like we have with other batch operations: One tab with the original form with search criteria and another tab with the barcode input. I assume the bug should be retitled to drop the 'itemnumbers'? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #8 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for testing this Owen! (In reply to Owen Leonard from comment #7)
+ [% new_due_dates.size %]
Is this change a mistake? It's just a number floating in space.
This is indeed a stray tag from testing.
I think this needs some further refinement. I would expect that if I was pasting a batch of barcodes that none of the other filters would be relevant. I shouldn't be required to select a range of due dates unless the process was going to select only the barcodes in my batch which matched that due date range (which it does not).
The other filters still do work together with the barcode list. The logic is AND for all of them, so for example if you put in a barcode list and a due date from, it will only extend due dates for the barcodes where the current due date is after the due date from. The range of due dates filter is not required, but I can see how that's not entirely clear too. Only one of the New due date fields is actually required, you can leave the rest of the form blank and it will do all items. It also wasn't clear to me until I started testing that the Libraries filter is for the checkout branch. I could see a use case for adding the item owning library to this tool at some point too. For a consortium I think it makes sense to be able to use other filters in tandem with a barcode list as a way to further control and confirm that you are only extending due dates with specific criteria.
My first instinct is to say we should have a tabbed interface like we have with other batch operations: One tab with the original form with search criteria and another tab with the barcode input.
Since the barcodes work together with the other filters, I think a single form is more clear, but I will take a closer look at examples on other batch operation forms too.
I assume the bug should be retitled to drop the 'itemnumbers'?
I think barcodes is what librarians tend to work with more than the itemnumbers, so that's where I started with this. For the next step of integrating this into Report batch operations I don't think it matters much which one is used, but I'd be interested in any opinions on that matter too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185301|0 |1 is obsolete| | Attachment #185302|0 |1 is obsolete| | --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186205&action=edit Bug 27248: Add barcode list input to batch extend due dates This patch adds a barcode list input to batch extend due dates Test plan: 1. Have some checkouts and copy the barcodes 2. Go to Tools > Batch extend due dates 3. Paste the barcodes in the new input one line at a time 4. Confirm you can extend the due dates for those items 5. Confirm the other limits still work For example if you enter a branchcode and a list of barcodes only items that were checked out from that branchcode and are on the list of items get an updated due date Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #10 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186206&action=edit Bug 27248: Fix display of new due date column in preview table This patch removes a duplicate call to new_due_dates.shift so that the new due date column shows the date for all selected checkouts. To test: 1. Have some random checkouts 2. Use the batch_extend_due_dates tool with preview results checked 3. Notice only have the selected checkouts have data in the new due date column 4. Apply patch and retry seteps 2-3 5. All selected checkouts now show a date in the new due date column Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #11 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186207&action=edit Bug 27248: Add batch extend due dates to report batch ops This patch adds a new batch operation for reports that return item numbers To test: 1. Apply patches and restart_all 2. Have some checkouts 3. Create a report that returns itemnumbers example: select * from issues 4. Run the report 6. In the Batch operations drop down menu under Item records see a new link for Batch extend due dates 7. Click Batch extend due dates 8. Confirm the tool loads with the item barcodes filled in the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Status|Needs Signoff |Failed QA Summary|Allow to use list of |Allow to use list of |barcodes/itemnumbers with |barcodes with batch extend |Batch extend due dates tool |due dates tool --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Testing here... and realizing that I have filed this bug in 2020 - thanks Brendan! Only found some quite small issues, ready to sign-off after a follow-up. 1) QA checks - failing (blocker) [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt FAIL filters missing_filter at line 131 ( [%- item.barcode -%]) 2) Code review a) Missing permission check (blocker) The option to send barcodes from reports to the batch due date tool, should only appear when the user has the batch_extend_due_dates permission. 3) Testing Tested according to test plan, works nicely! 3) Documentation I love the option to send a list of barcodes from reports. We should make sure this is reflected in the bug description or release notes. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #13 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for testing and feedback Katrin! I will work on a follow up asap. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186205|0 |1 is obsolete| | --- Comment #14 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 191499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191499&action=edit Bug 27248: Add barcode list input to batch extend due dates This patch adds a barcode list input to batch extend due dates Test plan: 1. Have some checkouts and copy the barcodes 2. Go to Tools > Batch extend due dates 3. Paste the barcodes in the new input one line at a time 4. Confirm you can extend the due dates for those items 5. Confirm the other limits still work For example if you enter a branchcode and a list of barcodes only items that were checked out from that branchcode and are on the list of items get an updated due date Sponsored-by: CLAMS Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186206|0 |1 is obsolete| | --- Comment #15 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 191500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191500&action=edit Bug 27248: Fix display of new due date column in preview table This patch removes a duplicate call to new_due_dates.shift so that the new due date column shows the date for all selected checkouts. To test: 1. Have some random checkouts 2. Use the batch_extend_due_dates tool with preview results checked 3. Notice only have the selected checkouts have data in the new due date column 4. Apply patch and retry seteps 2-3 5. All selected checkouts now show a date in the new due date column Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186207|0 |1 is obsolete| | --- Comment #16 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 191501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191501&action=edit Bug 27248: Add batch extend due dates to report batch ops This patch adds a new batch operation for reports that return item numbers To test: 1. Apply patches and restart_all 2. Have some checkouts 3. Create a report that returns itemnumbers example: select * from issues 4. Run the report 6. In the Batch operations drop down menu under Item records see a new link for Batch extend due dates 7. Click Batch extend due dates 8. Confirm the tool loads with the item barcodes filled in the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #17 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 191502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191502&action=edit Bug 27248: (follow-up) Add tt filter and permission check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #18 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for the code review Katrin! Adding the permission check for CAN_user_tools_batch_extend_due_dates reminds me that I should get back for bug 35905 too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Brendan Lawlor from comment #18)
Thanks for the code review Katrin!
Adding the permission check for CAN_user_tools_batch_extend_due_dates reminds me that I should get back for bug 35905 too.
Good idea ;)! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191499|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 191652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191652&action=edit Bug 27248: Add barcode list input to batch extend due dates This patch adds a barcode list input to batch extend due dates Test plan: 1. Have some checkouts and copy the barcodes 2. Go to Tools > Batch extend due dates 3. Paste the barcodes in the new input one line at a time 4. Confirm you can extend the due dates for those items 5. Confirm the other limits still work For example if you enter a branchcode and a list of barcodes only items that were checked out from that branchcode and are on the list of items get an updated due date Sponsored-by: CLAMS Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191500|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 191653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191653&action=edit Bug 27248: Fix display of new due date column in preview table This patch removes a duplicate call to new_due_dates.shift so that the new due date column shows the date for all selected checkouts. To test: 1. Have some random checkouts 2. Use the batch_extend_due_dates tool with preview results checked 3. Notice only have the selected checkouts have data in the new due date column 4. Apply patch and retry seteps 2-3 5. All selected checkouts now show a date in the new due date column Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191501|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 191654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191654&action=edit Bug 27248: Add batch extend due dates to report batch ops This patch adds a new batch operation for reports that return item numbers To test: 1. Apply patches and restart_all 2. Have some checkouts 3. Create a report that returns itemnumbers example: select * from issues 4. Run the report 6. In the Batch operations drop down menu under Item records see a new link for Batch extend due dates 7. Click Batch extend due dates 8. Confirm the tool loads with the item barcodes filled in the form Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191502|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 191655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191655&action=edit Bug 27248: (follow-up) Add tt filter and permission check Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Another round of testing: 1) QA checks - passing! 2) Code review - nothing more spotted! 3) Testing - still works nicely All previous comments have been addressed, signing off. Note: tidy doing some stranger things here, breaking up closing tags: + <textarea rows="10" cols="30" id="barcodelist" name="barcodelist"> + [%- FOREACH item IN items %] + [%- item.barcode | html -%] + [% END -%] + </textarea + > -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds adds a new input release notes| |to the Batch extend due | |dates tool for a list of | |item barcodes to further | |specify checkout criteria. | |It also adds a new batch | |operation available in | |reports that return item | |numbers that sends the | |items to the Batch extend | |due dates tool. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@gmail.com --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. Textarea contains some spaces, try using ~ instead of - for chomping - [%- FOREACH item IN items %] + [%~ FOREACH item IN items %] [%- item.barcode | html -%] - [% END -%] + [% END ~%] 2. If you select item type and barcode it won't work as expected, the `itemnumber` key of $search_params will be replaced: 82 $search_params->{'itemnumber'} = { -in => \@itemnumbers }; 104 $search_params->{'itemnumber'} = { -in => \@itemnumbers }; 3. - <td data-order="[% new_due_dates.shift | html %]"> [% new_due_dates.shift | $KohaDates as_due_date => 1 %] </td> + <td data-order="[% new_due_dates.0 | html %]"> [% new_due_dates.shift | $KohaDates as_due_date => 1 %] </td> Good catch. A bit confusing but it's working. It's a bug from bug 39081, we should have a dedicated bug report for backport purpose. Not blocker however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #26 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 203806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203806&action=edit Bug 27248: (follow-up) Fix clobbering itemnumber param when using item type and barcode list If @itemtypecodes exists, add it to the search criteria along with the barcode list. This patch also fixes chomping in the barcodelist textarea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |CLAMS list of Sponsors| | Sponsorship status|--- |Sponsored --- Comment #27 from Brendan Lawlor <blawlor@clamsnet.org> --- Rebased for main and added a follow up to display barcodes not found warning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191652|0 |1 is obsolete| | Attachment #191653|0 |1 is obsolete| | Attachment #191654|0 |1 is obsolete| | Attachment #191655|0 |1 is obsolete| | Attachment #203806|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #28 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 207635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207635&action=edit Bug 27248: Add barcode list input to batch extend due dates This patch adds a barcode list input to batch extend due dates Test plan: 1. Have some checkouts and copy the barcodes 2. Go to Tools > Batch extend due dates 3. Paste the barcodes in the new input one line at a time 4. Confirm you can extend the due dates for those items 5. Confirm the other limits still work For example if you enter a branchcode and a list of barcodes only items that were checked out from that branchcode and are on the list of items get an updated due date Sponsored-by: CLAMS Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #29 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 207636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207636&action=edit Bug 27248: Fix display of new due date column in preview table This patch removes a duplicate call to new_due_dates.shift so that the new due date column shows the date for all selected checkouts. To test: 1. Have some random checkouts 2. Use the batch_extend_due_dates tool with preview results checked 3. Notice only have the selected checkouts have data in the new due date column 4. Apply patch and retry seteps 2-3 5. All selected checkouts now show a date in the new due date column Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #30 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 207637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207637&action=edit Bug 27248: Add batch extend due dates to report batch ops This patch adds a new batch operation for reports that return item numbers To test: 1. Apply patches and restart_all 2. Have some checkouts 3. Create a report that returns itemnumbers example: select * from issues 4. Run the report 6. In the Batch operations drop down menu under Item records see a new link for Batch extend due dates 7. Click Batch extend due dates 8. Confirm the tool loads with the item barcodes filled in the form Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #31 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 207638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207638&action=edit Bug 27248: (follow-up) Add tt filter and permission check Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #32 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 207639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207639&action=edit Bug 27248: (follow-up) Fix clobbering itemnumber param when using item type and barcode list If @itemtypecodes exists, add it to the search criteria along with the barcode list. This patch also fixes chomping in the barcodelist textarea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #33 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 207640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207640&action=edit Bug 27248: (follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #34 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 207641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207641&action=edit Bug 27248: (follow-up) Show barcodes not found This patch passes @notfoundbarcodes to the template and displays a warning message to the user with the list of barcodes. Note: This includes barcodes that don't exist or barcodes that did not match the selected item types criteria. Items that are not checked out are not displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Brendan, sorrry to come back to this so late. Could you please rebase? Applying 7 patch(es): ✓ [1/7] Applied Bug 27248: Add barcode list input to batch extend due dates ✓ [2/7] Applied Bug 27248: Fix display of new due date column in preview table Patch application failed for attachment 207637 - Bug 27248: Add batch extend due dates to report batch ops Patches left in /tmp/bvliVOx0Fd for manual application if needed To resolve: 1. Fix conflicts (use 'git mergetool' or edit files manually) 2. Stage resolved files with 'git add' 3. Continue with 'git bz apply --continue' or 'git am --continue' 4. Or skip this patch with 'git bz apply --skip' 5. Or abort with 'git bz apply --abort' Error: Apply failed: Git command (git am -3 /tmp/bvliVOx0Fd/0003-207637.patch) failed: error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207635|0 |1 is obsolete| | Attachment #207636|0 |1 is obsolete| | Attachment #207637|0 |1 is obsolete| | Attachment #207638|0 |1 is obsolete| | Attachment #207639|0 |1 is obsolete| | Attachment #207640|0 |1 is obsolete| | Attachment #207641|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #36 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 210553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210553&action=edit Bug 27248: Add barcode list input to batch extend due dates This patch adds a barcode list input to batch extend due dates Test plan: 1. Have some checkouts and copy the barcodes 2. Go to Tools > Batch extend due dates 3. Paste the barcodes in the new input one line at a time 4. Confirm you can extend the due dates for those items 5. Confirm the other limits still work For example if you enter a branchcode and a list of barcodes only items that were checked out from that branchcode and are on the list of items get an updated due date Sponsored-by: CLAMS Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #37 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 210554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210554&action=edit Bug 27248: Fix display of new due date column in preview table This patch removes a duplicate call to new_due_dates.shift so that the new due date column shows the date for all selected checkouts. To test: 1. Have some random checkouts 2. Use the batch_extend_due_dates tool with preview results checked 3. Notice only have the selected checkouts have data in the new due date column 4. Apply patch and retry seteps 2-3 5. All selected checkouts now show a date in the new due date column Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #38 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 210555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210555&action=edit Bug 27248: Add batch extend due dates to report batch ops This patch adds a new batch operation for reports that return item numbers To test: 1. Apply patches and restart_all 2. Have some checkouts 3. Create a report that returns itemnumbers example: select * from issues 4. Run the report 6. In the Batch operations drop down menu under Item records see a new link for Batch extend due dates 7. Click Batch extend due dates 8. Confirm the tool loads with the item barcodes filled in the form Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #39 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 210556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210556&action=edit Bug 27248: (follow-up) Add tt filter and permission check Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #40 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 210557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210557&action=edit Bug 27248: (follow-up) Fix clobbering itemnumber param when using item type and barcode list If @itemtypecodes exists, add it to the search criteria along with the barcode list. This patch also fixes chomping in the barcodelist textarea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #41 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 210558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210558&action=edit Bug 27248: (follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #42 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 210559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210559&action=edit Bug 27248: (follow-up) Show barcodes not found This patch passes @notfoundbarcodes to the template and displays a warning message to the user with the list of barcodes. Note: This includes barcodes that don't exist or barcodes that did not match the selected item types criteria. Items that are not checked out are not displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #43 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for testing Katrin! I rebased this, mostly for changes to guided_reports_start.tt for bug 30557. I reattached the whole patch set just to avoid any chance of the sha1 error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #44 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Everything is lookingg good here except for one thing: 1. set BarcodeSeparators to '\n' 2. Make a few checkouts 3. Write a reportError, in KTD I just did "select * from issues" 4. Run report and do batch operation on visible results -> Batch extend due dates 5. Choose a "Hard due date" or do "Or add number of days" 6. I get something like: Warning, the following barcodes were not found or did not match the selected item types: Barcodes not found 39999000001457 39999000018998 The HTML for the text area is something like: <textarea rows="10" cols="30" id="barcodelist" name="barcodelist">39999000001457 39999000018998 </textarea> <li> <label for="barcodelist">Barcode list (one barcode per line): </label> <textarea rows="10" cols="30" id="barcodelist" name="barcodelist"></textarea> </li> it's not putting the barcodes on a seperate line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Goot catch, thanks Lucas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #46 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 210679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210679&action=edit Bug 27248: (QA follow-up) Chomp spaces and add explicit newline between barcodes When BarcodeSeparators did not include '\s' (e.g. only '\n'), barcodes passed from report batch operations were joined with spaces, instead of newlines that the tool requires. This patch explicitly separates barcodes with a newline and chomps all whitespace in the textarea. Test plan: 1. Set BarcodeSeparators to '\n' 2. Check out a few items 3. Create a report: SELECT * FROM issues 4. Run it, choose Batch operations -> Batch extend due dates 5. Confirm each barcode is on its own line in the barcode list 6. Set a hard due date or number of days and submit 7. Confirm no "Barcodes not found" warning and due dates are updated Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #47 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Sorry Brendan, Have 3 barcodes: 39999000019186 - this one is checked out 39999000019193 - this one is checked out 39999000019179 - this one is valid bu not checked out Run them through the tool. The 3rd barcode is silently dropped with no indication that is is not checked out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #48 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 210752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210752&action=edit Bug 27248: (QA follow-up) Warn and show barcodes not checked out Valid barcodes for items that were not checked out were silently dropped. This patch passes @notcheckedoutbarcodes to the template and displays a warning listing them, similar to the barcodes not found message. To test: 1. Paste a list of valid barcodes through the tool with some items checked out, some not checked out, and some invalid barcodes 2. Confirm warnings are displayed for Barcodes not found, and Barcodes not checked out Sponsored-by: CLAMS Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #210553|0 |1 is obsolete| | Attachment #210554|0 |1 is obsolete| | Attachment #210555|0 |1 is obsolete| | Attachment #210556|0 |1 is obsolete| | Attachment #210557|0 |1 is obsolete| | Attachment #210558|0 |1 is obsolete| | Attachment #210559|0 |1 is obsolete| | Attachment #210679|0 |1 is obsolete| | Attachment #210752|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #49 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 210753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210753&action=edit Bug 27248: Add barcode list input to batch extend due dates This patch adds a barcode list input to batch extend due dates Test plan: 1. Have some checkouts and copy the barcodes 2. Go to Tools > Batch extend due dates 3. Paste the barcodes in the new input one line at a time 4. Confirm you can extend the due dates for those items 5. Confirm the other limits still work For example if you enter a branchcode and a list of barcodes only items that were checked out from that branchcode and are on the list of items get an updated due date Sponsored-by: CLAMS Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #50 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 210754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210754&action=edit Bug 27248: Fix display of new due date column in preview table This patch removes a duplicate call to new_due_dates.shift so that the new due date column shows the date for all selected checkouts. To test: 1. Have some random checkouts 2. Use the batch_extend_due_dates tool with preview results checked 3. Notice only have the selected checkouts have data in the new due date column 4. Apply patch and retry seteps 2-3 5. All selected checkouts now show a date in the new due date column Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #51 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 210755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210755&action=edit Bug 27248: Add batch extend due dates to report batch ops This patch adds a new batch operation for reports that return item numbers To test: 1. Apply patches and restart_all 2. Have some checkouts 3. Create a report that returns itemnumbers example: select * from issues 4. Run the report 6. In the Batch operations drop down menu under Item records see a new link for Batch extend due dates 7. Click Batch extend due dates 8. Confirm the tool loads with the item barcodes filled in the form Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #52 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 210756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210756&action=edit Bug 27248: (follow-up) Add tt filter and permission check Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #53 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 210757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210757&action=edit Bug 27248: (follow-up) Fix clobbering itemnumber param when using item type and barcode list If @itemtypecodes exists, add it to the search criteria along with the barcode list. This patch also fixes chomping in the barcodelist textarea. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #54 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 210758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210758&action=edit Bug 27248: (follow-up) Tidy Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #55 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 210759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210759&action=edit Bug 27248: (follow-up) Show barcodes not found This patch passes @notfoundbarcodes to the template and displays a warning message to the user with the list of barcodes. Note: This includes barcodes that don't exist or barcodes that did not match the selected item types criteria. Items that are not checked out are not displayed. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #56 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 210760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210760&action=edit Bug 27248: (QA follow-up) Chomp spaces and add explicit newline between barcodes When BarcodeSeparators did not include '\s' (e.g. only '\n'), barcodes passed from report batch operations were joined with spaces, instead of newlines that the tool requires. This patch explicitly separates barcodes with a newline and chomps all whitespace in the textarea. Test plan: 1. Set BarcodeSeparators to '\n' 2. Check out a few items 3. Create a report: SELECT * FROM issues 4. Run it, choose Batch operations -> Batch extend due dates 5. Confirm each barcode is on its own line in the barcode list 6. Set a hard due date or number of days and submit 7. Confirm no "Barcodes not found" warning and due dates are updated Sponsored-by: CLAMS Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #57 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 210761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210761&action=edit Bug 27248: (QA follow-up) Warn and show barcodes not checked out Valid barcodes for items that were not checked out were silently dropped. This patch passes @notcheckedoutbarcodes to the template and displays a warning listing them, similar to the barcodes not found message. To test: 1. Paste a list of valid barcodes through the tool with some items checked out, some not checked out, and some invalid barcodes 2. Confirm warnings are displayed for Barcodes not found, and Barcodes not checked out Sponsored-by: CLAMS Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #58 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to Lucas Gass (lukeg) from comment #47)
Sorry Brendan,
Have 3 barcodes: 39999000019186 - this one is checked out 39999000019193 - this one is checked out 39999000019179 - this one is valid bu not checked out
Run them through the tool.
The 3rd barcode is silently dropped with no indication that is is not checked out
This is a good catch. Thanks for testing! The follow up patch covers items that are not checked out. One more note for a possible follow up bug: It's still possible for items to be silently dropped if they are checked out, but excluded by other criteria like the due date range, library or patron category, but that is how the tool currently works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #59 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 212012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=212012&action=edit Bug 27248: (RM follow-up) Treat a barcode list of "0" as a list, not as no list The barcode filter was applied under "if ($list)". Perl treats the string "0" as false, so a barcode list consisting of the single barcode "0" skipped the barcode filter altogether. The list operation then matched whatever the remaining filters selected, and without "Preview results" it extended the due date of every one of those checkouts, up to every checkout in the library system when no other filter was set. Apply the barcode filter whenever a barcode list was submitted, that is when the parameter is defined and not the empty string. An empty textarea still means "no barcode list", so the other filters keep working on their own, and a list holding only whitespace still matches no checkout. To test: 1. Go to Tools > Batch extend due dates 2. Enter 0 as the barcode list and "7" as the number of days. Uncheck "Preview results". Do not set any other filter => Before the patch: the due date of every checkout is extended => After the patch: no checkout is modified, and 0 is reported as a barcode that was not found 3. Leave the barcode list empty, enter a library and run again => The checkouts of that library are listed as before Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #60 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 212013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=212013&action=edit Bug 27248: (RM follow-up) Send only the visible rows to Batch extend due dates The report page rebuilds the hidden inputs of the batch operation forms from the rows currently shown in the results table, whenever the table is drawn, paged, resized or searched. This is what the "Batch operations with N visible records" count and the "Send visible ..." menu entries promise. The Batch extend due dates form was not part of that synchronisation, so it always carried every row of the report from when the page was rendered, whatever was shown in the table. Rebuild its itemnumber inputs together with those of the batch item modification and deletion forms. To test: 1. Create a report that returns itemnumbers and more rows than fit on one page of the results table, for example SELECT itemnumber FROM items 2. Run the report and click "Open in DataTables" in the toolbar 3. Choose Batch operations > Batch extend due dates => Before the patch: the barcode list holds the barcodes of all rows of the report, not only those on the page of the table => After the patch: the barcode list holds the barcodes of the rows on the current page of the table 4. Search the results table for part of a barcode, then choose Batch extend due dates again => The barcode list holds only the barcodes of the matching rows Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #61 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 212014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=212014&action=edit Bug 27248: (RM follow-up) Post the report itemnumbers as "itemnumber" The Batch extend due dates form on the report page named each hidden input after the report column it came from. A column is offered for the batch operations when it is called itemnumber, or when it was given an alias with the [[ table.field | alias ]] syntax of the report editor, which keeps the itemnumber type, as in SELECT [[items.itemnumber|Item]] FROM items For such an aliased column the input was named "Item". The tool only reads the itemnumber parameter, so the user reached an empty form with no message. The batch item modification and deletion forms already post the value as itemnumber. Use the name itemnumber, as those forms do. To test: 1. Create a report that gives its item column an alias, for example SELECT [[items.itemnumber|Item]] FROM items 2. Run it and choose Batch operations > Batch extend due dates => Before the patch: the barcode list is empty => After the patch: the barcode list holds the barcodes of the rows 3. Repeat with a report that selects the plain column itemnumber => The barcode list is filled as before Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main --- Comment #62 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Pushed to main for 26.11 with permission from Release Manager as RM assistant.. going through the last PQA from before the hard freeze -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |44159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44159 [Bug 44159] Batch extend due dates: checked out barcodes excluded by the other criteria are dropped without a message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |44160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44160 [Bug 44160] Batch extend due dates says due dates were modified when no checkout matched -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |44161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44161 [Bug 44161] Batch extend due dates: barcodes sent from a report are not recognised when BarcodeSeparators has no newline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |44162 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44162 [Bug 44162] Batch extend due dates: items without a barcode are lost when sent from a report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |44163 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44163 [Bug 44163] Batch extend due dates: barcode warnings list case duplicates and mention item types that were not selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds adds a new input |The Batch extend due dates release notes|to the Batch extend due |tool has a new input for a |dates tool for a list of |list of item barcodes, one |item barcodes to further |per line, to limit the |specify checkout criteria. |checkouts it extends. The |It also adds a new batch |other limits still apply. |operation available in |Barcodes that are not |reports that return item |found, or that are not |numbers that sends the |checked out, are listed in |items to the Batch extend |a warning. |due dates tool. | | |Reports that return item | |numbers also get a "Batch | |extend due dates" batch | |operation under Batch | |operations for item | |records. It opens the tool | |with the barcodes of the | |report rows filled in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|The Batch extend due dates |This adds adds a new input release notes|tool has a new input for a |to the Batch extend due |list of item barcodes, one |dates tool for a list of |per line, to limit the |item barcodes to further |checkouts it extends. The |specify checkout criteria. |other limits still apply. |It also adds a new batch |Barcodes that are not |operation available in |found, or that are not |reports that return item |checked out, are listed in |numbers that sends the |a warning. |items to the Batch extend | |due dates tool. |Reports that return item | |numbers also get a "Batch | |extend due dates" batch | |operation under Batch | |operations for item | |records. It opens the tool | |with the barcodes of the | |report rows filled in. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #63 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Hello, On 18 November I ran a bulk update of the "Text to go in release notes" field on bugs in the 26.11 range, to fill in missing notes using a consistent template. A mistake in that run also overwrote the release note you had written on this bug. That was not intended, and I am sorry for the noise. I have restored your original text from the bug history, so the field is exactly as you wrote it. Nothing else on this bug was changed. Thank you for writing the note. Martin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 --- Comment #64 from Brendan Lawlor <blawlor@clamsnet.org> --- lol, what if the automated release notes were an improvement on what I wrote? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org