[Bug 8567] New: Set output directory for fines.pl in cron config created by the packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Priority: P5 - low Change sponsored?: --- Bug ID: 8567 CC: robin@catalyst.net.nz Assignee: koha-bugs@lists.koha-community.org Summary: Set output directory for fines.pl in cron config created by the packages Severity: enhancement Classification: Unclassified OS: All Reporter: magnus@enger.priv.no Hardware: All Status: NEW Version: master Component: Packaging Product: Koha When the Debian packages are installed, they create a /etc/cron.daily/koha-common config based on the template in debian/koha-common.cron.daily. This results in the following command for fines.pl: koha-foreach --enabled /usr/share/koha/bin/cronjobs/fines.pl and this results in this script writing daily log files to /tmp, which is less than ideal. Now, fines.pl has an option --out to specify where the logs are saved, so we could change the cron config to something like this: koha-foreach --enabled /usr/share/koha/bin/cronjobs/fines.pl --out /var/log/koha/__instancename__ Caveat: This depends on Bug 8566 being implemented first! (Because without it there is no way for koha-foreach to use directories named after the instances.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8566 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Reed Wade <reed@typist.geek.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |reed@typist.geek.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 --- Comment #1 from Reed Wade <reed@typist.geek.nz> --- I think I just accidentally set this to Needs Signoff and can't figure out how to undo that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 --- Comment #2 from Reed Wade <reed@typist.geek.nz> --- Created attachment 29307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29307&action=edit patch with described change -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Reed Wade <reed@typist.geek.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Reed Wade <reed@typist.geek.nz> --- I don't have a good way to test this right now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29307|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 29308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29308&action=edit Bug 8567: Set output directory for fines.pl in cron config created by the packages Modified debian/koha-common.cron.daily adding instance output dir option to the fines.pl entry as described in the ticket. Requires patch from Bug 8566 which provides the __instancename__ feature for koha-foreach. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29308|0 |1 is obsolete| | --- Comment #5 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 29310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29310&action=edit Bug 8567: Set output directory for fines.pl in cron config created by the packages Modified debian/koha-common.cron.daily adding instance output dir option to the fines.pl entry as described in the ticket. Requires patch from Bug 8566 which provides the __instancename__ feature for koha-foreach. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Robin Sheat <robin@catalyst.net.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Reed! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I know I am a bit late to this, but fines.pl used to always output log files noone knew about, and then we changed it to be optional and driven by a parameter: bug 9656 I am not sure we should bring it back as default for package installations, that are used by a variety of users who will not be aware that patron sensitive data is stored in files somewhere on their servers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 --- Comment #8 from Robin Sheat <robin@catalyst.net.nz> --- That's a good point, I just remembered the logs in /tmp, I didn't realise they'd gone. The two resolutions would be to revert this, or to modify fines.pl so that just specifying --out doesn't cause logs to be written (i.e. it requires the --log option.) I'm not sure which is the most correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Robin, I am not sure either. Maybe it would be confusing, to have an --out set, but no files would be written. Also, this change could break logging for people who have currently activated it. Maybe we could undo the change? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org