[Bug 26431] New: Use split button to offer choice of WYSIWYG or code editor for news
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Bug ID: 26431 Summary: Use split button to offer choice of WYSIWYG or code editor for news Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 22660 Now that the news editor can use either TinyMCE or CodeMirror it should be possible to offer the option for the user to make that choice if they want to. I propose to change the news "Edit" button so that it defaults to the editor defined in the NewsToolEditor preference but has a menu with the choice of the other editor. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 109865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109865&action=edit Bug 26431: Use split button to offer choice of WYSIWYG or code editor for news This patch modifies the news interface so that the user is offered a choice of editing news items using the default editor as defined by the NewsToolEditor system preference or the non-default one. To test, apply the patch and go to Tools -> News. - In the list of news items you should see an "Edit" split button in each row. - Clicking the "Edit" part of the button should open the edit view with the correct editor as defined by the NewsToolEditor preference. - Clicking the menu arrow on the button should offer the other editing method: - If NewsToolEditor is set to "WYSIWYG," the menu should offer "text editor." - If NewsToolEditor is set to "text editor," the menu should offer "WYSIWYG editor." - Test the button with the NewsToolEditor preference set to both options and confirm that the button and menu work correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Sounds like a great idea! Will try to come back to this one... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109865|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 109950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109950&action=edit Bug 26431: Use split button to offer choice of WYSIWYG or code editor for news This patch modifies the news interface so that the user is offered a choice of editing news items using the default editor as defined by the NewsToolEditor system preference or the non-default one. To test, apply the patch and go to Tools -> News. - In the list of news items you should see an "Edit" split button in each row. - Clicking the "Edit" part of the button should open the edit view with the correct editor as defined by the NewsToolEditor preference. - Clicking the menu arrow on the button should offer the other editing method: - If NewsToolEditor is set to "WYSIWYG," the menu should offer "text editor." - If NewsToolEditor is set to "text editor," the menu should offer "WYSIWYG editor." - Test the button with the NewsToolEditor preference set to both options and confirm that the button and menu work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109980&action=edit Bug 26431: Update NewsToolEditor system preference description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109950|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109981&action=edit Bug 26431: Use split button to offer choice of WYSIWYG or code editor for news This patch modifies the news interface so that the user is offered a choice of editing news items using the default editor as defined by the NewsToolEditor system preference or the non-default one. To test, apply the patch and go to Tools -> News. - In the list of news items you should see an "Edit" split button in each row. - Clicking the "Edit" part of the button should open the edit view with the correct editor as defined by the NewsToolEditor preference. - Clicking the menu arrow on the button should offer the other editing method: - If NewsToolEditor is set to "WYSIWYG," the menu should offer "text editor." - If NewsToolEditor is set to "text editor," the menu should offer "WYSIWYG editor." - Test the button with the NewsToolEditor preference set to both options and confirm that the button and menu work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109980|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109982&action=edit Bug 26431: Update NewsToolEditor system preference description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Love this! Only one thing: I wondered if WYSIWYG is a term that is well known. Maybe we should make the choice HTML editor vs. Visual editor or similar? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #7)
Love this!
Only one thing: I wondered if WYSIWYG is a term that is well known. Maybe we should make the choice HTML editor vs. Visual editor or similar?
Mmm that's a really good point. While I know that I've used WYSIWYG in Koha in the past, I think it is an outdated term these days. I notice references to "rich-text editor" but I don't think people would get that either. So maybe "Visual editor"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- If you work with the HTML system preferences, which have moved to the News, this is very very handy. Choosing to backport to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Bug 26431 depends on bug 22660, which changed state. Bug 22660 Summary: Allow use of CodeMirror for editing HTML in the news editor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org