[Bug 18727] New: System preferences AcqItemSetSubfieldsWhen* loose part of values because of double quotes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Bug ID: 18727 Summary: System preferences AcqItemSetSubfieldsWhen* loose part of values because of double quotes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org The system preferences AcqItemSetSubfieldsWhenReceiptIsCancelled and AcqItemSetSubfieldsWhenReceived loose part of their values because of double quotes. To recreate: - Go to Home > Administration > System preferences , then tab Acquisitions - Enter values to both system preferences like proposed in the example (o=5|a="bar foo" and o=5|a="foo bar") - Save - Click on tab Acquisitions to reload - Result: Both preferences show a value of: o=5|a= (parts with double quotes are truncated) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18689 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9814 Summary|System preferences |System preferences loose |AcqItemSetSubfieldsWhen* |part of values because of |loose part of values |double quotes |because of double quotes | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- The problem occurs with all system preferences containing double quotes as values. The values are correct in the database but are truncated if edited again. Other example is Bug 9814 - KohaAdminEmailAddress syspref webpage field doesn't handle double quotes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 63956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63956&action=edit Bug 18727: System preferences loose part of values because of double quotes System preferences do not display values of text fields properly if they contain doulbe quotes. To recreate: - Go to Home > Administration > System preferences , then tab Acquisitions - Enter values to both system preferences like proposed in the example (o=5|a="bar foo" and o=5|a="foo bar") - Save - Click on tab Acquisitions to reload - Wrong result: Both preferences show a value of: o=5|a= (parts with double quotes are truncated) - Edit any of the email addresses (Bug 9814): KohaAdminEmailAddress, NoticeBcc, ReplytoDefault, PayPalUser - Set value to: "The Library" <thelibrary@example.com> - Search for this email address syspref to re-display it - Wrong result: Use [ ] " autocomplete="off" /> as the email address for the administrator of Koha. To test: - Apply patch - Try to recreate issues above - Additionally, edit other system preferences that could contain double quotes, e.g. LibraryName or UsageStatsLibraryName - Set value to: Bibliothek "Zur Leseratte" (Note: patch contains a tiny fix for a typo in acquisitions.pref) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Severity|normal |major --- Comment #3 from Marc Véron <veron@veron.ch> --- Setting to major because users can unintentionally change system preferences to mutilated values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matted-34813@mypacks.net --- Comment #4 from Marc Véron <veron@veron.ch> --- *** Bug 9814 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63956|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63958&action=edit [SIGNED-OFF] Bug 18727: System preferences loose part of values because of double quotes System preferences do not display values of text fields properly if they contain doulbe quotes. To recreate: - Go to Home > Administration > System preferences , then tab Acquisitions - Enter values to both system preferences like proposed in the example (o=5|a="bar foo" and o=5|a="foo bar") - Save - Click on tab Acquisitions to reload - Wrong result: Both preferences show a value of: o=5|a= (parts with double quotes are truncated) - Edit any of the email addresses (Bug 9814): KohaAdminEmailAddress, NoticeBcc, ReplytoDefault, PayPalUser - Set value to: "The Library" <thelibrary@example.com> - Search for this email address syspref to re-display it - Wrong result: Use [ ] " autocomplete="off" /> as the email address for the administrator of Koha. To test: - Apply patch - Try to recreate issues above - Additionally, edit other system preferences that could contain double quotes, e.g. LibraryName or UsageStatsLibraryName - Set value to: Bibliothek "Zur Leseratte" (Note: patch contains a tiny fix for a typo in acquisitions.pref) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63958|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64144&action=edit Bug 18727: System preferences loose part of values because of double quotes System preferences do not display values of text fields properly if they contain doulbe quotes. To recreate: - Go to Home > Administration > System preferences , then tab Acquisitions - Enter values to both system preferences like proposed in the example (o=5|a="bar foo" and o=5|a="foo bar") - Save - Click on tab Acquisitions to reload - Wrong result: Both preferences show a value of: o=5|a= (parts with double quotes are truncated) - Edit any of the email addresses (Bug 9814): KohaAdminEmailAddress, NoticeBcc, ReplytoDefault, PayPalUser - Set value to: "The Library" <thelibrary@example.com> - Search for this email address syspref to re-display it - Wrong result: Use [ ] " autocomplete="off" /> as the email address for the administrator of Koha. To test: - Apply patch - Try to recreate issues above - Additionally, edit other system preferences that could contain double quotes, e.g. LibraryName or UsageStatsLibraryName - Set value to: Bibliothek "Zur Leseratte" (Note: patch contains a tiny fix for a typo in acquisitions.pref) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Oldversions |--- -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org