[Bug 11522] New: self registration formatting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Bug ID: 11522 Summary: self registration formatting Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org Created attachment 24183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24183&action=edit "Required" text out of place. If you require a birth date in self registration, the red "Required" text appears below and to the left, instead of to the right of the required element. (see attachment) Looking in firebug, it appears there are empty paragraph marks. If these were to be removed, placement should be restored. (see attachment) Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 24184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24184&action=edit Out of place empty paragraph. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Flagged for Catalyst Academy, if worse comes to worse. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 --- Comment #3 from Francesca <francescalamoore@gmail.com> --- Created attachment 24324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24324&action=edit bug 11522 self-registration formating 1. in prog theme, enable opac self-registration and inspect clear date with firebug note that there are empty paragraph tags 2. add date of birth as a requirment in self-registration 3. apply patch 4. refresh page and notice that empty paragraph tags have been deleted, so that required lines up with clear date 5. repeat the above steps for bootstrap theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Francesca <francescalamoore@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |francescalamoore@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24324|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 24408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24408&action=edit Bug 11522 self-registration formating 1. in prog theme, enable opac self-registration and inspect clear date with firebug note that there are empty paragraph tags 2. add date of birth as a requirment in self-registration 3. apply patch 4. refresh page and notice that empty paragraph tags have been deleted, so that required lines up with clear date 5. repeat the above steps for bootstrap theme Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24408|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24414&action=edit Bug 11522 self-registration formating 1. in prog theme, enable opac self-registration and inspect clear date with firebug note that there are empty paragraph tags 2. add date of birth as a requirment in self-registration 3. apply patch 4. refresh page and notice that empty paragraph tags have been deleted, so that required lines up with clear date 5. repeat the above steps for bootstrap theme Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Simple patch. It works for prog and bootstrap. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Congratulations on having your first patch accepted into Koha, Francesca! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11522 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Patch pushed to 3.12.x, will be in 3.12.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org