[Bug 18675] New: Translatability: Get rid of [ %% in translation for csv-profiles.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Bug ID: 18675 Summary: Translatability: Get rid of [%% in translation for csv-profiles.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Translation tool for file csv-profiles.tt picks following line: %s [%% IF csv_profile.encoding == encoding OR NOT csv_profile AND encoding == 'utf8' %%] This is due to a line break inside a template directive. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 63732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63732&action=edit Bug 18675: Translatability: Get rid of [%% in translation for csv-profiles.tt Translation tool for file csv-profiles.tt picks following line: %s [%% IF csv_profile.encoding == encoding OR NOT csv_profile AND encoding == 'utf8' %%] It is is due to a line break inside a template directive. This patch removes it. To test: - Verify that code change makes sense - Apply patch - Verify that csv exports behave as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have added a check to our QA script: commit 594843834db69745d4bd0debc1dfb71433542500 TT tags should not be defined on several lines That breaks our translate script See bug 18675. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 --- Comment #3 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #2)
I have added a check to our QA script:
commit 594843834db69745d4bd0debc1dfb71433542500 TT tags should not be defined on several lines That breaks our translate script See bug 18675.
Great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18681 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63732|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63998&action=edit Bug 18675: Translatability: Get rid of [%% in translation for csv-profiles.tt Translation tool for file csv-profiles.tt picks following line: %s [%% IF csv_profile.encoding == encoding OR NOT csv_profile AND encoding == 'utf8' %%] It is is due to a line break inside a template directive. This patch removes it. To test: - Verify that code change makes sense - Apply patch - Verify that csv exports behave as before Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Do we really still need this.. adhering to it to keep the QA script happy leads to some horrifically unreadable code. Are we 100% sure this is still an issue and we've not managed to fix the translation scripts to work around this instead now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Martin Renvoize (ashimema) from comment #10)
Do we really still need this.. adhering to it to keep the QA script happy leads to some horrifically unreadable code.
Are we 100% sure this is still an issue and we've not managed to fix the translation scripts to work around this instead now?
-#: koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt:253 +#. %1$s: FOREACH encoding IN encodings +#: koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt:241 +#, c-format +msgid "%s [%% IF csv_profile.encoding == encoding OR NOT csv_profile AND encoding == 'utf8' %%] " +msgstr "" Still an issue. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org