[Bug 17642] New: Authorised values code is broken because of the refactoring
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Bug ID: 17642 Summary: Authorised values code is broken because of the refactoring Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> ---
From bug 17250 comment 16:
This code (C4/Items.pm, line 1378): # get notforloan complete status if applicable $av = Koha::AuthorisedValues->search_by_koha_field({ frameworkcode => $data->{frameworkcode}, kohafield => 'items.notforloan', authorised_value => $data->{itemnotforloan} }); $av = $av->count ? $av->next : undef; (and the next two similar statements below, for items.restricted and items.stack) doesn't work for me as expected. I'm testing on current master; same problem[s] on jessie and wheezy. If authorised value code in a given item record is undef|NULL or 0 (items.itemnotfoloan is most often 0, items.restricted is usually NULL - depends on the database contents), ->search_by_koha_field->count returns more then 1, and ->next returns some random (usually the 1st one in DB, but it's not guaranteed) AV record, eg. with result description being 'Ordered' for item.itemnoforloan = 0. If itemnoforloan in item record is not null and not zero, e.g. 1 or -1 (= item not for loan, item ordered), $av->count fails (it's not a fatal error) with the following warnings in the logs: DBD::mysql::st execute failed: Column 'authorised_value' in where clause is ambiguous [for Statement "SELECT COUNT( * ) FROM (SELECT `me`.`id`, `me`.`category`, `me`.`authorised_value`, `me`.`lib`, `me`.`lib_opac`, `me`.`imageurl` FROM `authorised_values` `me` JOIN `authorised_value_categories` `category` ON `category`.`category_name` = `me`.`category` LEFT JOIN `marc_subfield_structure` `marc_subfield_structures` ON `marc_subfield_structures`.`authorised_value` = `category`.`category_name` WHERE ( ( `authorised_value` = ? AND `marc_subfield_structures`.`frameworkcode` = ? AND `marc_subfield_structures`.`kohafield` = ? ) ) GROUP BY `me`.`id`, `me`.`category`, `me`.`authorised_value`, `me`.`lib`, `me`.`lib_opac`, `me`.`imageurl`) `me`" with ParamValues: 0=-1, 1='', 2='items.notforloan'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. No method count found for Koha::AuthorisedValues DBIx::Class::Storage::DBI::_dbh_execute(): Column 'authorised_value' in where clause is ambiguous at /home/koha/devkohaclone/Koha/Objects.pm line 307 and the result AV descriptions are empty strings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57533&action=edit Bug 17642: Try to fix AV code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com, | |kyle@bywatersolutions.com, | |tomascohen@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Josef, I have tried to fix the issue you raised on bug 17250. I have to run and I don't have time to polish this patch but, if you can, please try it and tell me if it fixes everything. We need to be very careful about these changes, that can easily introduce side effects. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17250 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It was not Josef, but Jacek, sorry guys :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57533|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57569&action=edit Bug 17642: Try to fix AV code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57570&action=edit Bug 17642: Add find_by_koha_field When we call search_by_koha_field with an authorised_value, we actually expect only 1 value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57571&action=edit Bug 17642: use find_by_koha_field when needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57572&action=edit Bug 17642: Add get_description_by_koha_field Most of the time we just need the descriptions (lib or opac_description), so let's add a new method for that and cache the descriptions in L1. Ideally we should cache it in L2 as well, but the AV code is not robust enough to allow that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57573&action=edit Bug 17642: use get_description_by_koha_field when needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57574&action=edit Bug 17642: Add and use get_descriptions_by_koha_field Ok I am silly, we needed to replace to use the cache mechanism for search_by_koha_field, not find_by_koha_field... Let's create another subroutine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- As describe by Jacek on bug 17250 comment 16, we have 2 major problems here: 1/ A critical one is that the feature is wrong and either explode or return bad result => Has to be fixed before the release. This *could* be fixed with only the first patch 2/ The search will take now more time than before the AV refactoring due to DBIx::Class calls (slower than DBI ofc). That *could* be fixed with the whole patch set. But as you can see, it's not trivial changes and if affects the code in a lot of places. I really need feedbacks quickly on this patch set to polish it to make it acceptable. I won't work on it before the release if we decide to delay its integration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #11)
As describe by Jacek on bug 17250 comment 16, we have 2 major problems here: 1/ A critical one is that the feature is wrong and either explode or return bad result => Has to be fixed before the release. This *could* be fixed with only the first patch 2/ The search will take now more time than before the AV refactoring due to DBIx::Class calls (slower than DBI ofc). That *could* be fixed with the whole patch set. But as you can see, it's not trivial changes and if affects the code in a lot of places.
I really need feedbacks quickly on this patch set to polish it to make it acceptable. I won't work on it before the release if we decide to delay its integration.
I like the concept you have here. I haven't had a chance to actually test it yet, but I think it's work proceeding! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57595&action=edit Bug 17642: Do not explode if no authorised value exist Can't call method "lib" on an undefined value at /home/vagrant/kohaclone/Koha/AuthorisedValues.pm line 137. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- t/db_dependent/AuthorisedValues.t: Would be nice if tests got a description Koha/AuthorizedValues.pm: No POD for methods; is there still any use for find_by_koha_field and search_by_koha_field? Squash these patches ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #14)
t/db_dependent/AuthorisedValues.t: Would be nice if tests got a description Koha/AuthorizedValues.pm: No POD for methods; is there still any use for find_by_koha_field and search_by_koha_field?
Squash these patches ?
No please don't squash. The 2 methods are still used from the get_description* methods. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #15)
The 2 methods are still used from the get_description* methods. OK I see
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Working on this one now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57616&action=edit Bug 17642: [QA Follow-up] Issues_stats.pl is not plack safe Resolve: Variable "$ccodes" is not available at reports/issues_stats.pl line 358. Variable "$locations" is not available at reports/issues_stats.pl line 359. Variable "$ccodes" is not available at reports/issues_stats.pl line 358. Variable "$locations" is not available at reports/issues_stats.pl line 359. Test plan: Run the script. Choose Collection or Shelving Location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Quick other benchmarks using time wget opac url (plack + memcached + 100 results displayed with default XSLT): prior to refactoring (430a641): 4.7-5.2s master: 8-10s master + 17642: 5-5.5s -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Timing XSLTParse4Display( 1, $record, 'OPACXSLTResultsDisplay', 1, 0 ); Commit 0faf643661f23eddd066488b26004428e57bfe18 master-koha@WRKM006:/usr/share/koha/masterclone$ perl zz 2>/dev/null 0.190 0.093 0.079 0.076 0.075 Previous commit plus 17642 patches master-koha@WRKM006:/usr/share/koha/masterclone$ perl zz 0.173 0.042 0.025 0.023 0.024 When you have sufficient hits and increase the number of results per page, you will gain more. In Firefox I am seeing 4,6-5,3s versus around 4,1 - 4,6s [new]. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57569|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57628&action=edit Bug 17642: Try to fix AV code Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57570|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57629&action=edit Bug 17642: Add find_by_koha_field When we call search_by_koha_field with an authorised_value, we actually expect only 1 value Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57571|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57630&action=edit Bug 17642: use find_by_koha_field when needed Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57572|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57631&action=edit Bug 17642: Add get_description_by_koha_field Most of the time we just need the descriptions (lib or opac_description), so let's add a new method for that and cache the descriptions in L1. Ideally we should cache it in L2 as well, but the AV code is not robust enough to allow that Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57573|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57632&action=edit Bug 17642: use get_description_by_koha_field when needed Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57574|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57633&action=edit Bug 17642: Add and use get_descriptions_by_koha_field Ok I am silly, we needed to replace to use the cache mechanism for search_by_koha_field, not find_by_koha_field... Let's create another subroutine Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57595|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57634&action=edit Bug 17642: Do not explode if no authorised value exist Can't call method "lib" on an undefined value at /home/vagrant/kohaclone/Koha/AuthorisedValues.pm line 137. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57616|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57635&action=edit Bug 17642: [QA Follow-up] Issues_stats.pl is not plack safe Resolve: Variable "$ccodes" is not available at reports/issues_stats.pl line 358. Variable "$locations" is not available at reports/issues_stats.pl line 359. Variable "$ccodes" is not available at reports/issues_stats.pl line 358. Variable "$locations" is not available at reports/issues_stats.pl line 359. Test plan: Run the script. Choose Collection or Shelving Location. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Looks good to me: bug fixed, performance seems okay. Another signoff or additional QA signoff is welcome. But in case these are not available, I would be happy to promote this to PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I dug through this code a little over the past few days too and my gut feeling was that it seemed a step in the right direction and safe. I hadn't signed off/qa'd though as I felt I wasn't in a position in koha recently to fully anticipate any possible fallout in this particular area of the codebase. It looks like you've done a thorough job of testing and performance checking from here Marcel so you'd have my +1 for PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Asked Martin to add a signoff. He also did limited testing and looked at the code. That makes my signoff be the QA pass. (Note earlier comments about 'polishing', POD/test descriptions etc.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57628|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 57650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57650&action=edit Bug 17642: Try to fix AV code Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57629|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 57651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57651&action=edit Bug 17642: Add find_by_koha_field When we call search_by_koha_field with an authorised_value, we actually expect only 1 value Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57630|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 57652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57652&action=edit Bug 17642: use find_by_koha_field when needed Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57631|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 57653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57653&action=edit Bug 17642: Add get_description_by_koha_field Most of the time we just need the descriptions (lib or opac_description), so let's add a new method for that and cache the descriptions in L1. Ideally we should cache it in L2 as well, but the AV code is not robust enough to allow that Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57632|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 57654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57654&action=edit Bug 17642: use get_description_by_koha_field when needed Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57633|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 57655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57655&action=edit Bug 17642: Add and use get_descriptions_by_koha_field Ok I am silly, we needed to replace to use the cache mechanism for search_by_koha_field, not find_by_koha_field... Let's create another subroutine Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57634|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 57656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57656&action=edit Bug 17642: Do not explode if no authorised value exist Can't call method "lib" on an undefined value at /home/vagrant/kohaclone/Koha/AuthorisedValues.pm line 137. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57635|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 57657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57657&action=edit Bug 17642: [QA Follow-up] Issues_stats.pl is not plack safe Resolve: Variable "$ccodes" is not available at reports/issues_stats.pl line 358. Variable "$locations" is not available at reports/issues_stats.pl line 359. Variable "$ccodes" is not available at reports/issues_stats.pl line 358. Variable "$locations" is not available at reports/issues_stats.pl line 359. Test plan: Run the script. Choose Collection or Shelving Location. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just adding in the signoff line to verify that indeed I did test and was happy in the signoff capacity.. Thanks for QAing Marcel :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #42 from Mason James <mtj@kohaaloha.com> --- (In reply to Kyle M Hall from comment #41)
Pushed to master for 16.11, thanks Jonathan, Marcel!
hmm, this patch seems to depend on a not-yet-pushed patch (15799) is that ok? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Mason James from comment #42)
(In reply to Kyle M Hall from comment #41)
Pushed to master for 16.11, thanks Jonathan, Marcel!
hmm, this patch seems to depend on a not-yet-pushed patch (15799) is that ok?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799
Yes, bug 15799 is an omnibus. But you do not need it for 16.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435 [Bug 18435] Language entered in Materials Specified does not display when items are checked out and checked in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17642 Bug 17642 depends on bug 15799, which changed state. Bug 15799 Summary: Move authorised values related code into Koha::AuthorisedValues - part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org