https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42433 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I can confirm the behavour you described. Instead of going into the developer tools, I logged out and then logged back in - the changes made in the table administration were then shown (that is, the column you asked to be hidden by default is now hidden). (In reply to Caroline Cyr La Rose from comment #1)

I feel like this is a lot of steps to remove a column and not really manageable by all library staff. Is this the normal behaviour of the save state thing? (I admit I don't understand the purpose of the save state option... :/ )

I'm always confused by these options - I don't really know what they mean, and feel like they are written in developer speak: - Save configuration state on page change - Save search state on page change I'd be happy to attempt a rewrite, if someone could explain what they are supposed to do. So for "Save configuration state on page change" selected: - make changes to the table columns (using the "Columns" dropdown list when you are on the page with the table) - go somewhere else then go back to the table ==> the column changes you made are remembered - if you log out then log back in: ==> the changes you made aren't remembered (things are set back to the default in the table settings) With it not selected, if you go away and then go back to the table later on in the same session, any column changes aren't remembered. I don't have any idea what the "Save search state on page change" means (it is also not an option available for all tables). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42433 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42433 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- What is described in comment 0 is the expected behaviour. If you have opened the page and that a localStorage entry exists then what is saved in the admin page (and so what is in the DB, table columns_settings) won't be taken into account. I can try to explain the differences between the two options and how they work. They both use the same DataTables feature stateSave (https://datatables.net/reference/option/stateSave). When we display a table we are going to try to restore the "state" of the table: from the url (if we opened the page using the "copy shareable link" button), or from the data stored in localStorage (the `DataTables_${table_id}` entries). If none exists we load the default from the config: what is in the DB, and defaulting on what is in the YML file (admin/columns_settings.yml). "Save configuration state on page change" => save in localStorage the visibility of the columns, the sort order, the page length. Note that the page number will no longer be saved when bug 41992 (currently PQA) will be pushed. "Save search state on page change" => Save the search terms (global and column filtering) If we loaded the state from the localStorage, bugs might exist :D And this is what we (are trying to) fix on bug 42332. Basically the problem is that we should always have the same number of columns when we build the table then hide them using JS (DataTables). Currently we add some columns to the DOM depending on syspref/permissions, then save the state. If the conditions are modified, DT will fail to restore the state because the number of columns in the DOM is different than the number of columns in the state stored in localStorage. Please tell me if it's not clear enough, I will be happy to clarify more if needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42433 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Caroline Cyr La Rose from comment #6)

Is it normal that Ctrl + F5 doesn't clear the saved state?

Yes! localStorage persists across the session. The idea is to let the user decides to hide columns they don't want to see, and keep them hidden next time they see the table. You have to logout to remove localStorage entries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.