http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12790 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5599 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12790 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12790 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12790 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Hi Marc, The patch applies. But imo the display does not improve with this patch. This may be an arbitrary design issue... But could you display it somewhat differently? Less confusing? BTW Is it really necessary to show the required version if you have an installed version that is equal or higher? Hope that you could find a way to improve the display. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12790 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 31347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31347&action=edit Bug 12790 - Perl modules: Display required version numbers on about page This patch adds information about required perl module versions to the 'About' page. To test: Apply patch In staff client, go to 'About', tab 'Perl modules' The required version numbers should display in small print underneath the module names. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Needs new Sign-off (code changed) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12790 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31347|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 31348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31348&action=edit Bug 12790 - Perl modules: Display required version numbers on about page This patch adds information about required perl module versions to the 'About' page. To test: Apply patch In staff client, go to 'About', tab 'Perl modules' The required version numbers should display in small print underneath the module names. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Needs new Sign-off (code changed) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12790 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12790 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 31360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31360&action=edit Bug 12790 - Perl modules: Display required version numbers on about page This patch adds information about required perl module versions to the 'About' page. To test: Apply patch. In staff client, go to 'About', tab 'Perl modules' The required version numbers should display in small print next to or underneath the module names. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12790 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Since the code change is minimal, the signoff of Nick still holds. I saw the About page on a wider screen now, and it looks good. If you make the window smaller, it still does not look nice. Looking at the template code (not your added lines only), it seems that this could be simplified. For instance, a check on the module name does not really make sense. If there is no module name, there should be no row. Furthermore, the template contains several style attrs which probably should be moved to css. Imo the display still needs improvement for a smaller screen, but I will not block this patch for that reason. Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12790 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Marc! Note: i belive the layout should be made cleaner to read, but am happy someone is taking care of end-users :-D -- You are receiving this mail because: You are watching all bug changes.