[Bug 16361] New: Installer syntax error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 Bug ID: 16361 Summary: Installer syntax error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt@gmail.com Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org This patch http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=installer/data... seems to cause: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'ALTER TABLE edifact_messages ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 50779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50779&action=edit Bug 16361: Installer syntax error Bug 16354 introduces a syntax error on updatedatabase.pl see comment #5 there To test 1) Check error on update 3.23.00.051 2) Apply the patch 3) run updatedabase again (perhaps changing 051 to XXX) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 50780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50780&action=edit Bug 16361 - syntax error in updatedatabase To test: Set version below 3.23.00.051 (if necessary - you can do this in the localuse preferences in the intranet) Run the updatedatabase in your favourite way There should be no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50780|0 |1 is obsolete| | --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- Comment on attachment 50780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50780 Bug 16361 - syntax error in updatedatabase You beat me :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50779|0 |1 is obsolete| | --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 50782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50782&action=edit Bug 16361: Installer syntax error Bug 16354 introduces a syntax error on updatedatabase.pl see comment #5 there To test 1) Check error on update 3.23.00.051 2) Apply the patch 3) run updatedabase again (perhaps changing 051 to XXX) Signed-off-by: Liz Rea <liz@catalyst.net.nz> happy again! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Liz Rea from comment #3)
You beat me :)
Yours was prettier :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 --- Comment #6 from Liz Rea <liz@catalyst.net.nz> --- awww, hugs all around. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4e6baf61858b... With this patch we don't get this message, caused by the above patch: [Wed Apr 27 14:50:11 2016] updatedatabase.pl: Not a CODE reference at /home/liz/koha-src/koha/installer/data/mysql/updatedatabase.pl line 12355. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Liz Rea from comment #7)
http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff; h=4e6baf61858bd22d91d50ad5f176f04242a23370
With this patch we don't get this message, caused by the above patch:
[Wed Apr 27 14:50:11 2016] updatedatabase.pl: Not a CODE reference at /home/liz/koha-src/koha/installer/data/mysql/updatedatabase.pl line 12355.
Brendan beat us two, and it's pushed :) Resolved -> Fixed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 --- Comment #9 from Liz Rea <liz@catalyst.net.nz> --- Nope, his one is still broken. :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Liz Rea from comment #9)
Nope, his one is still broken. :(
Yeap, a missing 'do' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50782|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50786&action=edit [PASSED QA] Bug 16361: Installer syntax error Bug 16354 introduces a syntax error on updatedatabase.pl see comment #5 there To test 1) Check error on update 3.23.00.051 2) Apply the patch 3) run updatedabase again (perhaps changing 051 to XXX) Signed-off-by: Liz Rea <liz@catalyst.net.nz> happy again! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Brendan, we are still missing a 'do' in the last updatedatabase entry: -$dbh->(q{ +$dbh->do(q{ I have passed the patch here - so you can either fix it directly or revert the last commit and use this patch here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16361 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |julian.maurice@biblibre.com --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org