[Bug 42349] New: Incorrect filter by recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 Bug ID: 42349 Summary: Incorrect filter by recalls Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 37334 On the holdings table the filter by status=recalls is not working correctly. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 [Bug 37334] Cannot filter holdings table by status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38122 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197192&action=edit Bug 42349: Fix filtering items by recalls On the holdings table the filter by status=recalls is not working correctly. Test plan: Add a recall on an item of a bibliographic record that has several items. Filter the items table by status=recall => Without this patch all items are displayed => With this patch applied only the item with a recall is displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197251&action=edit Bug 42349: Adjust tests Patch from commit f024b06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197192|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197251|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 197720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197720&action=edit Bug 42349: Fix filtering items by recalls On the holdings table the filter by status=recalls is not working correctly. Test plan: Add a recall on an item of a bibliographic record that has several items. Filter the items table by status=recall => Without this patch all items are displayed => With this patch applied only the item with a recall is displayed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 197721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197721&action=edit Bug 42349: Adjust tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the holdings release notes| |table on the record details | |page. The status column | |filter now works correctly | |when selecting the | |"Recalled" option, and | |lists recalls placed for a | |specific item. | | | |Previously, the "Recalled" | |filter did not work and all | |items for the record were | |listed instead. --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Set the UseRecalls system preference to 'to Use'. 2. Update the All All circulation rule with recall settings: - Recalls allowed (total): 5 - Recalls per record (count): 5 - On shelf recalls allowed: If any unavailable - Recall due date interval (day): 5 - Recall overdue fine amount: 5 - Recall pickup period (day): 5 3. Checkout an item to the koha patron. (I used: Intermediate Perl (biblionumber = 126, item = 39999000005134)) 4. Edit a patron so you can log in as them (I used Mary Burton, and changed the password). 5. Log into the OPAC as the patron. 6. Place a recall on the item you checked out (use the "Recall a specific item" option, and select the item checked out). 7. On the holdings table for the record in the staff interface, the status column for the item should show something similar to Checked out to koha (42): due 04/22/2026 Recalled by Mary Burton (23529000651225) on 04/17/2026 8. Click the "Show filters" link. 9. In the dropdown list for the status column, select "Recalled". 10. Result = All items are shown, not just the item that has had a recall placed. 11. Apply the patch. 12. Restart everything: restart_all 13. Refresh the record details page. 14. Click the "Show filters" link. 15. In the dropdown list for the status column, select "Recalled". 16. Result = Only the item that the recall was placed on is listed. 17. Tests pass: prove t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197720|0 |1 is obsolete| | Attachment #197721|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 201894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201894&action=edit Bug 42349: Fix filtering items by recalls On the holdings table the filter by status=recalls is not working correctly. Test plan: Add a recall on an item of a bibliographic record that has several items. Filter the items table by status=recall => Without this patch all items are displayed => With this patch applied only the item with a recall is displayed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42349 --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 201895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201895&action=edit Bug 42349: Adjust tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org