[Bug 11801] New: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Bug ID: 11801 Summary: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25507&action=edit Pre-patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25508&action=edit Post-patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25509&action=edit Bug 11801 - In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. Test Plan: 1) Place a hold for pickup at another library 2) Check in the item, confirm the hold transfer 3) View the holds for that record ( request.pl ) 4) Note the priority is "In transit" and the status is 'Waiting to be pulled". 5) Apply this patch 6) Reload the holds page 7) Note the status is now "Item being transferred to $branch" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|In transit hold items |In transit hold items |incorrectly labels as |incorrectly labeled as |"Waiting to be pulled" on |"Waiting to be pulled" on |request.pl |request.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 michot <nmichot@voila.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nmichot@voila.fr --- Comment #4 from michot <nmichot@voila.fr> --- test done on sandbox today : 1) Place a hold for pickup at another library 2) Check in the item, confirm the hold transfer 3) View the holds for that record ( request.pl ) Before applying patch, message on "request.pl = wainting to be pulled After applying patch, message on "request.pl = Item being transferred to XXX So it seems OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Nadine Michot <nmichot@voila.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25509|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26086&action=edit Bug 11801 - In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. Test Plan: 1) Place a hold for pickup at another library 2) Check in the item, confirm the hold transfer 3) View the holds for that record ( request.pl ) 4) Note the priority is "In transit" and the status is 'Waiting to be pulled". 5) Apply this patch 6) Reload the holds page 7) Note the status is now "Item being transferred to $branch" Signed-off-by: Nadine Michot <nmichot@voila.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Since I disagree with the idea to call Koha::Database directly from pl scripts, I disagree with this patch :) Moreover, in my opinion it is useless to get the transfer using DBIC, we have a C4::Circulation::GetTransfers routine. The patch works as expected :) Galen and/or others QAers, could you please take a position on that? I will provide a counter patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26481&action=edit Bug 11801: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. Test Plan: 1) Place a hold for pickup at another library 2) Check in the item, confirm the hold transfer 3) View the holds for that record ( request.pl ) 4) Note the priority is "In transit" and the status is 'Waiting to be pulled". 5) Apply this patch 6) Reload the holds page 7) Note the status is now "Item being transferred to $branch" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26086|Bug 11801 - In transit hold |DBIC version - Bug 11801 - description|items incorrectly labels as |In transit hold items |"Waiting to be pulled" on |incorrectly labels as |request.pl |"Waiting to be pulled" on | |request.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m, | |katrin.fischer@bsz-bw.de, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, | |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Jonathan Druart from comment #7)
Since I disagree with the idea to call Koha::Database directly from pl scripts, I disagree with this patch :) Moreover, in my opinion it is useless to get the transfer using DBIC, we have a C4::Circulation::GetTransfers routine.
The patch works as expected :)
Galen and/or others QAers, could you please take a position on that?
I have no problem invoking Koha::Database directly from scripts. Not every bit of database access needs to be wrapped in middleware. However, I will say that if I were doing it via DBIC, I would probably add an at_destination method to the Koha::Schema::Result::Reserves class. That said, I have a stronger aversion to having multiple ways of asking the same question. GetTransfers() gets the job done. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26086|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26481|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28664&action=edit Bug 11801: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. Test Plan: 1) Place a hold for pickup at another library 2) Check in the item, confirm the hold transfer 3) View the holds for that record ( request.pl ) 4) Note the priority is "In transit" and the status is 'Waiting to be pulled". 5) Apply this patch 6) Reload the holds page 7) Note the status is now "Item being transferred to $branch" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28664|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 28670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28670&action=edit [PASSED QA] Bug 11801: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. Test Plan: 1) Place a hold for pickup at another library 2) Check in the item, confirm the hold transfer 3) View the holds for that record ( request.pl ) 4) Note the priority is "In transit" and the status is 'Waiting to be pulled". 5) Apply this patch 6) Reload the holds page 7) Note the status is now "Item being transferred to $branch" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as advertised and passes qa scripts. I'm also happier with the alternative patch using existent routines. I'm an advocate of dbic, but in this case I think as galen rightly states we should all have an aversion to having multiple ways of asking the same question. Nice work guys -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. I also prefer using GetTransfers. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.1. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org