[Bug 23463] New: Move C4::Items CRUD subroutines to Koha::Item

bugzilla-daemon＠bugs.koha-community.org

14 Aug 2019 14 Aug '19

5:32 p.m.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Bug ID: 23463 Summary: Move C4::Items CRUD subroutines to Koha::Item Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

Show replies by date

bugzilla-daemon＠bugs.koha-community.org

14 Aug 14 Aug

6:06 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This patchset will be quite big and will move the following C4::Items subroutines to the Koha namespace: AddItem ModItem DelItem ItemSafeToDelete DelItemCheck SearchItemsByField UpdateHoldingbranch _koha_new_item _koha_modify_item _set_defaults_for_add _set_derived_columns_for_add _do_column_fixes_for_mod _set_derived_columns_for_mod _build_default_values_for_mod_marc _get_single_item_column _calc_items_cn_sort _mod_item_dates _after_item_action_hooks -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:07 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

bugzilla-daemon＠bugs.koha-community.org

6:09 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

24 Oct 24 Oct

5:57 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Remote branch has been rebased. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1 Nov 1 Nov

1:04 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:04 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Lets hit this one hard beginning of next cycle :) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 Dec 2 Dec

11:20 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

1:04 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95908&action=edit Bug 23463: Move plugin hook

...

From C4::Items to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 95922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95922 Bug 23463: build cn_sort only if needed Review of attachment 95922: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23463&attachment=95922) ----------------------------------------------------------------- ::: Koha/Item.pm @@ +74,5 @@

...

$self->itype($self->biblio->biblioitem->itemtype); }

+ my %updated_columns = $self->_result->get_dirty_columns; + if ( exists $updated_columns{itemcallnumber} ) {

We should also update the cn_sort if cn_source was changed. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:32 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95925&action=edit Bug 23463: cn_sort needs to be updated if cn_source changed -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:32 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #30)

...

Comment on attachment 95922 [details] [review] Bug 23463: build cn_sort only if needed

Review of attachment 95922 [details] [review]: -----------------------------------------------------------------

::: Koha/Item.pm @@ +74,5 @@

...
$self->itype($self->biblio->biblioitem->itemtype); }

+ my %updated_columns = $self->_result->get_dirty_columns; + if ( exists $updated_columns{itemcallnumber} ) {

We should also update the cn_sort if cn_source was changed.

Indeed, thanks! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3 Dec 3 Dec

11:13 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8132 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 [Bug 8132] Batch delete tool deletes items with holds on them -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10 Dec 10 Dec

12:58 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96145&action=edit Bug 23463: (follow-up) Remove DelItemCheck and ItemSafeToDelete Wrong replacement in additem.pl -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

13 Dec 13 Dec

10:38 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is on my list for early January -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

24 Jan 24 Jan

8:45 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #45 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 97904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97904&action=edit Bug 23463: Move plugin hook

...

From C4::Items to Koha::Item

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:51 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #64 from Tomás Cohen Arazi <tomascohen@gmail.com> --- About the timestamp handling: shouldn't we better implement Koha::Object->set_and_store of similar, that instead of overwriting the whole object, just sets the really changed fields, and we leave the DB do the heavy lifting? It looks wrong (as you also say, Jonathan) to be setting the timestamp manually on the ->store method (be it in the Koha::Item class, or as a generic approach in Koha::Object) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

28 Jan 28 Jan

1:01 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #64)

...

About the timestamp handling: shouldn't we better implement Koha::Object->set_and_store of similar, that instead of overwriting the whole object, just sets the really changed fields, and we leave the DB do the heavy lifting? It looks wrong (as you also say, Jonathan) to be setting the timestamp manually on the ->store method (be it in the Koha::Item class, or as a generic approach in Koha::Object)

I have added a follow-up to the branch. Still not optimal however. I am on a "less regressions as possible" approach here. We will certainly want/need to improve later. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Feb 6 Feb

8:14 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #66 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I tested this branch (which Jonathan rebased against master) and: - Some tests were failing due to old and new rebase issues: fixed! - Some typos in controllers and libs: fixed! I'm not 100% comfortable with the legacy approaches to avoid regressions, but I AGREE they are better than breaking things in large scale. This way we can start writing the API for items in a way that we are sure will preserve behaviour, one page at a time, so all good! I tested: STAFF - Search results - Detail view - Edit/add/delete items - Circulation, placing holds - Course reserves - Acquisition workflows - Batch item modification - Batch item deletion OPAC - Course reserves - Search results, detail view - Reading history - Shelf browser I'm confident about this patchset at this stage. Jonathan: please add my signature to your branch's commits. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11 Feb 11 Feb

10:24 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

...

Jonathan: please add my signature to your branch's commits.

Done, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

13 Feb 13 Feb

4:15 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4 Mar 4 Mar

5:42 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #68 from Nick Clemens <nick@bywatersolutions.com> --- Testing btoh with mariadb_d9 and mariadb_d10 I was unable to blank any fields in items, either individually or via batch edit - things like 'onloan' and 'itemlost_on' are successfully nulled as they should be. Two test failures: # Failed test 'Syntax check misc/migration_tools/fix_onloan.pl' # at /usr/share/perl5/Test/Strict.pm line 423. # Unmatched right curly bracket at misc/migration_tools/fix_onloan.pl line 20, at end of line # syntax error at misc/migration_tools/fix_onloan.pl line 20, near "}" # misc/migration_tools/fix_onloan.pl had compilation errors. # Looks like you failed 1 test of 706. # Failed test 'reference if positive itemtype notforloan value' # at t/db_dependent/XSLT.t line 57. # '<items xmlns="http://www.koha-community.org/items"><item><homebranch>FwkGdaAK</homebranch><holdingbranch>FwkGdaAK</holdingbranch><location></location><ccode></ccode><status>available</status><itemcallnumber></itemcallnumber><stocknumber></stocknumber></item></items>' # doesn't match '(?^u:<status>reference</status>)' -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Mar 16 Mar

3:02 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

...

Testing btoh with mariadb_d9 and mariadb_d10 I was unable to blank any fields in items, either individually or via batch edit - things like 'onloan' and 'itemlost_on' are successfully nulled as they should be.

Fixed, see "Use new method Koha::Object->set_or_blank"

...

Two test failures:

# Failed test 'Syntax check misc/migration_tools/fix_onloan.pl' # at /usr/share/perl5/Test/Strict.pm line 423. # Unmatched right curly bracket at misc/migration_tools/fix_onloan.pl line 20, at end of line # syntax error at misc/migration_tools/fix_onloan.pl line 20, near "}" # misc/migration_tools/fix_onloan.pl had compilation errors. # Looks like you failed 1 test of 706.

Fixed!

...

# Failed test 'reference if positive itemtype notforloan value' # at t/db_dependent/XSLT.t line 57. # '<items xmlns="http://www.koha-community.org/items"><item><homebranch>FwkGdaAK</ homebranch><holdingbranch>FwkGdaAK</holdingbranch><location></ location><ccode></ccode><status>available</status><itemcallnumber></ itemcallnumber><stocknumber></stocknumber></item></items>' # doesn't match '(?^u:<status>reference</status>)'

Fixed! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

20 Mar 20 Mar

1:29 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

...

(In reply to Nick Clemens from comment #68)

...
Testing btoh with mariadb_d9 and mariadb_d10 I was unable to blank any fields in items, either individually or via batch edit - things like 'onloan' and 'itemlost_on' are successfully nulled as they should be.

Fixed, see "Use new method Koha::Object->set_or_blank"

Batch modification to blank fields is still now working. Individual edits do work. Importing and replacing items does not work - the process hangs. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:17 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

...

(In reply to Jonathan Druart from comment #69)

...
(In reply to Nick Clemens from comment #68)

...
Testing btoh with mariadb_d9 and mariadb_d10 I was unable to blank any fields in items, either individually or via batch edit - things like 'onloan' and 'itemlost_on' are successfully nulled as they should be.

Fixed, see "Use new method Koha::Object->set_or_blank"

Batch modification to blank fields is still now working. Individual edits do work.

I fixed that one.

...

Importing and replacing items does not work - the process hangs.

I am not sure about that one. I got "DBD::mysql::st execute failed: Incorrect integer value: 'duplicate item barcode' for column 'itemnumber'" But not sure it's a bug from master or not. Could you retry the import? If it fails, can you remove 334 close STDOUT; 335 close STDERR; from tools/manage-marc-import.pl To get the error in the logs. -- You are receiving this mail because: You are watching all bug changes.

3:50 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #82 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101165&action=edit Bug 23463: Move plugin hook

...

From C4::Items to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #106 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101192&action=edit Bug 23463: Fix cn_source for new item get_dirty_columns only work for existing items. This fixes t/db_dependent/ShelfBrowser.t Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:52 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #107 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101193&action=edit Bug 23463: Fix XSLT.t

...

From commit bf49eecdd87e2b29760226281ab1afc0a185c7f0 Bug 23463: Replace AddItem calls with Koha::Item->store

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #119 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101253&action=edit Bug 23463: Replace ModItem with Koha::Item->store Starting to replace the ModItem calls with Koha::Item->store Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:13 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #120 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101254&action=edit Bug 23463: remove trivial UpdateHoldingbranch sub We do not need this subroutine, moving it where it is used. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:13 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #121 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101255&action=edit Bug 23463: Move plugin hook

...

From C4::Items to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #145 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101279&action=edit Bug 23463: Fix cn_source for new item get_dirty_columns only work for existing items. This fixes t/db_dependent/ShelfBrowser.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:14 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #146 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101280&action=edit Bug 23463: Fix XSLT.t

...

From commit bf49eecdd87e2b29760226281ab1afc0a185c7f0 Bug 23463: Replace AddItem calls with Koha::Item->store

in build_sample_item: - my $itype = delete $args->{itype} - || $self->build_object( { class => 'Koha::ItemTypes' } )->itemtype; + # If itype is not passed it will be picked from the biblio (see Koha::Item->store) So before we generated a new itemtype if not passed, now we pick the one from biblioitem->itemtype. For this specific test we need to make sure they are different. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:15 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #147 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101281&action=edit Bug 23463: Replace new occurrence of AddItem Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:15 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #148 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101282&action=edit Bug 23463: Use new method Koha::Object->set_or_blank This patch fixes an issue when editing items. * The issue Cannot blank a subfield when editing an item. If you have an item with itemcallnumber=42, then edit it, blank it and save. The itemcallnumber is still 42 * Why? (line numbers from https://gitlab.com/joubu/Koha/-/tree/bug_23463) additem (and other item's edition forms) receives a list of tags, subfields and values, generates a MARC::Record::XML then calls ModItemFromMarc: 717 my $itemtosave=MARC::Record::new_from_xml($xml, 'UTF-8'); 727 my $newitem = ModItemFromMarc($itemtosave, $biblionumber, $itemnumber); And ModItemFromMarc: 282 my $item = TransformMarcToKoha( $localitemmarc, $frameworkcode, 'items' ); 283 $item->{cn_source} = delete $item->{'items.cn_source'}; # Because of C4::Biblio::_disambiguate 284 $item_object->set($item); ModItemFromMarc never knows that the field has been blank. Prior to bug 23463 we had a map of default values, and ModItemFromMarc was doing: 426 my $item = TransformMarcToKoha( $localitemmarc, $frameworkcode, 'items' ); 427 my $default_values = _build_default_values_for_mod_marc(); 428 foreach my $item_field ( keys %$default_values ) { 429 $item->{$item_field} = $default_values->{$item_field} 430 unless exists $item->{$item_field}; 431 } I do not want to reinsert that list of default values. Here I wrote a generic method in Koha::Object to set the value passed in parameter, or "blank" if not passed. It's nulled if can be set to null in DB, or the default value is retrieved from the schema info. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:15 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #149 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101283&action=edit Bug 23463: (follow-up 2) Fix timestamp default value Removing previous change, again. But this time in Object.pm It fixes t/db_dependent/Koha/Object.t and t/db_dependent/Koha/Item.t is still passing. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:15 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #150 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101284&action=edit Bug 23463: Fix items.cn_sort vs cn_sort Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Mar 23 Mar

10:23 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:23 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #151 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:35 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #152 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101413&action=edit Bug 23463: Replace a new occurrence of ModItem This new script have been pushed just before 23463. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:35 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #153 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101414&action=edit Bug 23463: Fix CourseReserves/CourseItems.t -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:36 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #154 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101415&action=edit Bug 23463: (RM follow-up) Add try block around Illrequest item creation The recently introduced Ill item creation for circulation feature was not properly handling the move from AddItem to Koha::Item->new()->store. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:37 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #155 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101416&action=edit Bug 23463: Fix wrong variable name Fix for t/db_dependent/Labels/t_Batch.t -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:14 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #156 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101432&action=edit Bug 23463: Fix selenium tests (highlight a bug in date management) There is something wrong, and a regression has been caught by those tests: If an invalid date is passed from the add item form, the app now crashes. Before: * if the date was completely invalid, the field was blanked silently * DateTime::Format::MySQL was used to convert dates, and it's not strict at all. For instance, what happened in the selenium tests for dateaccessionned: %Y-%m-%d was prefilled by the framework plugin, then the biblionumber was added, we ended with something like (eg for today) 2020-03-234242 (with biblionumber=4242). DateTime::Format::MySQL converts that to 2020-03-23 We must deal with invalid dates, but I do not think it is good to add it back to Koha::Item->store, we will prefer to raise the error to the end user, saying that something went wrong (and more specifically the dates). The (ugly) trick was in C4::Items::_mod_item_dates -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:42 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #157 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Congratulations, Jonathan -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:24 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #158 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101476&action=edit Bug 23463: (follow-up 3) Fix timestamp default value This is the only situation I found where: * t/db_dependent/Koha/Item.t is passing * t/db_dependent/Koha/Object.t is passing * MySQL 8 is happy (and not fail with "Column 'timestamp' cannot be null"), which is certainly what I missed in the previous follow-up I think we should remove the lines from the overloaded ->store method (Item and Patron), but then we need Object.t to be adjusted. I do not understand why we would need to set updated_on, maybe the test is wrong? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

30 Mar 30 Mar

11:28 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

bugzilla-daemon＠bugs.koha-community.org

31 Mar 31 Mar

10:53 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #160 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Final follow-up pushed. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 Apr 2 Apr

4:13 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #161 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Let the customization fun start ;) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3 Apr 3 Apr

11:16 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #162 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

15 Apr 15 Apr

5:26 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Apr 16 Apr

3:38 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #163 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- $item_object->more_subfields_xml(_get_unlinked_subfields_xml($unlinked_item_subfields))->store; $item_object->store; Is this double store call intentional ? C4/Items ModItemFromMarc -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:05 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #164 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #163)

...

$item_object-

...
more_subfields_xml(_get_unlinked_subfields_xml($unlinked_item_subfields))- store; $item_object->store;

Is this double store call intentional ? C4/Items ModItemFromMarc

Nope! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Apr 17 Apr

10:42 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #165 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103129&action=edit Bug 23463: Remove double store call -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:27 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #166 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

22 Apr 22 Apr

4:06 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25248 [Bug 25248] Delete All Items should redirect to detail.pl, not additem.pl -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

27 May 27 May

3:54 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 [Bug 25608] Regression: Bug 23463 broke inventory -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12 Jun 12 Jun

4:27 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Pushed to master |Pushed to stable --- Comment #167 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9 Jul 9 Jul

11:30 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25964 [Bug 25964] Data loss possible when items are modified -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Aug 6 Aug

12:50 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26134 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26134 [Bug 26134] Error when adding to basket from new/staged file when using MARCItemFieldsToOrder -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

20 Aug 20 Aug

10:21 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26082 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26082 [Bug 26082] Follow up to bug 23463 - need to call Koha::Item store to get itemnumber -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

21 Aug 21 Aug

12:20 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 [Bug 26268] Remove items.paidfor once and for all -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 Sep 18 Sep

10:46 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26470 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26470 [Bug 26470] itemnumber not available for plugin hook -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

21 Sep 21 Sep

12:54 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26438 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26438 [Bug 26438] Follow up to bug 23463 - return from Koha::Item overwrites existing variable -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Sep 23 Sep

10:10 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26507 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 [Bug 26507] New items not indexed -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

14 Oct 14 Oct

11:16 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26675 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26675 [Bug 26675] Typo in line 341 of process_koc.pl -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10 Nov 10 Nov

2:10 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26987 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26987 [Bug 26987] No property notforloan for Koha::Serial::Item -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12 Nov 12 Nov

9:26 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #168 from Blou <philippe.blouin@inlibro.com> --- Created attachment 113581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113581&action=edit Bug 26948: Regression tests We already mock the send_or_die method from Email::Stuffer; This patch updates that mock to extract the internal representation of the email encoded message and looks for a known double encoded representation of a character in the sample body. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Blou <blou@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:27 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com Attachment #113581|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Nov 16 Nov

10:58 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992 [Bug 26992] On serial collection page, impossible to delete issues and related items -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

19 Nov 19 Nov

3:16 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26557 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26557 [Bug 26557] Batch import fails when incoming records contain itemnumber -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Nov 23 Nov

8:59 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26750 [Bug 26750] Deleted items are not removed from index -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 Dec 2 Dec

9:47 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 [Bug 27003] action_logs table error when adding an item -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

21 Jan 21 Jan

3:41 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27509 [Bug 27509] cn_sort value is lost when editing an item without changing cn_source or itemcallnumber -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 Mar 2 Mar

4:55 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Mar 16 Mar

11:35 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27963 [Bug 27963] touch_all_items.pl script is not working at all -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Mar 23 Mar

12:24 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27808 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808 [Bug 27808] Item's onloan column remains unset if a checked out item is issued to another patron without being returned first -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9 Apr 9 Apr

11:21 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28015 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28015 [Bug 28015] Inventory tool fails when timeformat=12h -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:41 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28028 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28028 [Bug 28028] fix_onloan.pl broken by bug 23463 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

28 Apr 28 Apr

11:12 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27819 [Bug 27819] Spurious errors when running delete_records_via_leader.pl -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:59 p.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28255 [Bug 28255] Follow up to bug 23463 - use item_object in misc/cronjobs/delete_items.pl -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Jan 6 Jan

7:05 a.m.

New subject: [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 [Bug 29794] delete_items.pl missing include -- You are receiving this mail because: You are watching all bug changes.

1650

Age (days ago)

2526

Last active (days ago)

List overview

Download

258 comments

1 participants

participants (1)

bugzilla-daemon＠bugs.koha-community.org