[Bug 31466] New: t/00-check-atomic-updates.t always fails if atomic update exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31466 Bug ID: 31466 Summary: t/00-check-atomic-updates.t always fails if atomic update exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Bug 31108 fixed the test to make it run, but now it fails if there is ever a file in the atomic updates directory. The test is unlike( $f, qr/.*pl$/, "check for unhandled atomic updates: $f" ); Which means the test passes if the atomic update filename DOES NOT MATCH the format something.pl. However atomic update files always match that format, so the test always fails and blocks packages from building. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31466 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |aleisha@catalyst.net.nz Change sponsored?|--- |Sponsored Depends on| |31108 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31466 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31466 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 139810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139810&action=edit Bug 31466: Fix t/00-check-atomic-updates.t to pass if atomic updates The way the test was previously written, it would fail if atomic updates matched the format /.*pl$/ . This is incorrect because atomic update names should match the format /.*pl/. To test: 1) Run t/00-check-atomic-updates.t. Confirm test passes 2) Add an atomic update. Use the example from https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomic... 3) Run t/00-check-atomic-updates.t. Confirm test fails 4) Apply patch and run t/00-check-atomic-updates.t. Test should pass! Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31466 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Needs Signoff |RESOLVED --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Never mind it has been explained to me that the test is correct and those of us doing custom packages will need to change how we handle atomic updates. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org