[Bug 26189] New: Table options on points of sale misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Bug ID: 26189 Summary: Table options on points of sale misaligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The table paging, sorting, and other options on the "items for purchase" table on the Points of sale page are misaligned and don't work well with the smaller table width. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 [Bug 26160] Add column configuration to sales table to allow hiding of 'Code' column -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108106&action=edit Bug 26189: Improve styling of POS table headers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Need a little CSS help here guys.. I can't for the life of me work out why the label + select/inputs are wrapping over two lines. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 108156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108156&action=edit Bug 26189: unset label width in payForm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Maybe just unset the width of labels inside of #payForm? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108156|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108164&action=edit Bug 26189: Improve styling of datatables within fieldsets This patch improves the responsive layout of datatables (and tables generally) by setting layout to 'fixed' and and enabled word-wrap on table cells. We also reset the margins for datatables found inside fieldsets such that the datatable properly utilises the available space and we restore the default datatable label font weights. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108165&action=edit Bug 21689: Unset label width restriction The label width restriction within fieldsets causes issues for the datatables header. Unsetting it explicitly here resolves the line wrapping issues :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108106|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Lucas Gass from comment #4)
Maybe just unset the width of labels inside of #payForm?
Dude! That's genius, how did I not spot that.. fixes it up perfectly :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #8 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- I received a conflict when trying to apply the patch: Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 26189: Improve styling of datatables within fieldsets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108164|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108743&action=edit Bug 26189: Improve styling of datatables within fieldsets Unset label width restriction: The label width restriction within fieldsets causes issues for the datatables header. Unsetting it explicitly here resolves the line wrapping issues :) Reset margins for datatables found inside fieldsets such that the datatable properly utilises the available space and restore the default datatable label font weights. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108165|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've rebased and simplified the patchset. You will need to run the CSS build to test this. (If testing on a sandbox, you can use the 'Build CSS' option from the 'Actions' menu) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108743|0 |1 is obsolete| | --- Comment #11 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 108744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108744&action=edit Bug 26189: Improve styling of datatables within fieldsets Unset label width restriction: The label width restriction within fieldsets causes issues for the datatables header. Unsetting it explicitly here resolves the line wrapping issues :) Reset margins for datatables found inside fieldsets such that the datatable properly utilises the available space and restore the default datatable label font weights. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- (In reply to Martin Renvoize from comment #10)
I've rebased and simplified the patchset.
You will need to run the CSS build to test this. (If testing on a sandbox, you can use the 'Build CSS' option from the 'Actions' menu)
No worries, thanks for the tip - it's probably paranoia but I always use 'Build CSS' if I think the patch touches anything styling-wise. Signed off. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Sally from comment #12)
(In reply to Martin Renvoize from comment #10)
I've rebased and simplified the patchset.
You will need to run the CSS build to test this. (If testing on a sandbox, you can use the 'Build CSS' option from the 'Actions' menu)
No worries, thanks for the tip - it's probably paranoia but I always use 'Build CSS' if I think the patch touches anything styling-wise.
Signed off. :)
Many thanks for testing 😀, very wise to use the Build CSS options, I must admit I'm terrible at remembering to mention it in the test plans. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sally, always happy to QA patches you tested :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108744|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108759&action=edit Bug 26189: Improve styling of datatables within fieldsets Unset label width restriction: The label width restriction within fieldsets causes issues for the datatables header. Unsetting it explicitly here resolves the line wrapping issues :) Reset margins for datatables found inside fieldsets such that the datatable properly utilises the available space and restore the default datatable label font weights. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108759|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108973&action=edit Bug 26189: Improve styling of datatables within fieldsets Unset label width restriction: The label width restriction within fieldsets causes issues for the datatables header. Unsetting it explicitly here resolves the line wrapping issues :) Reset margins for datatables found inside fieldsets such that the datatable properly utilises the available space and restore the default datatable label font weights. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #19 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27777 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org