[Bug 36334] New: Unnecessary JS code in member.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Bug ID: 36334 Summary: Unnecessary JS code in member.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163249&action=edit Bug 36334: Remove unnecessary JS code from member.tt This was initially written to set the input/select in the form in the left side of the main patron search page. But this is now done in patron-search.inc: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: <input type="text" class="search_patron_filter" value="[% search_filter | html %]" class="focus" /> I don't see how/when this code is still used. Additionally: #searchmember_filter => does not exist, it's .search_patron_filter $("searchfieldstype_filter").val("[% searchfieldstype | html %]"); => Not a valid selector -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com, | |pedro.amorim@ptfs-europe.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Nick, Pedro, could you confirm that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163249|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 163258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163258&action=edit Bug 36334: Remove unnecessary JS code from member.tt This was initially written to set the input/select in the form in the left side of the main patron search page. But this is now done in patron-search.inc: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: <input type="text" class="search_patron_filter" value="[% search_filter | html %]" class="focus" /> I don't see how/when this code is still used. Additionally: #searchmember_filter => does not exist, it's .search_patron_filter $("searchfieldstype_filter").val("[% searchfieldstype | html %]"); => Not a valid selector Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163258|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163268&action=edit Bug 36334: Remove unnecessary JS code from member.tt This was initially written to set the input/select in the form in the left side of the main patron search page. But this is now done in patron-search.inc: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: <input type="text" class="search_patron_filter" value="[% search_filter | html %]" class="focus" /> I don't see how/when this code is still used. Additionally: #searchmember_filter => does not exist, it's .search_patron_filter $("searchfieldstype_filter").val("[% searchfieldstype | html %]"); => Not a valid selector Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163269&action=edit Bug 36334: (follow-up) Restore selection of previous values in sidebar Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163269|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163275&action=edit Bug 36334: (follow-up) Restore selection of previous values in sidebar Before and after the first patch the values for category and library were not populated To test: 1 - With nothing applied search in the top bar, clicking the 'settings' button 2 - Select a search field, search type, category, and library 3 - Perform search, note only search field and search type are populated 4 - Apply first path, repeat, same result 5 - Apply this patch, repeat 6 - Confirm all four fields now populate in sidebar Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Jonathan, can you confirm my follow-up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Nick Clemens from comment #7)
Jonathan, can you confirm my follow-up?
Yes, good catch! Thanks a lot! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Code has changed in master since Bug 35329 So I prefer not to backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org