[Bug 29059] New: Keep non-repeatable attribute from patron to preserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 Bug ID: 29059 Summary: Keep non-repeatable attribute from patron to preserve Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com See bug 21648 comment 17. Suggestion is to keep the non-repeatable patron's attribute from the patron we selected instead of raising a blocking error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21648 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Depends on| |28217 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28217 [Bug 28217] Several non-repeatable attributes when merging patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125070&action=edit Bug 29059: Keep non-repeatable attribute from patron to preserve when merging See bug 21648 comment 17. Suggestion is to keep the non-repeatable patron's attribute from the patron we selected instead of raising a blocking error. A side-effect will be that when several patrons are merged, the non-repeatable attribute from the first one will be kept, which can result in unexpected result if the original patron does not have the attribute defined. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- It would be preferable if we are given the setting in both and could choose which to use. Also, it is more likely that the more recent record will have up-to-date information. Keeping the first one is not necessarily the best option. But it would be preferred to review the different entries and select the correct one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Then we need the full UI suggested by bug 21648 and this bug report can be closed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125070|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 131126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131126&action=edit Bug 29059: Keep non-repeatable attribute from patron to preserve when merging See bug 21648 comment 17. Suggestion is to keep the non-repeatable patron's attribute from the patron we selected instead of raising a blocking error. A side-effect will be that when several patrons are merged, the non-repeatable attribute from the first one will be kept, which can result in unexpected result if the original patron does not have the attribute defined. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Thanks, Jonathan! The enhancement in bug 21648 would be great, but this is a perfectly workable solution for the time-being! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131126|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132485&action=edit Bug 29059: Keep non-repeatable attribute from patron to preserve when merging See bug 21648 comment 17. Suggestion is to keep the non-repeatable patron's attribute from the patron we selected instead of raising a blocking error. A side-effect will be that when several patrons are merged, the non-repeatable attribute from the first one will be kept, which can result in unexpected result if the original patron does not have the attribute defined. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org