[Bug 6857] New: Show a warning if placing a reserve will incur a cost
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 Bug #: 6857 Summary: Show a warning if placing a reserve will incur a cost Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: robin@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org When placing a reserve via the OPAC, we should tell the user if this is going to cost them. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> 2011-09-08 06:35:07 UTC --- Created attachment 5352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5352 Bug 6857: display a charge warning alert for reserves If a user is placing a reserve on the OPAC, this'll let them know that it's going to cost them. Author: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff AssignedTo|oleonard@myacpl.org |robin@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-09-08 14:15:39 UTC --- How do I test this? I have an item type with a rental charge and I placed a hold on that item type and no warning appeared telling me that I was going to be charged the rental fee. So I'm wondering what cost we're talking about. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> 2011-09-08 23:59:51 UTC --- Oh, I forgot to squash two patches. The former being the syspref that turns this on. Let me try that again... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff --- Comment #4 from Robin Sheat <robin@catalyst.net.nz> 2011-09-09 02:51:04 UTC --- Oh, I was wrong about the syspref thing, was looking at the wrong branch. The issue is that it applies to reserves, not rental charges. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-09-09 15:28:10 UTC --- What reserve has a fee associated with it? Where do I set a fee associated with a hold? The only fee I know of is if the item is overdue or if the item has a rental charge. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-09 16:14:19 UTC --- Hi Nicole, hold fees can be set for borrower category types. Something else that would be nice to have in circ matrix :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 --- Comment #7 from Nicole C. Engard <nengard@gmail.com> 2011-09-09 18:58:41 UTC --- a sign that i'm just way way way too braindead! Off to retest. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5352|0 |1 is obsolete| | --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-09-09 19:01:21 UTC --- Created attachment 5390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5390 [SIGNED-OFF] Bug 6857: display a charge warning alert for reserves If a user is placing a reserve on the OPAC, this'll let them know that it's going to cost them. Author: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 --- Comment #9 from Nicole C. Engard <nengard@gmail.com> 2011-09-09 19:05:56 UTC --- Created attachment 5391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5391 Follow up to Bug 6857: Change language from 'reserve' to 'hold' Reserves are called holds all throughout the OPAC so this follow up updates the language in this patch to match the standard. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 --- Comment #10 from Nicole C. Engard <nengard@gmail.com> 2011-09-09 19:06:27 UTC --- Original patch signed off, follow up needs a sign off though. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Needs Signoff |Failed QA --- Comment #11 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-09 19:07:24 UTC --- Sorry to be a pain, but the <div> in the template for this message needs to have an ID so that it's content can be altered easily with JQuery (for any libraries who may not want this exact message to be displayed). Marking as Failed QA until 'id=reserve_fee' is added. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 --- Comment #12 from Nicole C. Engard <nengard@gmail.com> 2011-09-09 19:09:39 UTC --- i'll add that to my follow up. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5391|0 |1 is obsolete| | --- Comment #13 from Nicole C. Engard <nengard@gmail.com> 2011-09-09 19:11:41 UTC --- Created attachment 5392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5392 Follow up to Bug 6857: Change language from 'reserve' to 'hold' Reserves are called holds all throughout the OPAC so this follow up updates the language in this patch to match the standard. Also adds an id tag to the message for altering with JQuery. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff --- Comment #14 from Nicole C. Engard <nengard@gmail.com> 2011-09-09 19:12:27 UTC --- follow up includes the ID tag, so first patch is still signed off and follow up needs sign off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Passed QA --- Comment #15 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-09 19:36:20 UTC --- Thank you, Nicole. Signing off on your followup, and marking both patches as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-11 09:37:47 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6857 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Patch complexity|--- |Small patch Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org