[Bug 26685] New: Move Starman out of debian/control.in and into cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Bug ID: 26685 Summary: Move Starman out of debian/control.in and into cpanfile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: mtj@kohaaloha.com If we put Starman in to cpanfile, it will help people using cpanfile without the Debian packages, and it should mean that the dependency is automatically added to debian/control. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 111675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111675&action=edit Bug 26685: Move starman out of debian/control.in and into cpanfile -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Is there a test plan that would make sense for this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- I believe Starman is not strictly required, as other PSGI servers should work as well. And we also have an option to run Koha as a Mojolicious application. Would it make sense to move it to the 'recommends' section of cpanfile instead ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Julian Maurice from comment #3)
I believe Starman is not strictly required, as other PSGI servers should work as well. And we also have an option to run Koha as a Mojolicious application. Would it make sense to move it to the 'recommends' section of cpanfile instead ?
I think that your argument has merit, but if we want Koha to work out-of-the-box, we do need to provide a default requirement, which is going to be starman for the time being. Maybe we could put it as "recommends" in the cpanfile, and then keep "starman" in debian/control for koha-common and koha-full... and allow people to install whatever PSGI/Mojolicious server they want for koha-core... It seems that "C4/Installer/PerlModules.pm" and "debian/list-deps" won't process "recommends", so that could work... Perhaps something to discuss further.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Actually debian/list-deps processes all packages in cpanfile, even "suggests". The only difference between "requires" and the other types is that if it does not find a required package, it prints an error message. So we could remove starman from control.in, and add it in the "recommends" section of cpanfile. It should work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Is this ready for testing? If so please add a commit message which includes a detailed test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Created attachment 131226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131226&action=edit Update release notes for 21.11.03 release Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131226|0 |1 is obsolete| | --- Comment #8 from Mason James <mtj@kohaaloha.com> --- Comment on attachment 131226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131226 Update release notes for 21.11.03 release oops -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111675|0 |1 is obsolete| | --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Created attachment 131227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131227&action=edit Bug 26685: Move starman out of debian/control.in and into cpanfile to test... - apply patch - build and install new package - confirm starman package displays correctly in about.pl page Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Created attachment 131228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131228&action=edit Bug 26685: Move Starman out of debian/control.in and into cpanfile (2) defining package as 'recommended', as suggested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Created attachment 131229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131229&action=edit pic pic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- stretch (oldoldstable) 0.4014-1: all buster (oldstable) 0.4014-3: all bullseye (stable) 0.4015-1: all bookworm (testing) 0.4015-1: all sid (unstable) 0.4015-1: all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131227|0 |1 is obsolete| | Attachment #131228|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131974&action=edit Bug 26685: Move starman out of debian/control.in and into cpanfile to test... - apply patch - build and install new package - confirm starman package displays correctly in about.pl page Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131975&action=edit Bug 26685: Move Starman out of debian/control.in and into cpanfile (2) defining package as 'recommended', as suggested Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org