[Bug 41090] New: Final auto renewal error not handled in renew.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 Bug ID: 41090 Summary: Final auto renewal error not handled in renew.pl Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com To recreate: 1 - Set a circ rule for: Renewals Allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_renew_final "Continue without renewing" Item renewed.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188373&action=edit Bug 41090: Handle auto_renew_final message on renew.pl This patch removes the error and adds a variable mentioning the last renewal so we can note for the patron To test: 1 - Set a circ rule for: Renewals Allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_renew_final "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that this is the last renewal 9 - Sign off! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190206&action=edit Bug 41090: Handle auto_unseen_final message on renew.pl To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 2 Unseen renewals allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_unseen_final "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that this is the last unseen renewal 9 - Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190206|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190207&action=edit Bug 41090: Handle auto_unseen_final message on renew.pl To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 3 Unseen renewals allowed: 2 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: Item has been scheduled for automatic renewal "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that the item has been renewed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190208&action=edit Bug 41090: Handle auto_renew message on renew.pl This message can be ignored, we were allowed to renew in this case To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 3 Unseen renewals allowed: 2 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: Item has been scheduled for automatic renewal "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that the item has been renewed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188373|0 |1 is obsolete| | --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190209&action=edit Bug 41090: Handle auto_renew_final message on renew.pl This patch removes the error and adds a variable mentioning the last renewal so we can note for the patron To test: 1 - Set a circ rule for: Renewals Allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_renew_final "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that this is the last renewal 9 - Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190207|0 |1 is obsolete| | --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190210&action=edit Bug 41090: Handle auto_unseen_final message on renew.pl To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 2 Unseen renewals allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_unseen_final "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that this is the last unseen renewal 9 - Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190208|0 |1 is obsolete| | --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190211&action=edit Bug 41090: Handle auto_renew message on renew.pl This message can be ignored, we were allowed to renew in this case To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 3 Unseen renewals allowed: 2 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: Item has been scheduled for automatic renewal "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that the item has been renewed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190209|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 190488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190488&action=edit Bug 41090: Handle auto_renew_final message on renew.pl This patch removes the error and adds a variable mentioning the last renewal so we can note for the patron To test: 1 - Set a circ rule for: Renewals Allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_renew_final "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that this is the last renewal 9 - Sign off! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190210|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 190489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190489&action=edit Bug 41090: Handle auto_unseen_final message on renew.pl To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 2 Unseen renewals allowed: 1 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: auto_unseen_final "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that this is the last unseen renewal 9 - Sign off! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190211|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 190490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190490&action=edit Bug 41090: Handle auto_renew message on renew.pl This message can be ignored, we were allowed to renew in this case To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 3 Unseen renewals allowed: 2 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: Item has been scheduled for automatic renewal "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that the item has been renewed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks good. But I came across this code in the circ/renew template: [% ELSIF error == "auto_renew" or error == "auto_too_much_oweing" %] <p>[% INCLUDE 'biblio-title.inc' biblio=item.biblio link = 1 %] ( [% item.barcode | html %] ) has been scheduled for automatic renewal. </p> [% SET override_limit = error == "auto_renew" ? "AUTO_RENEW" : "TOO_MUCH" %] [% IF Koha.Preference('AllowRenewalLimitOverride') %] <form method="post" action="/cgi-bin/koha/circ/renew.pl"> [% INCLUDE 'csrf-token.inc' %] <input type="hidden" name="barcode" value="[% item.barcode | html %]" /> <input type="hidden" name="override_limit" value="[% override_limit | html %]" /> <input type="hidden" name="op" value="cud-renew" /> <button type="submit" class="btn btn-default approve"><i class="fa fa-check"></i> Override limit and renew</button> </form> So it seems here that you are only allowed to renew for the auto_renew case when the LimitOverride is set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41090 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Changing status for feedback on previous comment -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org