[Bug 25068] New: koha-common build error caused by missing /etc/searchengine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Bug ID: 25068 Summary: koha-common build error caused by missing /etc/searchengine Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylmala@helsinki.fi QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@bugs.koha-community.org, mirko@abunchofthings.net Commit 52e95fff34e1c6da967a4d86fbb99bec748ccb31 from Bug 24735 removes the directory etc/searchengine which causes the debian build to fail:
make[1]: Leaving directory '/build/koha-16.06~git+20200406100416.c800ef7e' dh_install -O--fail-missing dh_install: Cannot find (any matches for) "debian/tmp/etc/koha/searchengine" (tried in "." and "debian/tmp") dh_install: koha-common missing files: debian/tmp/etc/koha/searchengine dh_install: missing files, aborting debian/rules:9: recipe for target 'binary' failed make: *** [binary] Error 2 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 I: copying local configuration E: Failed autobuilding of package
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I followed the steps from the wiki (https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way), but I get E: pbuilder-satisfydepends failed. I: Copying back the cached apt archive contents I: unmounting dev/ptmx filesystem I: unmounting dev/pts filesystem I: unmounting dev/shm filesystem I: unmounting proc filesystem I: unmounting sys filesystem I: cleaning the build env I: removing directory /var/cache/pbuilder/build/25742 and its subdirectories Command 'pdebuild --buildresult /home/jonathan/debian' returns an error (256) on `sudo ./debian/build-git-snapshot -r ~/debian -v 19.12.67git -d`. I guess you could remove the following line to fix your issue: debian/koha-common.install:debian/tmp/etc/koha/searchengine -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 --- Comment #2 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- The wiki instructions don't work since one needs to use for example stretch to build Koha instead of the default that is squeeze. And yes, removing that line from koha-common.install fixes the issue but I don't want to submit a patch for this until I know how we are supposed to configure Elasticsearch with the Debian package. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Yep, I'm getting the problem too when using https://gitlab.com/minusdavid/koha-deb-builder-docker and master: make[1]: Leaving directory '/home/koha/build/koha-19.12.00-test+20200518020508.3dc1f8a8' dh_install -O--fail-missing cp: cannot stat 'debian/tmp/debian/tmp/etc/koha/searchengine': No such file or directory dh_install: cp -a debian/tmp/debian/tmp/etc/koha/searchengine debian/koha-common//etc/koha/ returned exit code 1 debian/rules:9: recipe for target 'binary' failed make: *** [binary] Error 2 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 debuild: fatal error at line 1376: dpkg-buildpackage -rfakeroot -D -us -uc failed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Joonas Kylmälä from comment #2)
The wiki instructions don't work since one needs to use for example stretch to build Koha instead of the default that is squeeze. And yes, removing that line from koha-common.install fixes the issue but I don't want to submit a patch for this until I know how we are supposed to configure Elasticsearch with the Debian package.
I haven't used Elasticsearch with Koha yet, so could you speak more to that one? It looks like the Elastic search config lives in "admin/searchengine/elasticsearch/field_config.yaml" rather than "etc/searchengine"? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25485 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485 [Bug 25485] TinyMCE broken in Debian package installs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Created attachment 104993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104993&action=edit Bug 25068: Fix koha-common.install directives Bug 24735 removed etc/searchengine/queryparser.yml, which removed the need for koha-common.install to install the following file: debian/tmp/etc/koha/searchengine This patch removes that line and causes the Koha packages to build correctly again. To test: 0) Apply patch 1) Build a Koha package using one of the following methods: - https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way - https://hub.docker.com/r/koha/koha-dpkg - https://gitlab.com/minusdavid/koha-deb-builder-docker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 [Bug 25510] Typo in koha-common.postinst causing shell errors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25510 | Severity|major |critical --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Upping this one to critical as you can't build packages until it's fixed Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 [Bug 25510] Typo in koha-common.postinst causing shell errors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 [Bug 24735] Remove QueryParser-related code -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 [Bug 25510] Typo in koha-common.postinst causing shell errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104993|0 |1 is obsolete| | --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Created attachment 105010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105010&action=edit Bug 25068: Fix koha-common.install directives Bug 24735 removed etc/searchengine/queryparser.yml, which removed the need for koha-common.install to install the following file: debian/tmp/etc/koha/searchengine This patch removes that line and causes the Koha packages to build correctly again. To test: 0) Apply patch 1) Build a Koha package using one of the following methods: - https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way - https://hub.docker.com/r/koha/koha-dpkg - https://gitlab.com/minusdavid/koha-deb-builder-docker Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 --- Comment #8 from Mason James <mtj@kohaaloha.com> --- (In reply to David Cook from comment #6)
Upping this one to critical as you can't build packages until it's fixed
i confirm this bug and fix, thanks David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25529 [Bug 25529] [OMNIBUS] 20.05 debian packages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Tested it with the updated koha/koha-dpkg image: $ docker run --volume=/Users/tcohen/git/koha:/koha --volume=/Users/tcohen/tmp/debs:/debs --privileged --env VERSION=19.12.00.089 koha/koha-dpkg:master => ... dpkg-deb: building package 'koha' in '../koha_19.12.00.089-1_all.deb'. dpkg-deb: building package 'koha-common' in '../koha-common_19.12.00.089-1_all.deb'. dpkg-deb: building package 'koha-deps' in '../koha-deps_19.12.00.089-1_all.deb'. dpkg-deb: building package 'koha-perldeps' in '../koha-perldeps_19.12.00.089-1_all.deb'. dpkg-genbuildinfo dpkg-genchanges >../koha_19.12.00.089-1_amd64.changes dpkg-genchanges: info: including full source code in upload dpkg-source --after-build koha-19.12.00.089 dpkg-buildpackage: info: full upload (original source is included) I: copying local configuration I: Copying back the cached apt archive contents I: unmounting dev/ptmx filesystem I: unmounting dev/pts filesystem I: unmounting dev/shm filesystem I: unmounting proc filesystem I: unmounting sys filesystem I: cleaning the build env I: removing directory /var/cache/pbuilder/build/279 and its subdirectories I: Current time: Mon May 18 22:07:12 UTC 2020 I: pbuilder-time-stamp: 1589839632 git checkout -- debian/changelog All good! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105010|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 105051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105051&action=edit Bug 25068: Fix koha-common.install directives Bug 24735 removed etc/searchengine/queryparser.yml, which removed the need for koha-common.install to install the following file: debian/tmp/etc/koha/searchengine This patch removes that line and causes the Koha packages to build correctly again. To test: 0) Apply patch 1) Build a Koha package using one of the following methods: - https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way - https://hub.docker.com/r/koha/koha-dpkg - https://gitlab.com/minusdavid/koha-deb-builder-docker Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm seeing an upgrade error. Gimme a few -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #11)
I'm seeing an upgrade error. Gimme a few
All good, it was just a warning about /etc/koha/searchengine not being empty, but it died, and now I cannot reproduce. My attempt is to have a 19.11 install (vagrant/stretch64) and then install the packages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #12)
(In reply to Tomás Cohen Arazi from comment #11)
I'm seeing an upgrade error. Gimme a few
All good, it was just a warning about /etc/koha/searchengine not being empty, but it died, and now I cannot reproduce. My attempt is to have a 19.11 install (vagrant/stretch64) and then install the packages.
I recall seeing that warning when upgrading as well, although I didn't have any errors per se. That said, I wonder if Bug 24735 needs a follow-up to remove the /etc/koha/searchengine/queryparser.yaml file if it exists... as otherwise that file will just clutter up existing installs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #13)
(In reply to Tomás Cohen Arazi from comment #12)
(In reply to Tomás Cohen Arazi from comment #11)
I'm seeing an upgrade error. Gimme a few
All good, it was just a warning about /etc/koha/searchengine not being empty, but it died, and now I cannot reproduce. My attempt is to have a 19.11 install (vagrant/stretch64) and then install the packages.
I recall seeing that warning when upgrading as well, although I didn't have any errors per se.
That said, I wonder if Bug 24735 needs a follow-up to remove the /etc/koha/searchengine/queryparser.yaml file if it exists... as otherwise that file will just clutter up existing installs.
I had a follow-up to submit this one, but then I thought we *could* be wrong on deleting it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #14)
I had a follow-up to submit this one, but then I thought we *could* be wrong on deleting it.
Yeah I wonder that too. It doesn't feel great deleting config files :/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #17 from Joy Nelson <joy@bywatersolutions.com> --- missing dependencies- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org