[Bug 12110] New: Display the order vendor note in basket and basketgroup CSV and PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 Bug ID: 12110 Summary: Display the order vendor note in basket and basketgroup CSV and PDF Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mathsabypro@gmail.com QA Contact: testopia@bugs.koha-community.org Now that Bug 9416 is pushed, we can improve Basketgroup PDFs to display the note made for the vendor. We can also replace the internal order note with the vendor order note. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |mathsabypro@gmail.com |ity.org | --- Comment #1 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 27310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27310&action=edit [PATCH] Bug 12110 : Display the order vendor note in basket and basketgroup CSV and PDF This bug adds the "vendor note" for each order in the PDF for basketgroups. The note is display only if it exists, just under the bibliographic information. I added a separation line "--------" between bibliographic information and the note, so that it could be visible at 1st glance It also replaces the internal note with the vendor in the CSV for basket and basketgroup It is more logical and useful for libraries to export the note made for vendor, as those files are destined to be sent to the vendor. Test plan : - fill a basket with some orders, some with internal notes, some with vendor notes - export the basket in CSV : only the vendor notes should be present - put the basket in a basketgroup - export the basketgroup in CSV : only the vendor notes should be present - Select "English-2 pages" template for basketgroups in Sysprefs - export the basket in PDF : the vendor notes should be present under the bibliographic information - Select "English-3 pages" template for basketgroups in Sysprefs - export the basket in PDF : the vendor notes should be present under the bibliographic information -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aleishaamohia@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 --- Comment #2 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 28111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28111&action=edit [PATCH] Bug 12110 : Display the order vendor note in basket and basketgroup CSV and PDF Rebased (to take into account the changes made by bug 11859) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27310|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 --- Comment #3 from mathieu saby <mathsabypro@gmail.com> --- Back to need sign off Of course, you can discuss the ergonomy of the display for the vendor note (maybe the "----------" before the note is not very nice) Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi@cineca.it --- Comment #4 from Paola Rossi <paola.rossi@cineca.it> --- I test against master 3.15.00.051 . All is OK. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28111|0 |1 is obsolete| | --- Comment #5 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 28168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28168&action=edit Display the order vendor note in basket and basketgroup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28168|0 |1 is patch| | Attachment #28168|application/mbox |text/plain mime type| | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- I think the change should be done in all packages existing in acqui/pdfformat. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 --- Comment #7 from mathieu saby <mathsabypro@gmail.com> --- (In reply to Jonathan Druart from comment #6)
I think the change should be done in all packages existing in acqui/pdfformat.
Marked as Failed QA.
I suppose you mean in german and french version. I can do it for french, of course, and try to do something for german. I don't speak german, but Google Translate proposes "Hinweise für den Lieferanten" for "Note for vendor". I will ask Katrin to be sure. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think "Lieferantennotiz" is what we use in some other places, so that might work :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 --- Comment #9 from mathieu saby <mathsabypro@gmail.com> --- I was just writing you a mail ;-) Thank you for the advice Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 --- Comment #10 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 28314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28314&action=edit Bug 12110 [PATCH 2/2] QA followup : french and german translation This followup - translates "vendor note" in french and german. - replaces "Notes for vendor" with "Note for vendor" in english template (as there can only be 1 note) - fixes a typo in french template (Qte => Qté, for "Quantité") Test plan : set OrderPdfFormat preference to "French 3-pages" Print a basketgroup containing an order with a vendornote, and check the note is displayed and introduced by "Notes pour le fournisseur" set OrderPdfFormat preference to "German 2-pages" Print a basketgroup containing an order with a vendornote, and check the note is displayed and introduced by "Lieferantennotiz" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28168|0 |1 is obsolete| | Attachment #28314|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28381&action=edit Bug 12110 : Display the order vendor note in basket and basketgroup CSV and PDF (Rebased after bug 11859 is pushed) This bug adds the "vendor note" for each order in the PDF for basketgroups. The note is display only if it exists, just under the bibliographic information. I added a separation line "--------" between bibliographic information and the note, so that it could be visible at 1st glance It also replaces the internal note with the vendor in the CSV for basket and basketgroup It is more logical and useful for libraries to export the note made for vendor, as those files are destined to be sent to the vendor. Test plan : - fill a basket with some orders, some with internal notes, some with vendor notes - export the basket in CSV : only the vendor notes should be present - put the basket in a basketgroup - export the basketgroup in CSV : only the vendor notes should be present - Select "English-2 pages" template for basketgroups in Sysprefs - export the basket in PDF : the vendor notes should be present under the bibliographic information - Select "English-3 pages" template for basketgroups in Sysprefs - export the basket in PDF : the vendor notes should be present under the bibliographic information Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28381|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28382&action=edit Bug 12110 : Display the order vendor note in basket and basketgroup CSV and PDF (Rebased after bug 11859 is pushed) This bug adds the "vendor note" for each order in the PDF for basketgroups. The note is display only if it exists, just under the bibliographic information. I added a separation line "--------" between bibliographic information and the note, so that it could be visible at 1st glance It also replaces the internal note with the vendor in the CSV for basket and basketgroup It is more logical and useful for libraries to export the note made for vendor, as those files are destined to be sent to the vendor. Test plan : - fill a basket with some orders, some with internal notes, some with vendor notes - export the basket in CSV : only the vendor notes should be present - put the basket in a basketgroup - export the basketgroup in CSV : only the vendor notes should be present - Select "English-2 pages" template for basketgroups in Sysprefs - export the basket in PDF : the vendor notes should be present under the bibliographic information - Select "English-3 pages" template for basketgroups in Sysprefs - export the basket in PDF : the vendor notes should be present under the bibliographic information Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28383&action=edit Bug 12110 [PATCH 2/2] QA followup : french and german translation This followup - translates "vendor note" in french and german. - replaces "Notes for vendor" with "Note for vendor" in english template (as there can only be 1 note) - fixes a typo in french template (Qte => Qté, for "Quantité") Test plan : set OrderPdfFormat preference to "French 3-pages" Print a basketgroup containing an order with a vendornote, and check the note is displayed and introduced by "Notes pour le fournisseur" set OrderPdfFormat preference to "German 2-pages" Print a basketgroup containing an order with a vendornote, and check the note is displayed and introduced by "Lieferantennotiz" Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org