[Bug 27770] New: ES: Deprecated aggregation order key [_term] used, replaced by [_key]"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Bug ID: 27770 Summary: ES: Deprecated aggregation order key [_term] used, replaced by [_key]" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: victor@tuxayo.net Will be needed for ES 7 prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t [DEPRECATION] Deprecated aggregation order key [_term] used, replaced by [_key] - In request: {body => {aggregations => {subject => {terms => {field => "subject__facet",include => "[eE][aA][sS][yY].*",order => {_term => "asc"},size => 1000}}},from => 0,query => {query_string => {query => "*"}},size => 0},ignore => [],method => "GET",mime_type => "application/json",path => "/koha_kohadev_mydb/_search",qs => {},serialize => "std"} -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ES: Deprecated aggregation |ES: Deprecated aggregation |order key [_term] used, |order key [_term] used, |replaced by [_key]" |replaced by [_key] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 --- Comment #1 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 130290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130290&action=edit Bug 27770: ES: Deprecated aggregation order key [_term] used, replaced by [_key] Starting in Elasticsearch 6.0 _key should be used instead of _term to order buckets by their term To test: 1) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 2) If you observe an error about types, apply patch for bug 25669 3) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4) Observe if you get a deprecation warning about order key 5) Apply patch 6) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 7) Observe no deprecation warning about order key 8) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.carnes@ub.lu.se --- Comment #2 from Kevin Carnes <kevin.carnes@ub.lu.se> --- This solution includes a check for versions prior to Elasticsearch 6. I don't know if there are any plans to drop support for Elasticsearch 5. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130290|0 |1 is obsolete| | --- Comment #3 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 130342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130342&action=edit Bug 27770: ES: Deprecated aggregation order key [_term] used, replaced by [_key] Starting in Elasticsearch 6.0 _key should be used instead of _term to order buckets by their term To test: 1) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 2) If you observe an error about types, apply patch for bug 25669 3) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4) Observe if you get a deprecation warning about order key 5) Apply patch 6) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 7) Observe no deprecation warning about order key 8) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Kevin Carnes from comment #2)
This solution includes a check for versions prior to Elasticsearch 6. I don't know if there are any plans to drop support for Elasticsearch 5.
It has been dropped from some time ago, Bug 27252 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130342|0 |1 is obsolete| | --- Comment #5 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 130543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130543&action=edit Bug 27770: ES: Deprecated aggregation order key [_term] used, replaced by [_key] Starting in Elasticsearch 6.0 _key should be used instead of _term to order buckets by their term To test: 1) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 2) If you observe an error about types, apply patch for bug 25669 3) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4) Observe if you get a deprecation warning about order key 5) Apply patch 6) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 7) Observe no deprecation warning about order key 8) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130543|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 130828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130828&action=edit Bug 27770: ES: Deprecated aggregation order key [_term] used, replaced by [_key] Starting in Elasticsearch 6.0 _key should be used instead of _term to order buckets by their term To test: 1) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 2) If you observe an error about types, apply patch for bug 25669 3) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4) Observe if you get a deprecation warning about order key 5) Apply patch 6) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 7) Observe no deprecation warning about order key 8) Sign off Sponsored-by: Lund University Library Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It work! :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Straightforward fix, nothing suspicious online found about this deprecation, no occurrence of _term remaining, tests passing, QA script happy. Passing QA, unless the Release Manager says otherwise ^^ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27252 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Victor Grousset/tuxayo from comment #4)
(In reply to Kevin Carnes from comment #2)
This solution includes a check for versions prior to Elasticsearch 6. I don't know if there are any plans to drop support for Elasticsearch 5.
It has been dropped from some time ago, Bug 27252
When turning off pref ElasticsearchCrossFields you may use ES 5 but requirements page says ES 6 : https://wiki.koha-community.org/wiki/System_requirements_and_recommendations I'm OK to drop support to focus on ES 7 compatibility. And ES 8 is coming :D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Maybe only backport to stable 21.11 and not lower. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Fridolin Somers from comment #9)
When turning off pref ElasticsearchCrossFields you may use ES 5 but requirements page says ES 6 : https://wiki.koha-community.org/wiki/System_requirements_and_recommendations
That seems like a bonus. It doesn't seem to have been mentioned and thus lead to dropping ES5 from the sys reqs. We indeed could have been more subtle in dropping ES5 if ElasticsearchCrossFields off is not a big deal for many Koha instances. Anyway, ES5 was eol for a while at that time.
Maybe only backport to stable 21.11 and not lower.
Too much downsides IMO. ES6 is eol so if something like the log4j critical security vulnerabilities happen again, ES7 is the only fix. So down to Koha 19.11, compat is need in order to get back to having an ES supported. (even if ES7 is not longer libre/open source but that's another topic once ES7 compat is sorted out) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Sure, get to 19.11 LTS if possible -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Fridolin Somers from comment #10)
Maybe only backport to stable 21.11 and not lower.
Per Frido, not backporting to 21.05.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.13 released in| | --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Backported to 21.05.x for 21.05.13. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03,21.05.13 |22.05.00,21.11.03,21.05.13, released in| |20.11.17 --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.11.x branch for 20.11.17 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #18 from wainuiwitikapark@catalyst.net.nz --- Does this need to be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Yes, it has been classified as critical because it's one of the pieces for ES 7 support. Since ES 6 is EOL we are in a precarious situation where any new ES security issue will be unpatchable via updating ES. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 --- Comment #20 from wainuiwitikapark@catalyst.net.nz --- Backported to 19.11.x for 19.11.30 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 --- Comment #21 from wainuiwitikapark@catalyst.net.nz --- This patch doesn't seem to work well on 19.11.x actually. If it is necessary, please provide a patch for 19.11.x. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 --- Comment #22 from wainuiwitikapark@catalyst.net.nz --- I won't actually be looking after 19.11.x anymore though. As there were no other important patches in the last month, I won't release this month. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org