[Bug 18447] New: Datepicker only shows -10/+10 years
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Bug ID: 18447 Summary: Datepicker only shows -10/+10 years Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When entering patrons they are often more than 10 years old - entering a birth date requires constantly clicking back 10 years on the date picker - we should load a few more years in the past This was fixed in bug 12342 but that code is no longer used -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12342 Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 [Bug 12342] Patron registration datepicker dropdown shows only 10 years -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62300&action=edit Bug 18447 - Datepicker only shows -10/+10 years To test: 1 - Open some date pickers (patron entry, subscriptions, anywhere really) 2 - Note that default is 10 years in either direction, updated when you select 3 - Apply patch 4 - Note we now get -100 years / +10 years from current selection 5 -Sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why do you want -100 to be the default? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- In the previous patch it was set to -120, -100 seemed to be enough - basically we want a value where librarians don't have to perform several clicks to select a year. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes for the date of birth, but your patch modifies all the datepickers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62300|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62306&action=edit Bug 18447 - Datepicker only shows -10/+10 years To test: 1 - Open some date pickers (patron entry, subscriptions, anywhere really) 2 - Note that default is 10 years in either direction, updated when you select 3 - Apply patch 4 - Note we now get -100 years / +10 years from current selection 5 -Sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62306|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 62323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62323&action=edit Bug 18447 - Datepicker only shows -10/+10 years To test: 1 - Open some date pickers (patron entry, subscriptions, anywhere really) 2 - Note that default is 10 years in either direction, updated when you select 3 - Apply patch 4 - Note we now get -100 years / +10 years from current selection 5 -Sign off Assume that test plan changed (birth date in staff only), works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch --- Comment #7 from Marc Véron <veron@veron.ch> --- Maybe bug title should be changed to reflect the new scope of this bug (date of birth in staff client only) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Datepicker only shows |Datepicker only shows |-10/+10 years |-10/+10 years for date of | |birth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why do you use the c-100;c+10 (relative to the current date) and not -120;+0 (relative to today)? It does not make sense to have years in the future here -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note that the same fix should be applied to the OPAC. Ccing Owen to get his feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- I think -100 years / +10 years from current selection is a good default. I do think it makes sense to have future dates included in the default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Sorry, I misread the changes in the patch. I thought it was a global change, and it isn't. So I guess my question is: Why not make a global change, and set a different range for specific cases like date of birth? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Having more than 10 years past globally makes sense to me, but 100 seems a bit much. I am thinking of date pickers in acq/serials for example. Maybe: Global: -20, +19 Date of birth. -100, +0 But not opposed to a general change of -100, +10 either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Bug 18447 depends on bug 12342, which changed state. Bug 12342 Summary: Patron registration datepicker dropdown shows only 10 years https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62323|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65116&action=edit Bug 18447 - Datepicker only shows -10/+10 years This patch makes 2 changes: 1 - Global datepicker defaulted to c-100:c+10 2 - Dateofbirth datepicker defaulted to c-100:c To test: 1 - Open some date pickers (patron entry, subscriptions, anywhere really) - Make sure to check some dateofbirth datepickers 2 - Note that default is 10 years in either direction, updated when you select 3 - Apply patch 4 - Note we now get -100 years / +10 years from current selection 5 - Now find a dateofbirth datepicker and note default is -100:+0 6 - Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65117&action=edit Bug 18447 - Add changes to opac -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65118&action=edit Bug 18447 - Remove redundant line This line was added by bug 12342 but seems to have stopped working. These patches set default so this specific case should not be needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65116|0 |1 is obsolete| | --- Comment #16 from Marc Véron <veron@veron.ch> --- Created attachment 65135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65135&action=edit Bug 18447 - Datepicker only shows -10/+10 years This patch makes 2 changes: 1 - Global datepicker defaulted to c-100:c+10 2 - Dateofbirth datepicker defaulted to c-100:c To test: 1 - Open some date pickers (patron entry, subscriptions, anywhere really) - Make sure to check some dateofbirth datepickers 2 - Note that default is 10 years in either direction, updated when you select 3 - Apply patch 4 - Note we now get -100 years / +10 years from current selection 5 - Now find a dateofbirth datepicker and note default is -100:+0 6 - Sign off Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65117|0 |1 is obsolete| | --- Comment #17 from Marc Véron <veron@veron.ch> --- Created attachment 65136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65136&action=edit Bug 18447 - Add changes to opac Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65118|0 |1 is obsolete| | --- Comment #18 from Marc Véron <veron@veron.ch> --- Created attachment 65137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65137&action=edit Bug 18447 - Remove redundant line This line was added by bug 12342 but seems to have stopped working. These patches set default so this specific case should not be needed. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 65140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65140&action=edit [SIGNED-OFF] Bug 18447 - Datepicker only shows -10/+10 years This patch makes 2 changes: 1 - Global datepicker defaulted to c-100:c+10 2 - Dateofbirth datepicker defaulted to c-100:c To test: 1 - Open some date pickers (patron entry, subscriptions, anywhere really) - Make sure to check some dateofbirth datepickers 2 - Note that default is 10 years in either direction, updated when you select 3 - Apply patch 4 - Note we now get -100 years / +10 years from current selection 5 - Now find a dateofbirth datepicker and note default is -100:+0 6 - Sign off Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 65141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65141&action=edit [SIGNED-OFF] Bug 18447 - Add changes to opac Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 65142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65142&action=edit [SIGNED-OFF] Bug 18447 - Remove redundant line This line was added by bug 12342 but seems to have stopped working. These patches set default so this specific case should not be needed. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Attachment #65135|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65136|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65137|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please look at opac-memberentry $( "#borrower_dateofbirth" ).datepicker({ yearRange: "c-120:c" The name of the control is not #dateofbirth either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65309&action=edit Bug 18447 - QA Followup - fix opac usage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66459&action=edit Bug 18447 - Datepicker only shows -10/+10 years This patch makes 2 changes: 1 - Global datepicker defaulted to c-100:c+10 2 - Dateofbirth datepicker defaulted to c-100:c To test: 1 - Open some date pickers (patron entry, subscriptions, anywhere really) - Make sure to check some dateofbirth datepickers 2 - Note that default is 10 years in either direction, updated when you select 3 - Apply patch 4 - Note we now get -100 years / +10 years from current selection 5 - Now find a dateofbirth datepicker and note default is -100:+0 6 - Sign off Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66460&action=edit Bug 18447 - Add changes to opac Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66461&action=edit Bug 18447 - Remove redundant line This line was added by bug 12342 but seems to have stopped working. These patches set default so this specific case should not be needed. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65309|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66462&action=edit Bug 18447 - QA Followup - fix opac usage Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Oh those SIGNED OFF labels again.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65140|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65141|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65142|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Set a date of birth for 100+ years people is not possible with these patches, that is why I suggested 120 in comment 8. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #29)
Set a date of birth for 100+ years people is not possible with these patches, that is why I suggested 120 in comment 8.
Can be, with one more click. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #32 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Looks fine to me for patron create. But years range is strange when a date of birth already exists, say "01/01/1950", years range is 1850 to 1950. I propose a follow-up to set range from current year and 120 (instead of 100) years earlier. Some people may have more than 100 years,maybe more often in the future. (Lets hope we will soon all be cyborgs ~(o_o)~ ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #33 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 67448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67448&action=edit Bug 18447: (follow-up) years range not dependent on current value Bug 18447 sets for date of birth a year range "c-100:c" meaning current year and 100 years earlier. This is good when imput is empty. But when input already contains a date, say "01/01/1950", years range is 1850 to 1950. This patch sets for date of birth a year range "-120:+0" to not be dependent on current value. Some people may have more than 100 years (maybe more often in the future) so i choose to propose maximum 120 years old. To test : 1) Go to intranet 2) Create a new patron 3) Click on date picker on "Date of birth" input 4) Look at available years in combobox, you see from 1897 to 2017 5) Edit an existing patron with for example date of birth in 1950 6) Repeat 3) and 4) 7) Go to OPAC 8) Login with a patron with for example date of birth in 1950 9) Go to "your personal details" 10) Repeate 3) and 4) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #32)
Looks fine to me for patron create. But years range is strange when a date of birth already exists, say "01/01/1950", years range is 1850 to 1950.
I propose a follow-up to set range from current year and 120 (instead of 100) years earlier. Some people may have more than 100 years,maybe more often in the future. (Lets hope we will soon all be cyborgs ~(o_o)~ )
We already discussed about that, please open a new bug report if you want to modify the current behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67448|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #35 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #34)
(In reply to Fridolin SOMERS from comment #32)
Looks fine to me for patron create. But years range is strange when a date of birth already exists, say "01/01/1950", years range is 1850 to 1950.
I propose a follow-up to set range from current year and 120 (instead of 100) years earlier. Some people may have more than 100 years,maybe more often in the future. (Lets hope we will soon all be cyborgs ~(o_o)~ )
We already discussed about that, please open a new bug report if you want to modify the current behaviour.
Ah indeed comment 8, sorry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19402 [Bug 19402] Date of birth datepicker year range depending on current value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Bug 18447 depends on bug 12342, which changed state. Bug 12342 Summary: Patron registration datepicker dropdown shows only 10 years https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org