https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9834 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 90680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90680&action=edit Bug 23133: Rename uses of item_level_hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |Needs Signoff --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, my two cents. I included the schema updates, let me know if you need it separate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #5)

suspend in the same table is still BOOLEAN.

BOOLEAN is just an alias for TINYINT(1), I think it is worth changing anyway unless...

If SQL12 is applied we should patch all existing occurrences, and have a check in the QA script. Is there a bug report already?

we have this kind of thing, and we actually prefer to add them as BOOLEAN in kohastructure.sql, because we have TINYINT(1) fields that are not really booleans (for example marc_subfield_structure.tab). There isn't a bug report yet (sorry for that), and it would be great to have the QA tools catch this problems. If BOOLEAN helps detect them, then lets change the rule and use BOOLEAN! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry mate, but I can't apply this one.. error: sha1 information is lacking or useless (Koha/Schema/Result/Reserve.pm). error: could not build fake ancestor Patch failed at 0001 Bug 23133: DB update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21294 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90679|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 90857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90857&action=edit Bug 23133: DB update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90681|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 90859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90859&action=edit Bug 23133: API cleanup Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Koha/Schema/Result/OldReserve.pm | 8 ++++---- Koha/Schema/Result/Reserve.pm | 8 ++++---- .../atomicupdate/bug_23133_item_level_holds.perl | 19 +++++++++++++++++++ installer/data/mysql/kohastructure.sql | 4 ++-- I would not recommend doing this in one patch. And thought that we even had a rule for that? But can't find it. DBIx schema files should be separate and marked as do_not_push, if the RM wants to generate them himself. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- While this patches are correct and shouldn't be FQA, I'm marking as duplicate, as bug 25260 tackles it already. *** This bug has been marked as a duplicate of bug 25260 *** -- You are receiving this mail because: You are watching all bug changes.