[Bug 20156] New: Staff client header language menu doesn't show check mark for current language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Bug ID: 20156 Summary: Staff client header language menu doesn't show check mark for current language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The markup for the staff client header's language menu is supposed to show a check mark next to the currently-selected language. Because of copy-paste from the OPAC (which uses Glyphicons), the check mark doesn't appear. It should use Font Awesome. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71297&action=edit Bug 20156 - Staff client header language menu doesn't show check mark for current language This patch replaces Glyphicon markup with Font Awesome markup so that a check mark appears next to the currently-selected language in the staff client header's language menu. Also changed in this patch: Some classes have been removed because they are not used in staff client CSS. To test you must have multiple languages installed and enabled in the staff client. - Set the StaffLangSelectorMode system preference to "top" or "both top and footer" - Confirm that the currently-select language in the langauge menu has a check mark next to it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71297|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 71298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71298&action=edit Bug 20156 - Staff client header language menu doesn't show check mark for current language This patch replaces Glyphicon markup with Font Awesome markup so that a check mark appears next to the currently-selected language in the staff client header's language menu. Also changed in this patch: Some classes have been removed because they are not used in staff client CSS. To test you must have multiple languages installed and enabled in the staff client. - Set the StaffLangSelectorMode system preference to "top" or "both top and footer" - Confirm that the currently-select language in the langauge menu has a check mark next to it. Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71298|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71329&action=edit Bug 20156 - Staff client header language menu doesn't show check mark for current language This patch replaces Glyphicon markup with Font Awesome markup so that a check mark appears next to the currently-selected language in the staff client header's language menu. Also changed in this patch: Some classes have been removed because they are not used in staff client CSS. To test you must have multiple languages installed and enabled in the staff client. - Set the StaffLangSelectorMode system preference to "top" or "both top and footer" - Confirm that the currently-select language in the langauge menu has a check mark next to it. Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org