[Bug 19843] New: reviews.datereviewed is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843 Bug ID: 19843 Summary: reviews.datereviewed is not set Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 15839 Caused by commit 092ae340cef375cc66c8511fd34c1a4eec9c7ba6 Bug 15839: Koha::Reviews - Remove savereview the datereviewed=now() part of the query has not been translated. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 [Bug 15839] Move the reviews related code to Koha::Reviews -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69928&action=edit Bug 19843: (bug 15839 follow-up) Set reviews.datereviewed when the review is made Caused by commit 092ae340cef375cc66c8511fd34c1a4eec9c7ba6 Bug 15839: Koha::Reviews - Remove savereview the datereviewed=now() part of the query has not been translated. Test plan: Add a review from the OPAC Confirm that the reviews.datereviewd has been correctly set. Without this patch it is set to NULL. I have no idea how we could update existing data :-/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69928|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69948&action=edit Bug 19843: (bug 15839 follow-up) Set reviews.datereviewed when the review is made Caused by commit 092ae340cef375cc66c8511fd34c1a4eec9c7ba6 Bug 15839: Koha::Reviews - Remove savereview the datereviewed=now() part of the query has not been translated. Test plan: Add a review from the OPAC Confirm that the reviews.datereviewd has been correctly set. Without this patch it is set to NULL. I have no idea how we could update existing data :-/ Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69948|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 70000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70000&action=edit Bug 19843: (bug 15839 follow-up) Set reviews.datereviewed when the review is made Caused by commit 092ae340cef375cc66c8511fd34c1a4eec9c7ba6 Bug 15839: Koha::Reviews - Remove savereview the datereviewed=now() part of the query has not been translated. Test plan: Add a review from the OPAC Confirm that the reviews.datereviewd has been correctly set. Without this patch it is set to NULL. I have no idea how we could update existing data :-/ Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to stable for 17.11.01, awesome work all! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org