[Bug 22713] New: Replacement price removed when receiving if using MarcItemFieldstoOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Bug ID: 22713 Summary: Replacement price removed when receiving if using MarcItemFieldstoOrder Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: nick@bywatersolutions.com Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Created attachment 88048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88048&action=edit replacement price in item record acq process In 18.11 the wording and functionality changed in Acquisitions with the field Replacement price. This allowed libraries to have their replacement price set in the Acquisitions order and also in the item record. However, if a library is using MarcItemFieldstoOrder system preference and setting their replacement price in the marc record upon Importing. The replacement price only stays on the Item Record and will not be included into the Acquisitions order and it won't populate into the receiving process- and therefore making it $0. It would be nice if the item record had the replacement price from the MarcItemFieldstoOrder, and this would follow it through the process and since it is there in the item, it be used in the Order. Process currently: 1. Set marcitemfieldstorder to have a $v replacement price (975$v) 2. Create a basket 3. Upload a marc file that has a replacement price in the record 4. Add this file to your basket. 5. The item record will display the replacement price. 6. The basket.pl will not display the replacement price of this item 7. CLose the basket 8. When receiving the item in Acquisitions, the replacement price is zeroed out 9. The item will not have a replacement price once it is received. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88792&action=edit Bug 22713: Pass replacement price in to order if defined by MarcItemFieldsToOrder To test: 1 - Have AcqCreateItems set to 'On ordering' (or set in a basket) 2 - Define MARCItemFieldsToOrder homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 970$c notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 975$q budget_code: 975$h price: 975$g replacementprice: 975$p 3 - Have a marc record with some order info defined as above, including a replacementprice 4 - Add to basket - > from a new file 5 - Don't check for duplicates, add the order 6 - Note the order has no replacementprice, but the item does 7 - Close basket, receive order, do not enter a new replacement price 8 - Note the items replacement price is clear 9 - Apply patch 10 - Repeat 11 - Note when order added to basket it has a replacement price 12 - Note when order is received the replacement price is populated and passed into item correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 robbinsk@middlesex.mass.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robbinsk@middlesex.mass.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88792|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89187&action=edit Bug 22713: Pass replacement price in to order if defined by MarcItemFieldsToOrder To test: 1 - Have AcqCreateItems set to 'On ordering' (or set in a basket) 2 - Define MARCItemFieldsToOrder homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 970$c notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 975$q budget_code: 975$h price: 975$g replacementprice: 975$p 3 - Have a marc record with some order info defined as above, including a replacementprice 4 - Add to basket - > from a new file 5 - Don't check for duplicates, add the order 6 - Note the order has no replacementprice, but the item does 7 - Close basket, receive order, do not enter a new replacement price 8 - Note the items replacement price is clear 9 - Apply patch 10 - Repeat 11 - Note when order added to basket it has a replacement price 12 - Note when order is received the replacement price is populated and passed into item correctly Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |18639 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 [Bug 18639] Separate replacement cost and retail price fields in acquisitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89376&action=edit Bug 22713: Remove unecessary $replacementprice var -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89187|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89611&action=edit Bug 22713: Pass replacement price in to order if defined by MarcItemFieldsToOrder To test: 1 - Have AcqCreateItems set to 'On ordering' (or set in a basket) 2 - Define MARCItemFieldsToOrder homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 970$c notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 975$q budget_code: 975$h price: 975$g replacementprice: 975$p 3 - Have a marc record with some order info defined as above, including a replacementprice 4 - Add to basket - > from a new file 5 - Don't check for duplicates, add the order 6 - Note the order has no replacementprice, but the item does 7 - Close basket, receive order, do not enter a new replacement price 8 - Note the items replacement price is clear 9 - Apply patch 10 - Repeat 11 - Note when order added to basket it has a replacement price 12 - Note when order is received the replacement price is populated and passed into item correctly Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89376|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89612&action=edit Bug 22713: Remove unecessary $replacementprice var Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Version(s)| |19.05.00, 18.11.06 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependency for 18.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8179 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8179 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org