[Bug 6390] New: Basket only visible for librarian who created it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Bug #: 6390 Summary: Basket only visible for librarian who created it Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/acqui/booksellers.pl OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org At the moment only staff with superlibrarian rights can see baskets created by other staff logins in acquisition. This applies, when you search for a vendor from the acquistion start page and when you search for the vendor using the search on top. When you search an order by title you can go from the search results to the basket. In a library with only a few librarians working together and student workers creating orders it's not what the library wants. They want the ability to search for all baskets open from a vendor and see what others have done. I talked to Paul Poulain on IRC and we can't just change the behaviour, because some libraries want it to work the way it does now. So what is the way to go? Paul suggested adding new permissions to granular permissions: * see all * see my library *see mine only Is this the way to go or are there other ideas how to solve the problem and make the view more flexible to work for different workflows? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Edgar Fuß <ef@math.uni-bonn.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ef@math.uni-bonn.de --- Comment #1 from Edgar Fuß <ef@math.uni-bonn.de> 2011-07-31 13:47:03 UTC --- As I need this functionality too, I just implemented the ``see mine/my branch/all'' suggestion. I added a new syspref, AcqViewBaskets, taking the values user/branch/all. The required MySQL statement to add this to the database is: INSERT INTO `systempreferences` (variable,value,options,explanation,type) VALUES ('AcqViewBaskets','user','user|branch|all','Define which baskets a user is allowed to view: his own only, any within his branch or all','Choice'); I don't feel comfortable enough with the automatic version tracking/database updating machinery to implement the changes need for that. For the change proper, see attached patch. However, that's all no real security as long as you can just pass ?basketno=nnn to all of the scripts handling baskets. You either have to change these or to randomise basket numbers. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #2 from Edgar Fuß <ef@math.uni-bonn.de> 2011-07-31 13:52:27 UTC --- Created attachment 4778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4778 Implement ``see mine/my branches/all baskets''-syspref Patch written by Edgar Fuß, Mathematisches Institut der Universität Bonn. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #3 from Edgar Fuß <ef@math.uni-bonn.de> 2011-07-31 21:26:02 UTC --- Created attachment 4782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4782 Same patch as before in GIT format I've converted the previous patch to GIT format. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Does not apply AssignedTo|henridamien@koha-fr.org |ef@math.uni-bonn.de --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-08-01 11:28:09 UTC --- $git bz apply 6390 Bug 6390 - Basket only visible for librarian who created it Implement ``see mine/my branches/all baskets''-syspref Apply? [yn] y Patch format detection failed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4778|0 |1 is obsolete| | Attachment #4782|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> 2011-08-05 08:17:19 UTC --- Created attachment 4853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4853 Same as previous patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6676 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-15 20:05:56 UTC --- *** Bug 4132 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Failed QA --- Comment #7 from Nicole C. Engard <nengard@gmail.com> 2011-09-06 18:15:54 UTC --- This patch is missing an updatedatabase edit. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-09-06 18:46:44 UTC --- I'll try to work up a follow up with the updatedatabase bit -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4853|0 |1 is obsolete| | --- Comment #9 from Nicole C. Engard <nengard@gmail.com> 2011-09-06 19:01:41 UTC --- Created attachment 5323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5323 [SIGNED-OFF] Bug 6390: Implement ``see mine/my branches/all baskets'-syspref' Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #10 from Nicole C. Engard <nengard@gmail.com> 2011-09-06 19:03:42 UTC --- Created attachment 5324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5324 Follow up for Bu 6390: Add upatedatabase.pl This patch updated the language of the preference and added to updatedatabase.pl which was missing in the last patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #11 from Nicole C. Engard <nengard@gmail.com> 2011-09-06 19:05:51 UTC --- Okay my follow up needs to be signed off on and once that happens the two patches can be applied together to make this work. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #12 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-07 17:21:49 UTC --- Neither patch addresses the issue of basket.pl, like bug 6824 does. Apparently the same kind of check needs to be done here, as well (see patch for that bug report) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-07 17:26:01 UTC --- Patches also need a follow-up for systempreferences.sql. Now that Magnus' patches are pushed only en will be needed. The first patch should give credit to Edgar Fuß. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5323|0 |1 is obsolete| | Attachment #5324|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-19 19:29:27 UTC --- Created attachment 5461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5461 Bug 6390 - Basket only visible for librarian who created it (Follow up) This adds the new system preference to the syspref.sql file -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5461|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-19 19:29:51 UTC --- Created attachment 5462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5462 Bug 6390: Implement 'see mine/my branches/all baskets'-syspref Code written by Edgar Fuß <ef@math.uni-bonn.de>, Mathematisches Institut der Uniersität Bonn Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-19 19:29:59 UTC --- Created attachment 5463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5463 Follow up for Bug 6390: Add upatedatabase.pl This patch updated the language of the preference and added to updatedatabase.pl which was missing in the last patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-19 19:31:03 UTC --- Created attachment 5464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5464 Bug 6390 - Basket only visible for librarian who created it (Follow up) This adds the new system preference to the syspref.sql file -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-19 19:31:55 UTC --- First 2 patches are signed-off - please sign-off on last patch so this can get into 3.6! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5464|0 |1 is obsolete| | --- Comment #19 from Nicole C. Engard <nengard@gmail.com> 2011-09-21 18:53:22 UTC --- Created attachment 5518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5518 [SIGNED-OFF] Bug 6390 - Basket only visible for librarian who created it (Follow up) This adds the new system preference to the syspref.sql file Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #20 from Nicole C. Engard <nengard@gmail.com> 2011-09-21 18:53:40 UTC --- last patch signed off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-07 14:47:20 UTC --- kf, same problems as with another patch tested yesterday fatal: cannot convert from UTF-8utf-8 to UTF-8 Patch left in /tmp/Bug-6390-Implement-see-minemy-branchesall-baskets--pmwyHR.patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #22 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-07 15:41:43 UTC --- Patch applied, and here are my test results: 1) the applied patch governs user search in the Vendor tab properly; depending on the setting, when searching for a vendor I either get only mine, only my branch's, or all. 2) superlibrarian privileges to not give me access to all; the preference value trumps superlibrarian 3) search in the Orders tab is completely unaffected, so I can still get to any basket using that search 4) system preference editor text is very andro-centric ("he", "his"); needs to be gender neutral Points 2 and 4 gives me cause to mark this as Failed QA. Point 3 just makes me pause; is this system preference intended to govern access universally, or only for this one search page? Need to understand the intended scope. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5463|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5518|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-08 16:50:37 UTC --- Created attachment 5802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5802 Bug 6390: Implement 'see mine/my branches/all baskets'-syspref Code written by Edgar Fuß <ef@math.uni-bonn.de>, Mathematisches Institut der Uniersität Bonn Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - rebased on current master, fixed a conflict in booksellers.pl - reworked permission checks to account for general acq permissions - FIXME check for superlibrarian permission not working - rephrased text of system preference (Thx to Jared Camins-Esakov) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5518|1 |0 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5462|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |--- --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-08 17:18:13 UTC --- 2) Is not solved. I was not able to get it working, perhaps someone else can. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7002 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-11 15:09:50 UTC --- My problem might be related to the problem reported in 7002. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5802|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-12 20:06:26 UTC --- Created attachment 5862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5862 Bug 6390: Implement 'see mine/my branches/all baskets'-syspref Code written by Edgar Fuß <ef@math.uni-bonn.de>, Mathematisches Institut der Uniersität Bonn Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - rebased on current master, fixed a conflict in booksellers.pl - reworked permission checks to account for general acq permissions and superlibrarian permission - rephrased text of system preference (Thx to Jared Camins-Esakov) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |--- -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5518|0 |1 is obsolete| | Attachment #5862|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-12 20:17:06 UTC --- Created attachment 5863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5863 Bug 6390: Implement 'see mine/my branches/all baskets'-syspref Code written by Edgar Fuß <ef@math.uni-bonn.de>, Mathematisches Institut der Uniersität Bonn Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - rebased on current master, fixed a conflict in booksellers.pl - reworked permission checks to account for general acq permissions and superlibrarian permission - rephrased text of system preference (Thx to Jared Camins-Esakov) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-12 20:18:40 UTC --- New patch (hopefully) resolving all problems noted by Ian attached, waiting for sign-off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5863|0 |1 is obsolete| | --- Comment #29 from Nicole C. Engard <nengard@gmail.com> 2011-10-17 16:15:24 UTC --- Created attachment 5935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5935 [SIGNED-OFF] Bug 6390: Implement 'see mine/my branches/all baskets'-syspref Code written by Edgar Fuß <ef@math.uni-bonn.de>, Mathematisches Institut der Uniersität Bonn Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - rebased on current master, fixed a conflict in booksellers.pl - reworked permission checks to account for general acq permissions and superlibrarian permission - rephrased text of system preference (Thx to Jared Camins-Esakov) Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #30 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-17 16:25:15 UTC --- Simple enough change; adds C4::Context dependency to acqui/booksellers (by necessity). Branch detection method is lean (GetMember instead of GetMemberDetails), and permissions are written out cleanly with comments for each aspect. Preference language is now gender-neutral (thank you!). Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5463|1 |0 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #31 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-17 20:48:06 UTC --- Patch pushed, please test. I appreciate all the work gone into this, well done. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #32 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-18 20:09:29 UTC --- ....and I missed something. aqbasket.authorisedby is not a foreign key to borrowers.borrowernumber. It's *normally* the borrowernumber, but there is no provision for handling deleted borrowernumbers, and migrated acquisitions information could leave this field blank without plenty. So, when a basket has a non-borrowernumber value in authorisedby, vendor search breaks: Can't use an undefined value as a HASH reference at /home/sekjal/kohaclone/acqui/booksellers.pl line 114. Working on a fix now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #33 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-18 20:19:59 UTC --- Created attachment 5963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5963 Follow up patch Prevents cases where authorisedby is not a valid borrowernumber from breaking vendor search. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5963|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-18 20:51:39 UTC --- Created attachment 5966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5966 [SIGNED-OFF] Bug 6390 Followup: Basket's authorisedby might not be a borrowernumber aqbasket.authorisedby is not foreign key constrainted to borrowers.borrowernumber, so if it's anything other than that, vendor search breaks by using an undefined value (GetMember() on an invalid borrowernumber) as a HASH ref. This patch sets the branchcode (the desired value from GetMember) to a blank value, then only changes it if GetMember is defined. In the case where the authorisedby librarian has been deleted, or the value is otherwise invalid, and AcqViewBaskets is set to 'branch', the basket will not appear except to superlibrarians Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Invalid borrowernumber in aqbasket.authorisedby no longer breaks search. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #35 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-19 08:19:29 UTC --- aqbasket.authorisedby is not a foreign key to borrowers.borrowernumber. => and it must not : if a librarian leaves the library, the order must not be deleted (for many reasons, one of them being financial statistics) ! The foreign key could be SET NULL, but not DELETE ! So we must handle an empty authorisedby, not prevent it to happend -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-19 08:22:39 UTC --- If we set it to NULL we must decide who gets to see it, because this messes up with the whole permission system. superlibrarian = can see it, always sees all Syspref settings: only my own - strict, was default before this patch. Who inherits the NULL baskets? Can I suddenly see what I was not allowed to see before? only my branch - less strict, but again - how do we determine to with branch this basket belongs to? all - no problem -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #37 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-19 18:03:55 UTC --- We could try a fall-back check of deleted_borrowers. If the borrower record was deleted by normal means, it should be in there, and we should be able to extract their branchcode. The issue of who inherits a departing staff member's baskets is still unresolved, but hopefully it will be such a rare occurrence for most libraries that having a rigourous method for dealing with this will be a low priority item. Personally, I don't think there will be a good solution until we have improved borrowers enough to allow for arbitrary Borrower Relationships (beyond just Guarantor/Guarantee). Something that will let us specify 'supervisor' or something similar. I'm going to pass my fix through QA, because it's better than a broken vendor search. Release Manager, please double-check me on this, and anyone, if you object, speak up! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6824 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #38 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-04 10:55:37 UTC --- before applying to master, a preliminary question: is this really a bug or an ENH ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-04 11:00:52 UTC --- It's probably debatable. The feature is already in 3.6 - we only need the follow-up to prevent vendor search from breaking under certain conditions. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #40 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-06 16:02:39 UTC --- Just FYI: there is an updatedatabase in this patch. We've proposed a new method to handle database update (http://lists.koha-community.org/pipermail/koha-devel/2011-November/036402.ht...), and there is no 3.7 updates yet. So I will wait until the new system to updatedatabase to apply this fix (and the patch won't apply anymore, but i'll take care of that) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-06 16:41:06 UTC --- Paul, the syspref is already in. It's only the follow-up that is missing. No database update for that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #42 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-06 17:00:24 UTC --- patch "Bug 6390 Followup: Basket's authorisedby might not be a borrowernumber" applied and pushed on branch new/bug_6390, and then merged onto master. Please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #43 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-11-16 14:19:55 UTC --- This patch does not apply cleanly to the 3.4.x branch. If it should, please rebase against that branch and attach a corrected patch to this bug. cnighs@erasmus:~/koha.3.2.test (3.4.x)$ git cherry-pick -x -s 58bdfdb08883eb5 Automatic cherry-pick failed. After resolving the conflicts, mark the corrected paths with 'git add <paths>' or 'git rm <paths>' and commit the result with: git commit -c 58bdfdb08883eb52777321f883491eaff1493857 cnighs@erasmus:~/koha.3.2.test (3.4.x *+)$ git status # On branch 3.4.x # Your branch is ahead of 'origin/3.4.x' by 21 commits. # # Unmerged paths: # (use "git reset HEAD <file>..." to unstage) # (use "git add/rm <file>..." as appropriate to mark resolution) # # both modified: acqui/booksellers.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-27 21:17:59 UTC --- System preference with permissions was added with version 3.6. I think it's ok to not backport to 3.4 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org