[Bug 40307] New: Use GET in form of value_builder/unimarc_field_210c.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 Bug ID: 40307 Summary: Use GET in form of value_builder/unimarc_field_210c.tt Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Since CSRF procetion form without CUD action must use GET instead of POST Fix value_builder/unimarc_field_210c.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40306 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 183792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183792&action=edit Bug 40307: Use GET in form of value_builder/unimarc_field_210c.tt Since CSRF procetion form without CUD action must use GET instead of POST Fix value_builder/unimarc_field_210c.tt Test plan : 1) Use UNIMARC catalog 2) Define unimarc_field_210c value builder on 210$c 3) Define an autority type EDITORS with heading on 200$b 4) Create an autority of this type 5) Index this new autority 6) Edit a biblio record and launch 210$c value builder 7) Search for new autority 8) Click on 'Choose' 9) Heading is pasted in 210$c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I attempted to test, but I'm not familiar enough with UNIMARC authorities to follow steps 3 to 4. Step-by-step instructions for these steps would help. Otherwise, I'll leave for others more knowledgeable to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #3 from Mathieu Saby <mathsabypro@gmail.com> --- I'm going to test it preliminary question : Can I use this "CO" type for the test plan? 210 is for "publisher", not "editor". And there is already in standard configuration an authority type "CO" (Corporate Body Name) with summary "[210a ][ (210c)][. 210b][ -- 210d][ ; 210e][ ; 210f][ -- 210x][ -- 210z][ -- 210y]" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- You may. The goal is to test the form is working -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 --- Comment #5 from Mathieu Saby <mathsabypro@gmail.com> --- Oh I misunderstood the authority type config page. I thought the "210" for CO authority type was the bibliographic field. It is the field of the auth record. So it cannot work with a CO authority But I don't understand why an authoriry with a 200 heading should be used in 210$c of bibliographic record. Authorities with a 200 heading are for Personnal names (https://www.transition-bibliographique.fr/unimarc/manuel-unimarc-format-noti... ), and 210$c is the Publisher. Most of the time the publisher will be a corporate name, not a personnal name. Besides, I never worked in a library using authority to control the publisher field. Is that feature really used ? Is there something similar in MARC21 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 --- Comment #6 from Mathieu Saby <mathsabypro@gmail.com> --- I checked in UNIMARC manual for 210 and 214. Those fields does not seem to be designed to be controlled by an authority. If that were the case, they would include a subfield for the authority identifier, such as fields 6xx or 7xx. I have the impression that this is a specific adaptation for Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- See also Bug 42095 (In reply to Fridolin Somers from comment #0)
Since CSRF protection form without CUD action must use GET instead of POST
While mostly true, in some cases POST would be preferred for scalability if the form needs to be able to send many parameters/values. I think GET should work for both of these cases, but I don't know enough about this value builder part of Koha to really test it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Currently all other value builders use GET form. There are only a few inputs to send. (We have applied this patch on our installs since summer 2025) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183792|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 195709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195709&action=edit Bug 40307: Use GET in form of value_builder/unimarc_field_210c.tt Since CSRF procetion form without CUD action must use GET instead of POST Fix value_builder/unimarc_field_210c.tt Test plan : 1) Use UNIMARC catalog 2) Define unimarc_field_210c value builder on 210$c 3) Define an autority type EDITORS with heading on 200$b 4) Create an autority of this type 5) Index this new autority 6) Edit a biblio record and launch 210$c value builder 7) Search for new autority 8) Click on 'Choose' 9) Heading is pasted in 210$c Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 --- Comment #10 from David Nind <david@davidnind.com> --- I've signed off, even though I wasn't able to test fully - not able to create a new authority type (and don't really understand "headings"). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195709|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 199414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199414&action=edit Bug 40307: Use GET in form of value_builder/unimarc_field_210c.tt Since CSRF procetion form without CUD action must use GET instead of POST Fix value_builder/unimarc_field_210c.tt Test plan : 1) Use UNIMARC catalog 2) Define unimarc_field_210c value builder on 210$c 3) Define an autority type EDITORS with heading on 200$b 4) Create an autority of this type 5) Index this new autority 6) Edit a biblio record and launch 210$c value builder 7) Search for new autority 8) Click on 'Choose' 9) Heading is pasted in 210$c Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Status|Passed QA |Failed QA --- Comment #12 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi guys the patch looks solid and simple but in order to follow the test plan I had to change the hardcoded PERSON_NAME to 'EDITORS' otherwise the authority doesn't show when using the 210$c value builder plugin: index 61656cf569d..4c5fc76c154 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tt @@ -22,7 +22,7 @@ <input type="hidden" name="type" value="intranet" /> <input type="hidden" name="nbstatements" value="[% nbstatements | html %]" /> <input type="hidden" name="index" value="[% index | html %]" /> - <input type="hidden" name="authtypecode" value="PERSO_NAME" /> + <input type="hidden" name="authtypecode" value="EDITORS" /> ---- I also had to run the following SQL manually to inject the subfield or else trying to 'View MARC structure' on the newly created authority type results in a server error: INSERT INTO auth_tag_structure (authtypecode, tagfield, liblibrarian, libopac, repeatable, mandatory) VALUES ('EDITORS', '200', 'Heading', 'Heading', 0, 1); INSERT INTO auth_subfield_structure (authtypecode, tagfield, tagsubfield, liblibrarian, libopac, repeatable, mandatory, tab, hidden, linkid, frameworkcode, display_order) VALUES ('EDITORS', '200', 'b', 'Part of name', 'Part of name', 0, 0, 0, 0, 0, '', 0); ---- Failing QA to get some comments here. Additionally, in order to be able to to test UNIMARC properly, had to launch ktd as follows: KOHA_MARC_FLAVOUR=unimarc ktd up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40307 --- Comment #13 from Mathieu Saby <mathsabypro@gmail.com> --- This feature is related to publishers. Why should we use the word 'EDITORS' ? This is misleading. By the way it is not standard unimarc, but koha-specific. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org