https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Related note: If you're using Zebra, you have QueryAutoTruncate enabled, and QueryWeightFields enabled, you'll have fairly simple query building happening. It leads to the following situation: Search: "Emperor penguin (Aptenodytes forsteri) foraging ecology" Query: @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 "Emperor penguin (Aptenodytes forsteri) foraging ecology" Search: Emperor penguin (Aptenodytes forsteri) foraging ecology Query: ZOOM error 10014 "CCL parsing error" (addinfo: "Operator expected") from diag-set 'ZOOM' Search: Emperor penguin \(Aptenodytes forsteri\) foraging ecology Query: @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 "Emperor penguin (Aptenodytes forsteri) foraging ecology" ZOOM::Query::CCL2RPN returns an exception with code, addinfo, message, and diagset fields: $VAR1 = bless( { 'code' => 10014, 'addinfo' => 'Operator expected', 'message' => 'CCL parsing error', 'diagset' => 'ZOOM' }, 'ZOOM::Exception' ); We would need to return this exception or derived data from C4::Search::getRecords() and then from Koha::SearchEngine::Zebra::Search::search_compat(). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- That said, I don't think any search system would ever say "Sorry, your query contains a syntax error. Try again." So probably this is more of a "feature" than a "bug" that we don't tell the user that their search couldn't be processed. It's a shame that we don't have a mechanism for storing searches that fail, so that we can analyze them and work to avoid their problems in the future... While we might not think of bad search queries as "bad data", perhaps we should and leverage ideas regarding "bad data" such as "automated data quality monitoring and error detection". I'll have to put some more thought into this, but I think that there's a seed there of something. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #3)

I like the idea

I've done more thinking this morning, and now I'm starting to think about just monitoring Zebra better. Possibly putting together a Koha plugin to act as a Prometheus exporter, so it would scan Zebra logs for errors and then let Prometheus pull that data into itself. It could then be interrogated in Prometheus, and we as developers could then track back issues and improve Koha's Zebra integration as a result. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27291 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to David Cook from comment #6)

Frido: Bug 27291 may be interesting to you. I think that change would make it a lot easier to monitor the Zebra logs...

Oooo nice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #8)

The "You did not specify any search criteria." part is incorrect, but the user is informed something wrong happened.

Hmm, is that something that we want to concede to users? If so, then adding feature parity with ES for Zebra isn't a bad idea, although one of these days I will over to ES... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #10)

(In reply to David Cook from comment #9)

...

(In reply to Jonathan Druart from comment #8)

...

The "You did not specify any search criteria." part is incorrect, but the user is informed something wrong happened.

Hmm, is that something that we want to concede to users?

Yes, I think so, and it's what you wanted on comment 0 if I understand correctly :)

True although I changed my mind later heh -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.