[Bug 37757] New: notice_email_address explodes if EmailFieldPrimary is not valid
UPDATE systempreferences SET value='' WHERE variable='EmailFieldPrimary';
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Bug ID: 37757 Summary: notice_email_address explodes if EmailFieldPrimary is not valid Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Found this in the wild on `22.11`, from the AutoEmailPrimaryAddress era. Which had the syspref set to an empty string. And was able to reproduce on `main`. To reproduce: 1. Have EmailFieldPrimary set to an empty string or NULL $ ktd --shell k$ koha-mysql kohadev 2. Enable `AutoEmailNewUser` 3. Create a new user => FAIL: Koha explodes like: ``` The method Koha::Patron-> is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 992 Koha::Object::AUTOLOAD('Koha::Patron=HASH(0xaaaae37ac550)') called at /kohadevbox/koha/Koha/Patron.pm line 1662 Koha::Patron::notice_email_address('Koha::Patron=HASH(0xaaaae37ac550)') called at /kohadevbox/koha/members/memberentry.pl line 448 ... ``` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 170840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170840&action=edit Bug 37757: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 170841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170841&action=edit Bug 37757: Update EmailFieldPrimary value -- You are receiving this mail because: You are watching all bug changes.
UPDATE systempreferences SET value='' WHERE variable='EmailFieldPrimary';
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 170842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170842&action=edit Bug 37757: Make notice_email_address() handle EmailFieldPrimary values more robustly This patchset makes: * The EmailFieldPrimary value 'OFF' be replaced by an empty string * Koha::Patron->notice_email_address() handle the empty case more gracefully To test: 1. On main, manually set the EmailFieldPrimary syspref to empty $ ktd --shell k$ koha-mysql kohadev 2. Enable `AutoEmailNewUser` 3. Create a new user => FAIL: Koha explodes like: ``` The method Koha::Patron-> is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 992 Koha::Object::AUTOLOAD('Koha::Patron=HASH(0xaaaae37ac550)') called at /kohadevbox/koha/Koha/Patron.pm line 1662 Koha::Patron::notice_email_address('Koha::Patron=HASH(0xaaaae37ac550)') called at /kohadevbox/koha/members/memberentry.pl line 448 ... 4. Apply this patches 5. Run: k$ updatedatabase => SUCCESS: Update succeeds 6. Restart all and retry creating a patron => SUCCESS: It worked! 7. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 170843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170843&action=edit Bug 37757: (follow-up) Warn on bad values and survive -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33192 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170840|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 171160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171160&action=edit Bug 37757: Unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170841|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 171161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171161&action=edit Bug 37757: Update EmailFieldPrimary value Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
UPDATE systempreferences SET value='' WHERE variable='EmailFieldPrimary';
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170842|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 171162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171162&action=edit Bug 37757: Make notice_email_address() handle EmailFieldPrimary values more robustly This patchset makes: * The EmailFieldPrimary value 'OFF' be replaced by an empty string * Koha::Patron->notice_email_address() handle the empty case more gracefully To test: 1. On main, manually set the EmailFieldPrimary syspref to empty $ ktd --shell k$ koha-mysql kohadev 2. Enable `AutoEmailNewUser` 3. Create a new user => FAIL: Koha explodes like: ``` The method Koha::Patron-> is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 992 Koha::Object::AUTOLOAD('Koha::Patron=HASH(0xaaaae37ac550)') called at /kohadevbox/koha/Koha/Patron.pm line 1662 Koha::Patron::notice_email_address('Koha::Patron=HASH(0xaaaae37ac550)') called at /kohadevbox/koha/members/memberentry.pl line 448 ... 4. Apply this patches 5. Run: k$ updatedatabase => SUCCESS: Update succeeds 6. Restart all and retry creating a patron => SUCCESS: It worked! 7. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170843|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 171163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171163&action=edit Bug 37757: (follow-up) Warn on bad values and survive Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171160|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171447&action=edit Bug 37757: Unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171161|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171448&action=edit Bug 37757: Update EmailFieldPrimary value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
UPDATE systempreferences SET value='' WHERE variable='EmailFieldPrimary';
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171162|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171449&action=edit Bug 37757: Make notice_email_address() handle EmailFieldPrimary values more robustly This patchset makes: * The EmailFieldPrimary value 'OFF' be replaced by an empty string * Koha::Patron->notice_email_address() handle the empty case more gracefully To test: 1. On main, manually set the EmailFieldPrimary syspref to empty $ ktd --shell k$ koha-mysql kohadev 2. Enable `AutoEmailNewUser` 3. Create a new user => FAIL: Koha explodes like: ``` The method Koha::Patron-> is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 992 Koha::Object::AUTOLOAD('Koha::Patron=HASH(0xaaaae37ac550)') called at /kohadevbox/koha/Koha/Patron.pm line 1662 Koha::Patron::notice_email_address('Koha::Patron=HASH(0xaaaae37ac550)') called at /kohadevbox/koha/members/memberentry.pl line 448 ... 4. Apply this patches 5. Run: k$ updatedatabase => SUCCESS: Update succeeds 6. Restart all and retry creating a patron => SUCCESS: It worked! 7. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171163|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171450&action=edit Bug 37757: (follow-up) Warn on bad values and survive Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good spot, all working as described and unit tested. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like this change broke tests, please fix! # Failed test 'SendQueuedMessages fails when no to_address, patron notice email and RedirectGuaranteeEmail is not set' 17:11:40 koha_1 | # at t/db_dependent/Letters.t line 1158. 17:11:40 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:11:40 koha_1 | # found warning: FAIL: No 'to_address', email address or guarantors email address for borrowernumber (1606) at /kohadevbox/koha/C4/Letters.pm line 1394. 17:11:40 koha_1 | # expected to find warning: (?^u:No 'to_address', email address or guarantors email address for borrowernumber) 17:11:40 koha_1 | 17:11:40 koha_1 | # Failed test 'SendQueuedMessages is using the mocked send_or_die routine' 17:11:40 koha_1 | # at t/db_dependent/Letters.t line 1169. 17:11:40 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:11:40 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:11:40 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:11:40 koha_1 | # found warning: Fake send_or_die at t/db_dependent/Letters.t line 45. 17:11:40 koha_1 | # expected to find warning: (?^u:Fake send_or_die) 17:11:40 koha_1 | 17:11:40 koha_1 | # Failed test 'SendQueuedMessages is using the mocked send_or_die routine' 17:11:40 koha_1 | # at t/db_dependent/Letters.t line 1201. 17:11:40 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:11:40 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:11:40 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:11:40 koha_1 | # found warning: Fake send_or_die at t/db_dependent/Letters.t line 45. 17:11:40 koha_1 | # expected to find warning: (?^u:Fake send_or_die) 17:11:40 koha_1 | 17:11:40 koha_1 | # Failed test 'SendQueuedMessages is using the mocked send_or_die routine' 17:11:40 koha_1 | # at t/db_dependent/Letters.t line 1233. 17:11:40 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:11:40 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:11:40 koha_1 | # found warning: Fake send_or_die at t/db_dependent/Letters.t line 45. 17:13:26 koha_1 | # expected to find warning: (?^u:Fake send_or_die) 17:13:26 koha_1 | # Looks like you failed 4 tests of 19. 17:13:26 koha_1 | 17:13:26 koha_1 | # Failed test 'Test guarantor handling in SendQueuedMessages' 17:13:26 koha_1 | # at t/db_dependent/Letters.t line 1262. 17:13:26 koha_1 | 17:13:26 koha_1 | # Failed test 'SendQueuedMessages with limit 1' 17:13:26 koha_1 | # at t/db_dependent/Letters.t line 1402. 17:13:26 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:13:26 koha_1 | # found warning: Fake send_or_die at t/db_dependent/Letters.t line 45. 17:13:26 koha_1 | # expected to find warning: (?^u:Fake send_or_die) 17:13:26 koha_1 | 17:13:26 koha_1 | # Failed test 'SendQueuedMessages with limit 2' 17:13:26 koha_1 | # at t/db_dependent/Letters.t line 1409. 17:13:26 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:13:26 koha_1 | # found warning: Fake send_or_die at t/db_dependent/Letters.t line 45. 17:13:26 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:13:26 koha_1 | # found warning: Fake send_or_die at t/db_dependent/Letters.t line 45. 17:13:26 koha_1 | # expected to find warning: (?^u:Fake send_or_die) 17:13:26 koha_1 | # expected to find warning: (?^u:Fake send_or_die) 17:13:26 koha_1 | 17:13:26 koha_1 | # Failed test 'SendQueuedMessages with limit 3' 17:13:26 koha_1 | # at t/db_dependent/Letters.t line 1416. 17:13:26 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:13:26 koha_1 | # found warning: Fake send_or_die at t/db_dependent/Letters.t line 45. 17:13:26 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:13:26 koha_1 | # found warning: Fake send_or_die at t/db_dependent/Letters.t line 45. 17:13:26 koha_1 | # expected to find warning: (?^u:Fake send_or_die) 17:13:26 koha_1 | # expected to find warning: (?^u:Fake send_or_die) 17:13:26 koha_1 | 17:13:26 koha_1 | # Failed test 'SendQueuedMessages with limit 2 and domain limits' 17:13:26 koha_1 | # at t/db_dependent/Letters.t line 1447. 17:13:26 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:13:26 koha_1 | # found warning: Sending messages: domain wrong.net reached limit of 6/1m at /kohadevbox/koha/Koha/Notice/Util.pm line 97. 17:13:26 koha_1 | # found warning: Fake send_or_die at t/db_dependent/Letters.t line 45. 17:13:26 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:13:26 koha_1 | # found warning: Sending messages: domain fake1.domain reached limit of 1/1m at /kohadevbox/koha/Koha/Notice/Util.pm line 97. 17:13:26 koha_1 | # found warning: Fake send_or_die at t/db_dependent/Letters.t line 45. 17:13:26 koha_1 | # expected to find warning: (?^u:wrong.net reached limit) 17:13:26 koha_1 | # expected to find warning: (?^u:Fake send_or_die) 17:13:26 koha_1 | # expected to find warning: (?^u:fake1.domain reached limit) 17:13:26 koha_1 | # expected to find warning: (?^u:Fake send_or_die) 17:13:26 koha_1 | # Looks like you failed 4 tests of 18. 17:13:26 koha_1 | 17:13:26 koha_1 | # Failed test 'Test limit parameter for SendQueuedMessages' 17:13:26 koha_1 | # at t/db_dependent/Letters.t line 1452. 17:13:26 koha_1 | # Looks like you failed 2 tests of 103. 17:13:26 koha_1 | [15:11:39] t/db_dependent/Letters.t .................................................... 17:13:26 koha_1 | Dubious, test returned 2 (wstat 512, 0x200) 17:13:26 koha_1 | Failed 2/103 subtests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This one too: 17:05:38 koha_1 | # Failed test 'WELCOME notice Prepared, Enqueued and Send' 17:05:38 koha_1 | # at t/db_dependent/Auth_with_shibboleth.t line 233. 17:05:38 koha_1 | # found warning: Invalid value for EmailFieldPrimary (OFF) at /kohadevbox/koha/Koha/Patron.pm line 1645. 17:05:38 koha_1 | # found warning: GetPreparedLetter called at t/db_dependent/Auth_with_shibboleth.t line 62. 17:05:38 koha_1 | # found warning: EnqueueLetter called at t/db_dependent/Auth_with_shibboleth.t line 66. 17:05:38 koha_1 | # found warning: SendQueuedMessages called with message_id: 42 at t/db_dependent/Auth_with_shibboleth.t line 72. 17:05:38 koha_1 | # expected to find warning: GetPreparedLetter called 17:05:38 koha_1 | # expected to find warning: EnqueueLetter called 17:05:38 koha_1 | # expected to find warning: SendQueuedMessages called with message_id: 42 17:05:38 koha_1 | # Looks like you failed 1 test of 52. 17:05:38 koha_1 | 17:05:38 koha_1 | # Failed test 'checkpw_shib tests' 17:05:38 koha_1 | # at t/db_dependent/Auth_with_shibboleth.t line 291. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 171496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171496&action=edit Bug 37757: (follow-up) Adjust existing tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. I think we might need to revisit koha-misc4dev's default configuration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply easy on 23.11.x This case surely is not often. I propose to skip for stability. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #21 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37757 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |david@davidnind.com --- Comment #22 from David Nind <david@davidnind.com> --- No updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org