[Bug 43098] New: Typo in guided_reports_start.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 Bug ID: 43098 Summary: Typo in guided_reports_start.tt Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com Target Milestone: --- Commit Bug 34478 Add 'op' to reports/guided_reports added a typo in URL args : <a href="/cgi-bin/koha/reports/guided_reports.pl?op=edit_formid=[% id | uri %]" Should be : <a href="/cgi-bin/koha/reports/guided_reports.pl?op=edit_form&id=[% id | uri %]" Found with : git grep "op=[^& ]*=" -- '*\.tt' No match in perl files nor includes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42194 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 202098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202098&action=edit Bug 43098: Typo edit_formid in guided_reports_start.tt Typo in edit SQL when authorised values category is wrong : 'op=edit_formid=' Test plan: 1) Create a new authorised values category WRONG 2) Create a new SQL report with : SELECT * FROM biblio WHERE title LIKE <<val|WRONG>> 3) Save the report 4) Delete authorised values category WRONG 5) Run the SQL report 6) You see message 'The authorized value category (WRONG) you selected does not exist.' 7) Click on 'Edit SQL' => You comme back to editing the correct SQL report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202098|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 202127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202127&action=edit Bug 43098: Typo edit_formid in guided_reports_start.tt Typo in edit SQL when authorised values category is wrong : 'op=edit_formid=' Test plan: 1) Create a new authorised values category WRONG 2) Create a new SQL report with : SELECT * FROM biblio WHERE title LIKE <<val|WRONG>> 3) Save the report 4) Delete authorised values category WRONG 5) Run the SQL report 6) You see message 'The authorized value category (WRONG) you selected does not exist.' 7) Click on 'Edit SQL' => You comme back to editing the correct SQL report Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Typo in |Typo in URL for "Edit SQL" |guided_reports_start.tt |button in guided reports | |(guided_reports_start.tt) CC| |david@davidnind.com Text to go in the| |This fixes a typo in the release notes| |URL when editing the SQL in | |reports. If there is an | |error in the SQL, the "Edit | |SQL" button would take you | |to the guided reports | |wizard, instead of letting | |you edit the SQL for the | |report. | | | |(Changes | |".../guided_reports.pl?op=e | |dit_formid=..." to | |".../guided_reports.pl?op=e | |dit_form&id=..." - note the | |missing &) --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. I didn't need to delete the authorized values category in step 4 to generate the error message. Before and after for the URL fixed: <a href="/cgi-bin/koha/reports/guided_reports.pl?op=edit_formid=[% id | uri %]" class="btn btn-primary">Edit SQL</a> <a href="/cgi-bin/koha/reports/guided_reports.pl?op=edit_form&id=[% id | uri %]" class="btn btn-primary">Edit SQL</a> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202127|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 202543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202543&action=edit Bug 43098: Typo edit_formid in guided_reports_start.tt Typo in edit SQL when authorised values category is wrong : 'op=edit_formid=' Test plan: 1) Create a new authorised values category WRONG 2) Create a new SQL report with : SELECT * FROM biblio WHERE title LIKE <<val|WRONG>> 3) Save the report 4) Delete authorised values category WRONG 5) Run the SQL report 6) You see message 'The authorized value category (WRONG) you selected does not exist.' 7) Click on 'Edit SQL' => You comme back to editing the correct SQL report Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43098 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org