[Bug 13657] New: Don't show extra comma after guarantor name on patron details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Bug ID: 13657 Summary: Don't show extra comma after guarantor name on patron details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If a patron is linked to an organisation, the name of the 'guarantor' is shown on the patron details page in staff. An organisation has no firstname, but the template expects one and adds an extra comma after the name. Example: Garantor: Organisation, To test: - Create 2 patrons, one each for - an organisation type patron category - a member of organisation type patron category - Link both from the 'member patron' edit form - Note that the guarantor is now shown on the details tab - Verify there is an extra comma after the organisation's name -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 --- Comment #1 from Thomas Wright <tomsStudy@gmail.com> --- Created attachment 35775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35775&action=edit Bug 13657 - Don't show extra comma after guarantor name on patron details Removed second name and comma from template file Testing plan: - Create 2 patrons, one each for - an organisation type patron category - a member of organisation type patron category - Link both from the 'member patron' edit form - Note that the guarantor is now shown on the details tab - Verify there is no extra comma after the organisation's name -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Thomas Wright <tomsStudy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomsStudy@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 35805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35805&action=edit [ALTERNATIVE PATCH] Bug 13657 - Don't show extra comma after guarantor name on patron details This patch suppresses the first name part (including comma) if first name is empty. This way, first name is still displays with natural persons, but not with organizations. To test: Apply this patch (without the first patch). Have one patron with a natural person as guarantor and one patron with an organization as guarantor. Verify that both display properly on the patron details page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Attachment #35775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35805|[ALTERNATIVE PATCH] Bug |Bug 13657 - Don't show description|13657 - Don't show extra |extra comma after guarantor |comma after guarantor name |name on patron details |on patron details | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35805|0 |1 is obsolete| | --- Comment #3 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 36266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36266&action=edit Bug 13657 - Don't show extra comma after guarantor name on patron details This patch suppresses the first name part (including comma) if first name is empty. This way, first name is still displays with natural persons, but not with organizations. To test: Apply this patch (without the first patch). Have one patron with a natural person as guarantor and one patron with an organization as guarantor. Verify that both display properly on the patron details page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36266|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36548&action=edit [PASSED QA] Bug 13657 - Don't show extra comma after guarantor name on patron details This patch suppresses the first name part (including comma) if first name is empty. This way, first name is still displays with natural persons, but not with organizations. To test: Apply this patch (without the first patch). Have one patron with a natural person as guarantor and one patron with an organization as guarantor. Verify that both display properly on the patron details page. Signed-off-by: Jesse Maseto <Jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org