[Bug 41803] New: Improvements to consistency in basket groups template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 Bug ID: 41803 Summary: Improvements to consistency in basket groups template Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I'd like to make a few changes to the basket groups template for consistency and validity. The main change is to make the basket group action buttons consistent with other tables in Koha with an "actions" column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192840&action=edit Bug 41803: Improvements to consistency in basket groups template This patch makes some updates to the basket groups template: - Buttons in a table's "actions" column should have the class "btn btn-default btn-xs" - Adding icons to action buttons - Group export options (CSV and PDF) under button dropdown - Use class instead of ID as hook for closing and deleting basket groups. This prevents duplicate element IDs on the page. - When there is no EDIFACT configuration, disable the "Generate EDIFACT order" button and put the error message in a tooltip. - Style warning message as Bootstrap alert To test, apply the patch and go to Acquisitions and locate a vendor. - View the vendor details. - Click "Basket groups" in the sidebar. - Create multiple basket groups if necessary. - Test various operations in the list of open groups: - Close and export PDF - Edit - Delete - Test the actions for a closed basket group: - Reopen - Export -> CSV and Export -> PDF - Enable the EDIFACT system preference but do not add any EDI accounts. - Under the "Closed" basket group tab the "Generate EDIFACT order" buttons should be disabled, and hovering over each one should trigger a popup warning that there is no EDIFACT configuration for the vendor. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... git bz apply 41803 Bug 41803 - Improvements to consistency in basket groups template 192840 - Bug 41803: Improvements to consistency in basket groups template Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 41803: Improvements to consistency in basket groups template Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 41803: Improvements to consistency in basket groups template -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192840|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 193342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193342&action=edit Bug 41803: Improvements to consistency in basket groups template This patch makes some updates to the basket groups template: - Buttons in a table's "actions" column should have the class "btn btn-default btn-xs" - Adding icons to action buttons - Group export options (CSV and PDF) under button dropdown - Use class instead of ID as hook for closing and deleting basket groups. This prevents duplicate element IDs on the page. - When there is no EDIFACT configuration, disable the "Generate EDIFACT order" button and put the error message in a tooltip. - Style warning message as Bootstrap alert To test, apply the patch and go to Acquisitions and locate a vendor. - View the vendor details. - Click "Basket groups" in the sidebar. - Create multiple basket groups if necessary. - Test various operations in the list of open groups: - Close and export PDF - Edit - Delete - Test the actions for a closed basket group: - Reopen - Export -> CSV and Export -> PDF - Enable the EDIFACT system preference but do not add any EDI accounts. - Under the "Closed" basket group tab the "Generate EDIFACT order" buttons should be disabled, and hovering over each one should trigger a popup warning that there is no EDIFACT configuration for the vendor. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193342|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 193365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193365&action=edit Bug 41803: Improvements to consistency in basket groups template This patch makes some updates to the basket groups template: - Buttons in a table's "actions" column should have the class "btn btn-default btn-xs" - Adding icons to action buttons - Group export options (CSV and PDF) under button dropdown - Use class instead of ID as hook for closing and deleting basket groups. This prevents duplicate element IDs on the page. - When there is no EDIFACT configuration, disable the "Generate EDIFACT order" button and put the error message in a tooltip. - Style warning message as Bootstrap alert To test, apply the patch and go to Acquisitions and locate a vendor. - View the vendor details. - Click "Basket groups" in the sidebar. - Create multiple basket groups if necessary. - Test various operations in the list of open groups: - Close and export PDF - Edit - Delete - Test the actions for a closed basket group: - Reopen - Export -> CSV and Export -> PDF - Enable the EDIFACT system preference but do not add any EDI accounts. - Under the "Closed" basket group tab the "Generate EDIFACT order" buttons should be disabled, and hovering over each one should trigger a popup warning that there is no EDIFACT configuration for the vendor. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This change makes updates release notes| |to the basket groups | |template: | |- Action buttons in the | |basket group table's | |"actions" column now | | have the class "btn | |btn-default btn-xs" | |(previously they were | |larger, | | yellow buttons, now they | |are smaller buttons with a | |light grey | | background) | |- Action buttons now have | |icons | |- Export action: there is | |now a dropdown list of | |export | | options (CSV and PDF) | |- Edit and delete actions: | |now use a class instead of | |an ID as a hook - | | this prevents duplicate | |element IDs on the page. | |- Generate EDIFACT order | |action: when there is no | |EDIFACT configuration, | | the action button is | |disabled and the error | |message is in a tooltip. | |- Warning messages styled | |as standard Bootstrap | |alerts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please fill Assignee -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #5)
Please fill Assignee
This operation does not require specialized knowledge. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Comma delimited| |Athens County Public list of Sponsors| |Libraries Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200458&action=edit Bug 41803: Improvements to consistency in basket groups template This patch makes some updates to the basket groups template: - Buttons in a table's "actions" column should have the class "btn btn-default btn-xs" - Adding icons to action buttons - Group export options (CSV and PDF) under button dropdown - Use class instead of ID as hook for closing and deleting basket groups. This prevents duplicate element IDs on the page. - When there is no EDIFACT configuration, disable the "Generate EDIFACT order" button and put the error message in a tooltip. - Style warning message as Bootstrap alert To test, apply the patch and go to Acquisitions and locate a vendor. - View the vendor details. - Click "Basket groups" in the sidebar. - Create multiple basket groups if necessary. - Test various operations in the list of open groups: - Close and export PDF - Edit - Delete - Test the actions for a closed basket group: - Reopen - Export -> CSV and Export -> PDF - Enable the EDIFACT system preference but do not add any EDI accounts. - Under the "Closed" basket group tab the "Generate EDIFACT order" buttons should be disabled, and hovering over each one should trigger a popup warning that there is no EDIFACT configuration for the vendor. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 --- Comment #8 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41803 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.02 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org