https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21335 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84947&action=edit Bug 21335: Remove redundant includes of right-to-left.css Fixes redundant includes of the right-to-left.css file. There is no need to include it in the .tt files as it's part of the doc-head-close.inc. Note: Make sure your *BaseURL preferences are correctly set as this will make the switching between languages work correctly and throw you back to the start page otherwise every time you switch Test: - Install an RTL language like Arabic (ar-Arab) - Test various pages with English and RTL language: - Authorities home page - Adding a new bibliographic record - Adding a new item or editing items - Advanced cataloguing (Rancor) editor - Labels start page - OPAC detail page - Verify display is correct and right-to-left.css is available -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21335 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21335 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com Status|Signed Off |Patch doesn't apply --- Comment #3 from Charles Farmer <charles.farmer@inlibro.com> --- Bug 10659 seems the be getting in the way of a clean apply. I'll rebase and submit my signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21335 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85184|0 |1 is obsolete| | --- Comment #4 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 85187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85187&action=edit Bug 21335: Remove redundant includes of right-to-left.css Fixes redundant includes of the right-to-left.css file. There is no need to include it in the .tt files as it's part of the doc-head-close.inc. Note: Make sure your *BaseURL preferences are correctly set as this will make the switching between languages work correctly and throw you back to the start page otherwise every time you switch Test: - Install an RTL language like Arabic (ar-Arab) - Test various pages with English and RTL language: - Authorities home page - Adding a new bibliographic record - Adding a new item or editing items - Advanced cataloguing (Rancor) editor - Labels start page - OPAC detail page - Verify display is correct and right-to-left.css is available Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21335 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85187|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85328&action=edit Bug 21335: Remove redundant includes of right-to-left.css Fixes redundant includes of the right-to-left.css file. There is no need to include it in the .tt files as it's part of the doc-head-close.inc. Note: Make sure your *BaseURL preferences are correctly set as this will make the switching between languages work correctly and throw you back to the start page otherwise every time you switch Test: - Install an RTL language like Arabic (ar-Arab) - Test various pages with English and RTL language: - Authorities home page - Adding a new bibliographic record - Adding a new item or editing items - Advanced cataloguing (Rancor) editor - Labels start page - OPAC detail page - Verify display is correct and right-to-left.css is available Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21335 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21335 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- i cant rebase this in 18.05.x and pass the qa tool: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt SKIP filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid FAIL valid_template : filter not found skipping unless needed -- You are receiving this mail because: You are watching all bug changes.