[Bug 28938] New: Correct Flatpickr's default 12hr time formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Bug ID: 28938 Summary: Correct Flatpickr's default 12hr time formatting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart+koha@gmail.com, testopia@bugs.koha-community.org Depends on: 28937 In calendar.inc we define the variable "flatpickr_timeformat_string" using this string: "h:i K" This results in times which don't include a leading zero (https://flatpickr.js.org/formatting/), a format which doesn't seem to be expected by the Perl script. It should be "G" To reproduce: - Set the TimeFormat system preference to "12 hour" - Find an item which is checked out and renewable. - Go to Circulation -> Renew and use the date picker to select a time < 12, e.g. 9:00 AM - Submit the barcode for renewal. - Check the patron's account to see the due date: Instead of being due on your selected date at 9:00AM it will be due on your selected date at 12:00AM. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 [Bug 28937] Use Flatpickr on circulation and patron pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124414&action=edit Bug 28938: Correct Flatpickr's default 12hr time formatting This patch corrects Flatpickr's default 12 time formatting so that it uses the formatting token "G" ("Hours, 2 digits with leading zeros") instead of "h" ("Hours, 2 digits without leading zeros"). This will prevent incorrect times from being saved when the submitted time is before 12. - To test, apply the patch go to Administration -> System preferences. - Set the TimeFormat system preference to "12 hour" - Find an item which is checked out and renewable. - Go to Circulation -> Renew and use the date picker to select a time < 12, e.g. 9:00 AM - Submit the barcode for renewal. - Check the patron's account to see the due date of the renewed item: It should match the date and time you selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28937 |28928 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928 [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr introduction https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 [Bug 28937] Use Flatpickr on circulation and patron pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 [Bug 28937] Use Flatpickr on circulation and patron pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124414|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 124417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124417&action=edit Bug 28938: Correct Flatpickr's default 12hr time formatting This patch corrects Flatpickr's default 12 time formatting so that it uses the formatting token "G" ("Hours, 2 digits with leading zeros") instead of "h" ("Hours, 2 digits without leading zeros"). This will prevent incorrect times from being saved when the submitted time is before 12. - To test, apply the patch go to Administration -> System preferences. - Set the TimeFormat system preference to "12 hour" - Find an item which is checked out and renewable. - Go to Circulation -> Renew and use the date picker to select a time < 12, e.g. 9:00 AM - Submit the barcode for renewal. - Check the patron's account to see the due date of the renewed item: It should match the date and time you selected. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 [Bug 28942] Use Flatpickr on acquisitions pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28945 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945 [Bug 28945] Use Flatpickr on administration pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Bug 28938 depends on bug 28928, which changed state. Bug 28928 Summary: Minor follow-ups to Bug 28376 - Flatpickr introduction https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28942 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 [Bug 28942] Use Flatpickr on acquisitions pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28945 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945 [Bug 28945] Use Flatpickr on administration pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org