[Bug 13043] New: Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 Bug ID: 13043 Summary: Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The staff client search history page template links to jquery.dataTables.columnFilter.js, but the link is incorrect. The plugin is not used, so the link can be removed altogether. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32071&action=edit Bug 13043 - Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page The staff client search history page does not required the DataTables columnFilter plugin, so the link (which pointed to the wrong location anyway) can be removed. To test, apply the patch and view your search history in the staff client. Table sorter functions (sorting, paging, and searching) should work correctly for current and previous sessions of catalog and authority searches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 32729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32729&action=edit Bug 13043 - Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page The staff client search history page does not required the DataTables columnFilter plugin, so the link (which pointed to the wrong location anyway) can be removed. To test, apply the patch and view your search history in the staff client. Table sorter functions (sorting, paging, and searching) should work correctly for current and previous sessions of catalog and authority searches. Signed-off-by: Frederic Demians <f.demians@tamil.fr> This patch just affects the staff search history page which is still fully functionnal after applying the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32071|0 |1 is obsolete| | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32071|1 |0 is obsolete| | CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32071|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32729|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32730&action=edit [PASSED QA] Bug 13043 - Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page The staff client search history page does not required the DataTables columnFilter plugin, so the link (which pointed to the wrong location anyway) can be removed. To test, apply the patch and view your search history in the staff client. Table sorter functions (sorting, paging, and searching) should work correctly for current and previous sessions of catalog and authority searches. Signed-off-by: Frederic Demians <f.demians@tamil.fr> This patch just affects the staff search history page which is still fully functionnal after applying the patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org