https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140786&action=edit Bug 31587: Basket not accessible from ACQORDER notice The parameter "aqbasket" is passed to GetPreparedLetter, but is always undefined for the notice ACQORDER. Test Plan: 1) Set your ACQORDER notice content to: ***[% basket %]*** 2) Set up a vendor with an email, set contact for email so the "E-mail order" button shows on a basket for that vendor 3) E-mail the basket 4) Note the email contents are "******" 5) Apply this patch 6) Restart all the things! 7) Email the basket again 8) Note the content looks something like: ***Koha::Acquisition::Basket=HASH(0x55870acd96e0)*** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 140787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140787&action=edit Bug 31587: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140788|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141538&action=edit Bug 31587: Basket not accessible from ACQORDER notice The parameter "aqbasket" is passed to GetPreparedLetter, but is always undefined for the notice ACQORDER. Test Plan: 1) Set your ACQORDER notice content to: ***[% basket %]*** 2) Set up a vendor with an email, set contact for email so the "E-mail order" button shows on a basket for that vendor 3) E-mail the basket 4) Note the email contents are "******" 5) Apply this patch 6) Restart all the things! 7) Email the basket again 8) Note the content looks something like: ***Koha::Acquisition::Basket=HASH(0x55870acd96e0)*** Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 30791 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, not a bad bug, but this would be SO helpful in lower versions :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This makes sure that the release notes| |basket object is passed to | |the ACQORDER notice in | |order to allow adding | |information about the | |basket and the order lines | |within it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 --- Comment #14 from wainuiwitikapark@catalyst.net.nz --- (In reply to Arthur Suzuki from comment #13)

applied to 21.11 for 21.11.15

I will backport this to 21.05.x for 21.05.22, however I cannot find this on your 21.11 branch to use the actual commit ID rather than the bugzilla patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldoldstable |RESOLVED --- Comment #17 from wainuiwitikapark@catalyst.net.nz --- (In reply to wainuiwitikapark from comment #16)

Not released in 21.05.22

Reverted from 21.05 branch -- You are receiving this mail because: You are watching all bug changes.