[Bug 43734] New: koha-create requires --create-db despite the documentation saying it's the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43734 Bug ID: 43734 Summary: koha-create requires --create-db despite the documentation saying it's the default Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: robin@kallisti.net.nz QA Contact: testopia@bugs.koha-community.org CC: mtj@kohaaloha.com Target Milestone: --- The documentation for koha-create says: DB usage mode: --create-db Create a new database on localhost. (default). however if you don't include this, no operation is defined inside koha-create and it just errors. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43734 --- Comment #1 from Robin Sheat <robin@kallisti.net.nz> --- Created attachment 207359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207359&action=edit Bug 43734: make --create-db the default for koha-create The documentation for koha-create says that if nothing else is specified, then it will make --create-db the default. However it wasn't doing this. This patch actually sets it as the default. It also fixes a minor typo. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43734 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207359|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43734 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207360&action=edit Bug 43734: make --create-db the default for koha-create The documentation for koha-create says that if nothing else is specified, then it will make --create-db the default. However it wasn't doing this. This patch actually sets it as the default. It also fixes a minor typo. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43734 Robin Sheat <robin@kallisti.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |robin@kallisti.net.nz |ity.org | Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43734 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43734 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |mtj@kohaaloha.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43734 --- Comment #3 from Robin Sheat <robin@kallisti.net.nz> --- Test plan: 1. using KTD or similar 2. run `ktd --shell --root` Without the patch: 3. run `debian/scripts/koha-create testing` 4. note that it errors out with something like: --- failed to load external entity "/etc/koha/sites/testing/koha-conf.xml" --- With the patch: 3. run `debian/scripts/koha-create testing` 4. note that it doesn't error, but instead creates the instance as requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43734 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|mtj@kohaaloha.com |m.de.rooy@rijksmuseum.nl Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43734 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207360|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43734 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 208293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208293&action=edit Bug 43734: make --create-db the default for koha-create The documentation for koha-create says that if nothing else is specified, then it will make --create-db the default. However it wasn't doing this. This patch actually sets it as the default. It also fixes a minor typo. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Pushed to main for 26.11 with consent from Pedro whilst he's on annual leave -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org