[Bug 26194] New: Messages about missing cash registers should link to cash register management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 Bug ID: 26194 Summary: Messages about missing cash registers should link to cash register management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 13985 If UseCashRegisters and EnablePointOfSale preferences are enabled but there are no cash registers defined, a message will appear in several places in Koha saying "You must have at least one cash register associated with the branch." If the user has permission, it would be helpful to include a link directly to new cash register creation. Also, the term "library" should be used instead of "branch." Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 108092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108092&action=edit Bug 26194: Add link to cash register management from message about missing registers In places where the interface warns the user about missing cash registers we should provide users with permission a direct link to the cash register management page. To test, apply the patch and enable the UseCashRegisters and EnablePointOfSale preferences. If necessary, go to Administration -> Cash registers and remove any cash registers for your library. - Log in to the staff interface as a user with "manage_cash_registers" permission. - Locate a patron who has outstanding fines. - Under Accounting -> Make a payment, click the "Pay" button next to a fine. - The page should show the message about missing cash registers with a button which take you directly to the "Add new cash register" form. - Perform the same check by selecting the checkbox next to a fine and clicking the "Pay amount" button and the "Pay selected" button. - Test the message shown at: - Tools -> Cashup registers. - Point of sale -> Register details - Point of sale -> Library details - Perform the same tests when logged in as a user without permission to manage cash registers. The messages shown in the previous steps should omit the button linking to cash register management. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice.. will test now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108092|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108127&action=edit Bug 26194: Add link to cash register management from message about missing registers In places where the interface warns the user about missing cash registers we should provide users with permission a direct link to the cash register management page. To test, apply the patch and enable the UseCashRegisters and EnablePointOfSale preferences. If necessary, go to Administration -> Cash registers and remove any cash registers for your library. - Log in to the staff interface as a user with "manage_cash_registers" permission. - Locate a patron who has outstanding fines. - Under Accounting -> Make a payment, click the "Pay" button next to a fine. - The page should show the message about missing cash registers with a button which take you directly to the "Add new cash register" form. - Perform the same check by selecting the checkbox next to a fine and clicking the "Pay amount" button and the "Pay selected" button. - Test the message shown at: - Tools -> Cashup registers. - Point of sale -> Register details - Point of sale -> Library details - Perform the same tests when logged in as a user without permission to manage cash registers. The messages shown in the previous steps should omit the button linking to cash register management. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108128&action=edit Bug 26194: (follow-up) Default to current branch When adding a new register, it would be helpful to default to the current logged in branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works well.. I do wonder if the block could be factored out into an include.. but we could/should probably do that on another bug report. I've added a followup to fix the 'Add register' form so it uses the PROCESS block from HTMLHelpers and as such we get the currently logged in branch selected in the dropdown by default (which with these links in place makes allot more sense than defaulting to the first one listed). Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Minor niggle to be looked at during QA.. the alert box styling has changed from 'alert' to 'info' (yellow background to blue background).. and the button styling doesn't look completely right to me yet... ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108127|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108313&action=edit Bug 26194: Add link to cash register management from message about missing registers In places where the interface warns the user about missing cash registers we should provide users with permission a direct link to the cash register management page. To test, apply the patch and enable the UseCashRegisters and EnablePointOfSale preferences. If necessary, go to Administration -> Cash registers and remove any cash registers for your library. - Log in to the staff interface as a user with "manage_cash_registers" permission. - Locate a patron who has outstanding fines. - Under Accounting -> Make a payment, click the "Pay" button next to a fine. - The page should show the message about missing cash registers with a button which take you directly to the "Add new cash register" form. - Perform the same check by selecting the checkbox next to a fine and clicking the "Pay amount" button and the "Pay selected" button. - Test the message shown at: - Tools -> Cashup registers. - Point of sale -> Register details - Point of sale -> Library details - Perform the same tests when logged in as a user without permission to manage cash registers. The messages shown in the previous steps should omit the button linking to cash register management. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108128|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108314&action=edit Bug 26194: (follow-up) Default to current branch When adding a new register, it would be helpful to default to the current logged in branch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #6)
Minor niggle to be looked at during QA.. the alert box styling has changed from 'alert' to 'info' (yellow background to blue background).. and the button styling doesn't look completely right to me yet... ?
I think that's ok, because blue = info, not indicating a real problem. I beleive the button looks similar in other spots too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26194 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org