[Bug 42910] New: Restore ability to save state for holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 Bug ID: 42910 Summary: Restore ability to save state for holdings table Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- Bug 38482 - Disable save state for items tables removed the ability to save the holding table's state due to conflicts with hidden columns. To make the holdings table behave like others in Koha, it would be useful if the save state feature could be restored in a way that doesn't conflict with automatically-hidden columns (along with adding default sorting to the holdings table per bug 38079). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Severity|enhancement |normal Status|NEW |ASSIGNED Depends on| |42332 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- I can have a look at this once bug 42332 is pushed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 [Bug 42332] Remove conditional TT tags from tables thead -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201054&action=edit Bug 42910: Restore save state for holdings tables Patch from commit b8378f9 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.11 |unspecified --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Hello Sara, I had a quick look and actually I am wondering if bug 41604 does not fix the problem already. Please test it and let me know if you find bugs! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #3)
Hello Sara,
I had a quick look and actually I am wondering if bug 41604 does not fix the problem already.
Please test it and let me know if you find bugs!
Hum nope, sorry. It is not enough. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201054|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201056&action=edit Bug 42910: Restore save state for holdings tables Patch from commit 74d1e2e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- I think this is looking good, ready for testing, not for inclusion yet (Cypress tests missing) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201060&action=edit Bug 42910: Add Cypress tests Patch from commit 74a8f86 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|42332 |41604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 [Bug 41604] Impossible to hide Checkin column in issues-table in circ/circulation.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 [Bug 42332] Remove conditional TT tags from tables thead -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #8 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested this in a sandbox and checked the "Save configuration state on page change:" for the holdings_table and otherholdings_table. If I selected a new column (for example "issues") to be shown from the Configuration dropdown and changed the page, the column did not stay shown. If I took off selection from one of the preselected columns (for exampe "collection"), that one stayed hidden when I moved to another record. And if I selected it again to be shown, it stayed shown when changing to another record. "Save search state on page change:" selection worked as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Good catch, you found yet another edge case :D It happens for "Checkouts"/issues because it is hidden by default in the config... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201564&action=edit Bug 42910: Keep column displayed if user decided If "Checkouts" is hidden by default in the config but the user wants to display it, we should keep it visible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Anneli Österman from comment #8)
If I selected a new column (for example "issues") to be shown from the Configuration dropdown and changed the page, the column did not stay shown.
Should be fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 --- Comment #12 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested again and I think there is still something strange happening here. Test 1: I took off all "Is hidden by default" checksmarks from table configuration, logged out (so that cache is emptied), logged in and made a search. Then opened one of the records. Checked everything visible from Columns dropdown menu and used an arrow to move to the next record. Then I opened the Columns dropdown menu and only some of the columns were still checked. See attachment b42910-1.png. Test 2: This time I hid all columns from table configuration. Logged out and in, made a search and checked all columns visible from the Columns dropdown menu. Then moved to the next record. Again, only some of the columns were visible. See attachment b42910-2.png. There is only one difference to the first test: Call number also stays visible. Same seems to happen when holdings table is seperated into two tabs with SeparateHoldings and SeparateHoldingsBranch systempreferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 --- Comment #13 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- Created attachment 201653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201653&action=edit Screenshot 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 --- Comment #14 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- Created attachment 201654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201654&action=edit Screenshot 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Anneli Österman from comment #12)
I tested again and I think there is still something strange happening here.
Test 1: I took off all "Is hidden by default" checksmarks from table configuration, logged out (so that cache is emptied), logged in and made a search. Then opened one of the records. Checked everything visible from Columns dropdown menu and used an arrow to move to the next record. Then I opened the Columns dropdown menu and only some of the columns were still checked. See attachment b42910-1.png.
Test 2: This time I hid all columns from table configuration. Logged out and in, made a search and checked all columns visible from the Columns dropdown menu. Then moved to the next record. Again, only some of the columns were visible. See attachment b42910-2.png. There is only one difference to the first test: Call number also stays visible.
Same seems to happen when holdings table is seperated into two tabs with SeparateHoldings and SeparateHoldingsBranch systempreferences
Yes, this is how it's expecting to work on this table (if I understand correctly what you reported). This is related to the warning in the admin: "Please note that if a field is not used on the first page of items in the holdings table, it will be automatically hidden from display and can be made visible on demand. You can still use the column configuration to permanently hide columns from the holdings table." If a column has no value (ie. is empty for all rows) then it's hidden automatically. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 --- Comment #16 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I see. Doesn't that cause quite unpredictable behaviour when browsing search result? For example, if the first result does not have collection code -> column is hidden. Then I move to the next one where the collection column is still hidden even when there is data in it and I have to make it visible again. Then I browse on and every time I encounter a bibliographic record that has items with no collection code the column is hidden. And I have to make it visible again. That would frustrate me on a long run. I would expect that if I explicitly choose certain columns to be visible, they stay visible. We do not add collection code to all items but when we do, it is important to see it because it tells where the item is located inside the library building. Collection code is only one example and other columns also show important information for the person doing the search. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org