[Bug 27063] New: Allow changing which record an order is linked to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Bug ID: 27063 Summary: Allow changing which record an order is linked to Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org At the moment if the basket is still open you can update the bbliographic details of an order or overwrite the existing record via Z39.50, but if you notice that you have used the wrong record, there is no way to fix this. It would be great if it was possible to change the record an order is linked to while the basket is still open. This should explicitly allow to use a record that is already in the catalog. -- There is also a use case here for libraries using standing orders for tracking electronic resources such as series. They usually place the order on the series record. When the volumes arrive they'd like to change it so the acq information is tied to the volume. But without using items (which is not the case here for electronic resources), this is not possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167619&action=edit Bug 27063: Add modal for linking a basket order to a different record Still WIP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167619|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167678&action=edit Bug 27063: Add modal for linking a basket order to a different record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167679&action=edit Bug 27063: [WIP] Link different record to order from existing records So far this works for * from an existing record * from a suggestion * from a new (empty) record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167678|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167783&action=edit Bug 27063: Add modal for linking a basket order to a different record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167679|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167784&action=edit Bug 27063: [WIP] Link different record to order from existing records So far this works for * from an existing record * from a suggestion * from a new (empty) record * from a subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37109 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 [Bug 37109] Don't provide old claims fields when duplicating acquisitions orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167783|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167818&action=edit Bug 27063: Add modal for linking a basket order to a different record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167784|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167819&action=edit Bug 27063: [WIP] Link different record to order from existing records So far this works for * from an existing record * from a suggestion * from a new (empty) record * from a subscription * from existing orders (copy) Working on: * from an external source -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167818|0 |1 is obsolete| | Attachment #167819|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 168049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168049&action=edit Bug 27063: Add modal for linking a basket order to a different record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 168050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168050&action=edit Bug 27063: Link different record to order from existing records This patch adds the ability to link an order to a different record. This applies to: * orders in open baskets (not closed) * unreceived orders in standing baskets Orders can be linked: * from an existing record * from a suggestion * from a subscription * from a new (empty) record * from existing orders (copy) * from an external source To test: 1. Apply the patches and restart services 2. Create a normal basket (do not check 'orders are standing'). Add an order to the basket. 3. Notice there is a 'Link to different record' option in the Modify column. 4. Close the basket. 5. Create another basket, this time do check the 'orders are standing' option. Add two orders to the basket. 6. Click 'Link to different record' for one of the orders. 7. Create a suggestion. Create a subscription. Have a MARC record available to stage/import. 8. Loop through each option, linking: * from an existing record * from a suggestion * from a subscription * from a new (empty) record * from existing orders (copy) * from an external source Make sure that the accounting information is always kept, and just the record details of the order are changed. 9. Go to the vendor page and click 'Receive shipments'. Fill in invoice details. 10. On the receiving page, 'Receive' one of your standing orders. Increment the quantity and finish receiving. 11. Go to the standing basket. Confirm there is no 'Link to different record' option for the received order. Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168050|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 168571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168571&action=edit Bug 27063: Link different record to order from existing records This patch adds the ability to link an order to a different record. This applies to: * orders in open baskets (not closed) * unreceived orders in standing baskets Orders can be linked: * from an existing record * from a suggestion * from a subscription * from a new (empty) record * from existing orders (copy) * from an external source To test: 1. Apply the patches and restart services 2. Create a normal basket (do not check 'orders are standing'). Add an order to the basket. 3. Notice there is a 'Link to different record' option in the Modify column. 4. Close the basket. 5. Create another basket, this time do check the 'orders are standing' option. Add two orders to the basket. 6. Click 'Link to different record' for one of the orders. 7. Create a suggestion. Create a subscription. Have a MARC record available to stage/import. 8. Loop through each option, linking: * from an existing record * from a suggestion * from a subscription * from a new (empty) record * from existing orders (copy) * from an external source Make sure that the accounting information is always kept, and just the record details of the order are changed. 9. Go to the vendor page and click 'Receive shipments'. Fill in invoice details. 10. On the receiving page, 'Receive' one of your standing orders. Increment the quantity and finish receiving. 11. Go to the standing basket. Confirm there is no 'Link to different record' option for the received order. Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 168572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168572&action=edit Bug 27063: Allow received orders to also be relinked Useful for when the bibliographic records of received orders have been deleted, but we want to keep the ordernumber history/invoice data etc. To test: 1. Add an order to a standing basket 2. Receive the order 3. Once received, delete the record attached to the order 4. Go back to the basket 5. Attempt to relink the order with the deleted record 6. This should work Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33305 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Need to also update the invoice of a relinked order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170123&action=edit Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement This follow-up patch adds a new system preference KeepInvoiceOnOrderRelink. When enabled, relinking a received order will keep the invoice ID of the original order. This is useful for standing orders where the record has been deleted and relinked. To test: 1. Enable the system preference KeepInvoiceOnOrderRelink 2. Add an order to a standing basket 3. Receive the order 4. Once received, go to the record and view the Acquisitions details tab. Notice the invoice is linked. 5. Go back to the basket 6. Relink the received order to a different record 7. Go to the record and view the Acquisitions details tab. Notice the invoice has been kept. 8. Repeat the test plan with the system preference KeepInvoiceOnOrderRelink disabled. Notice the invoice is nullified after the order is relinked. Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170123|0 |1 is obsolete| | --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170166&action=edit Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement This follow-up patch adds a new system preference KeepInvoiceOnOrderRelink. When enabled, relinking a received order will keep the invoice ID of the original order. This is useful for standing orders where the record has been deleted and relinked. To test: 1. Enable the system preference KeepInvoiceOnOrderRelink 2. Add an order to a standing basket 3. Receive the order 4. Once received, go to the record and view the Acquisitions details tab. Notice the invoice is linked. 5. Go back to the basket 6. Relink the received order to a different record 7. Go to the record and view the Acquisitions details tab. Notice the invoice has been kept. 8. Repeat the test plan with the system preference KeepInvoiceOnOrderRelink disabled. Notice the invoice is nullified after the order is relinked. Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10758 --- Comment #15 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Aleisha Amohia from comment #11)
Created attachment 168572 [details] [review] Bug 27063: Allow received orders to also be relinked
Useful for when the bibliographic records of received orders have been deleted, but we want to keep the ordernumber history/invoice data etc.
To test:
1. Add an order to a standing basket 2. Receive the order 3. Once received, delete the record attached to the order 4. Go back to the basket 5. Attempt to relink the order with the deleted record 6. This should work
This one does not work. But I do not understand why it is necessary. We already store the biblionumber of the deleted record in the orderline and since Bug 10758 we display the title of this deleted record. So we already keep the ordernumber history/invoice data etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170166|0 |1 is obsolete| | --- Comment #16 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170487&action=edit Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement This follow-up patch adds a new system preference KeepInvoiceOnOrderRelink. When enabled, relinking a received order will keep the invoice ID of the original order. This is useful for standing orders where the record has been deleted and linked to a new record/order. To test: 1. Enable the system preference KeepInvoiceOnOrderRelink 2. Add an order to a standing basket 3. Receive the order 4. Once received, go to the record and view the Acquisitions details tab. Notice the invoice is linked. 5. Go back to the basket 6. Relink the received order to a different record 7. Go to the record and view the Acquisitions details tab. Notice the invoice has been kept. 8. Repeat the test plan with the system preference KeepInvoiceOnOrderRelink disabled. Notice the invoice is nullified after the order is relinked. Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170487|0 |1 is obsolete| | --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170488&action=edit Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement This follow-up patch adds a new system preference KeepInvoiceOnOrderRelink. When enabled, relinking a received order will keep the invoice ID of the original order. This is useful for standing orders where the record has been deleted and linked to a new record/order. To test: 1. Enable the system preference KeepInvoiceOnOrderRelink 2. Add an order to a standing basket 3. Receive the order 4. Once received, go to the record and view the Acquisitions details tab. Notice the invoice is linked. 5. Go back to the basket 6. Relink the received order to a different record 7. Go to the record and view the Acquisitions details tab. Notice the invoice has been kept. 8. Repeat the test plan with the system preference KeepInvoiceOnOrderRelink disabled. Notice the invoice is nullified after the order is relinked. Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|37109 |35402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 [Bug 37109] Don't provide old claims fields when duplicating acquisitions orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168049|0 |1 is obsolete| | --- Comment #18 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170692&action=edit Bug 27063: Add modal for linking a basket order to a different record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168571|0 |1 is obsolete| | --- Comment #19 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170693&action=edit Bug 27063: Link different record to order from existing records This patch adds the ability to link an order to a different record. This applies to: * orders in open baskets (not closed) * unreceived orders in standing baskets Orders can be linked: * from an existing record * from a suggestion * from a subscription * from a new (empty) record * from existing orders (copy) * from an external source To test: 1. Apply the patches and restart services 2. Create a normal basket (do not check 'orders are standing'). Add an order to the basket. 3. Notice there is a 'Link to different record' option in the Modify column. 4. Close the basket. 5. Create another basket, this time do check the 'orders are standing' option. Add two orders to the basket. 6. Click 'Link to different record' for one of the orders. 7. Create a suggestion. Create a subscription. Have a MARC record available to stage/import. 8. Loop through each option, linking: * from an existing record * from a suggestion * from a subscription * from a new (empty) record * from existing orders (copy) * from an external source Make sure that the accounting information is always kept, and just the record details of the order are changed. 9. Go to the vendor page and click 'Receive shipments'. Fill in invoice details. 10. On the receiving page, 'Receive' one of your standing orders. Increment the quantity and finish receiving. 11. Go to the standing basket. Confirm there is no 'Link to different record' option for the received order. Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168572|0 |1 is obsolete| | --- Comment #20 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170694&action=edit Bug 27063: Allow received orders to also be relinked Useful for when the bibliographic records of received orders have been deleted, but we want to keep the ordernumber history/invoice data etc. To test: 1. Add an order to a standing basket 2. Receive the order 3. Once received, delete the record attached to the order 4. Go back to the basket 5. Attempt to relink the order with the deleted record 6. This should work Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170488|0 |1 is obsolete| | --- Comment #21 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170695&action=edit Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement This follow-up patch adds a new system preference KeepInvoiceOnOrderRelink. When enabled, relinking a received order will keep the invoice ID of the original order. This is useful for standing orders where the record has been deleted and linked to a new record/order. To test: 1. Enable the system preference KeepInvoiceOnOrderRelink 2. Add an order to a standing basket 3. Receive the order 4. Once received, go to the record and view the Acquisitions details tab. Notice the invoice is linked. 5. Go back to the basket 6. Relink the received order to a different record 7. Go to the record and view the Acquisitions details tab. Notice the invoice has been kept. 8. Repeat the test plan with the system preference KeepInvoiceOnOrderRelink disabled. Notice the invoice is nullified after the order is relinked. Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 --- Comment #22 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170696&action=edit Bug 27063: Use Bootstrap 5 syntax for modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37109 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 [Bug 37109] Don't provide old claims fields when duplicating acquisitions orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #23 from David Nind <david@davidnind.com> --- The patch no longer applies - getting the SHA1/fake ancestor error. git bz apply 27063 Bug 27063 - Allow changing which record an order is linked to 170692 - Bug 27063: Add modal for linking a basket order to a different record 170693 - Bug 27063: Link different record to order from existing records 170694 - Bug 27063: Allow received orders to also be relinked 170695 - Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement 170696 - Bug 27063: Use Bootstrap 5 syntax for modal Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27063: Add modal for linking a basket order to a different record Applying: Bug 27063: Link different record to order from existing records Applying: Bug 27063: Allow received orders to also be relinked Applying: Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt). error: could not build fake ancestor Patch failed at 0001 Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170695|0 |1 is obsolete| | --- Comment #24 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 174648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174648&action=edit Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement This follow-up patch adds a new system preference KeepInvoiceOnOrderRelink. When enabled, relinking a received order will keep the invoice ID of the original order. This is useful for standing orders where the record has been deleted and linked to a new record/order. To test: 1. Enable the system preference KeepInvoiceOnOrderRelink 2. Add an order to a standing basket 3. Receive the order 4. Once received, go to the record and view the Acquisitions details tab. Notice the invoice is linked. 5. Go back to the basket 6. Relink the received order to a different record 7. Go to the record and view the Acquisitions details tab. Notice the invoice has been kept. 8. Repeat the test plan with the system preference KeepInvoiceOnOrderRelink disabled. Notice the invoice is nullified after the order is relinked. Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170696|0 |1 is obsolete| | --- Comment #25 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 174649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174649&action=edit Bug 27063: Use Bootstrap 5 syntax for modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Bug 27063 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 --- Comment #26 from David Nind <david@davidnind.com> --- I always struggle with acquisitions, so I'll leave up to someone else to test this properly. I did have a go at working through the test plan, here are the things I noted: General ------- 1. The patches still apply. Needed to run an updatedatabase (for the new system preference KeepInvoiceOnOrderRelink). Patch - Link different record to order from existing records ------------------------------------------------------------ 1. Step 8 - Options available: I only see these options for "Link to a different record": - From an existing record - From a suggestion - From a subscription - From a new (empty) record - From existing orders (copy) - From an external source I don't have: - From a new file - From a staged file - From titles with highest hold ratios 2. Step 8 - From an external source: The catalog details aren't filled in - is that expected? 3. Step 11 - Standing basket: There is still a "Link to different record" for the item received. Patch - Allow received orders to also be relinked ------------------------------------------------- 1. Not sure how to do step 5 - if I delete the record, I can't locate the record to re-link it to. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #26)
I don't have: - From a new file - From a staged file - From titles with highest hold ratios
Same, but I see they're not mentioned in the test plan, so expected?
2. Step 8 - From an external source: The catalog details aren't filled in - is that expected?
Same. And the order is saved as a new one, separate from the one chose to link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Bug 27063 depends on bug 37109, which changed state. Bug 37109 Summary: Don't provide old claims fields when duplicating acquisitions orders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Auckland University of list of Sponsors| |Technology Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170692|0 |1 is obsolete| | Attachment #170693|0 |1 is obsolete| | Attachment #170694|0 |1 is obsolete| | Attachment #174648|0 |1 is obsolete| | Attachment #174649|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 --- Comment #28 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 206767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206767&action=edit Bug 27063: Add modal for linking a basket order to a different record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 --- Comment #29 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 206768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206768&action=edit Bug 27063: Link different record to order from existing records This patch adds the ability to link an order to a different record. This applies to: * orders in open baskets (not closed) * unreceived orders in standing baskets Orders can be linked: * from an existing record * from a suggestion * from a subscription * from a new (empty) record * from existing orders (copy) * from an external source To test: 1. Apply the patches and restart services 2. Create a normal basket (do not check 'orders are standing'). Add an order to the basket. 3. Notice there is a 'Link to different record' option in the Modify column. 4. Close the basket. 5. Create another basket, this time do check the 'orders are standing' option. Add two orders to the basket. 6. Click 'Link to different record' for one of the orders. 7. Create a suggestion. Create a subscription. Have a MARC record available to stage/import. 8. Loop through each option, linking: * from an existing record * from a suggestion * from a subscription * from a new (empty) record * from existing orders (copy) * from an external source Make sure that the accounting information is always kept, and just the record details of the order are changed. 9. Go to the vendor page and click 'Receive shipments'. Fill in invoice details. 10. On the receiving page, 'Receive' one of your standing orders. Increment the quantity and finish receiving. 11. Go to the standing basket. Confirm there is no 'Link to different record' option for the received order. Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 --- Comment #30 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 206769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206769&action=edit Bug 27063: Allow received orders to also be relinked Useful for when the bibliographic records of received orders have been deleted, but we want to keep the ordernumber history/invoice data etc. To test: 1. Add an order to a standing basket 2. Receive the order 3. Once received, delete the record attached to the order 4. Go back to the basket 5. Attempt to relink the order with the deleted record 6. This should work Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 --- Comment #31 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 206770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206770&action=edit Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement This follow-up patch adds a new system preference KeepInvoiceOnOrderRelink. When enabled, relinking a received order will keep the invoice ID of the original order. This is useful for standing orders where the record has been deleted and linked to a new record/order. To test: 1. Enable the system preference KeepInvoiceOnOrderRelink 2. Add an order to a standing basket 3. Receive the order 4. Once received, go to the record and view the Acquisitions details tab. Notice the invoice is linked. 5. Go back to the basket 6. Relink the received order to a different record 7. Go to the record and view the Acquisitions details tab. Notice the invoice has been kept. 8. Repeat the test plan with the system preference KeepInvoiceOnOrderRelink disabled. Notice the invoice is nullified after the order is relinked. Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 --- Comment #32 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 206771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206771&action=edit Bug 27063: Use Bootstrap 5 syntax for modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |laurence.rault@biblibre.com --- Comment #33 from Laurence Rault <laurence.rault@biblibre.com> --- Error when I try to "Link to different record", after choosing a new record or an existing one : No property for Koha::Acquisition::Order at /usr/share/perl5/Exception/Class/Base.pm line 88 I also could do a suggestion : when linking to an existing record, if we display the full record, it should be better to have the same behaviour as in the results list, e.g. display the link "Relink to order" instead of "Add order". -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org