[Bug 19042] New: Silence warnings t/db_dependent/Letters.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 Bug ID: 19042 Summary: Silence warnings t/db_dependent/Letters.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org The Letters test mocks userenv, but fails to provide flags, which causes the C4::Context IsSuperLibrarian to generate noise. Add a pretty flag value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- prove -v t/db_dependent/Letters.t ... ok 31 - GetLetters gets the name correctly # Subtest: getletter 1..16 ok 1 - GetLetters gets the branch code correctly ok 2 - GetLetters gets the module correctly ok 3 - GetLetters gets the code correctly ok 4 - GetLetters gets the name correctly ok 5 - GetLetters gets the boolean is_html correctly ok 6 - GetLetters gets the title correctly ok 7 - GetLetters gets the content correctly ok 8 - GetLetters gets the message type correctly C4::Context->userenv not defined! at /home/mtompset/kohaclone/C4/Letters.pm line 207. ok 9 - GetLetters gets the branch code correctly ok 10 - GetLetters gets the module correctly ok 11 - GetLetters gets the code correctly ok 12 - GetLetters gets the name correctly ok 13 - GetLetters gets the boolean is_html correctly ok 14 - GetLetters gets the title correctly ok 15 - GetLetters gets the content correctly ok 16 - GetLetters gets the message type correctly ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 65510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65510&action=edit Bug 19042: Silence warnings t/db_dependent/Letters.t TEST PLAN --------- prove t/db_dependent/Letters.t -- there will be a message: "C4::Context->userenv not defined!" apply this patch prove t/db_dependent/Letters.t -- there will no longer be that message. run qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65510|0 |1 is obsolete| | --- Comment #3 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 65511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65511&action=edit Bug 19042: Silence warnings t/db_dependent/Letters.t TEST PLAN --------- prove t/db_dependent/Letters.t -- there will be a message: "C4::Context->userenv not defined!" apply this patch prove t/db_dependent/Letters.t -- there will no longer be that message. run qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65511|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65835&action=edit Bug 19042: Silence warnings t/db_dependent/Letters.t TEST PLAN --------- prove t/db_dependent/Letters.t -- there will be a message: "C4::Context->userenv not defined!" apply this patch prove t/db_dependent/Letters.t -- there will no longer be that message. run qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65836&action=edit Bug 19042: Add mock IndependentBranches=0 for the other test These tests do not cover correctly getletter, but it is not the goal of this patch. Superlibrarian behaviour must be tested as well. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org